Sign upLogin

bookboon/api-php

View on GitHub
Star

Showing 32 of 32 total issues

Method makeRequest has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        string $relativeUrl,
        array $variables = [],
        string $httpMethod = ClientInterface::HTTP_GET,
        bool $shouldCache = true,
        string $contentType = ClientInterface::CONTENT_TYPE_JSON
Severity: Minor
Found in src/Client/RequestTrait.php - About 35 mins to fix

    Method search has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            Bookboon $bookboon,
        string $query,
        int $limit = 10,
        int $offset = 0,
         array $bookTypes = ['professional']
    Severity: Minor
    Found in src/Entity/Book.php - About 35 mins to fix

      Method rawRequest has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              string $url,
        array $variables = [],
        string $httpMethod = ClientInterface::HTTP_GET,
        bool $shouldCache = true,
        string $classString = Entity::class
      Severity: Minor
      Found in src/Bookboon.php - About 35 mins to fix

        Method recommendations has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                Bookboon $bookboon,
        array $bookIds = [],
        int $limit = 5,
        array $bookTypes = ['professional'],
        array $params = []
        Severity: Minor
        Found in src/Entity/Book.php - About 35 mins to fix

          Method makeRequest has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  string $relativeUrl,
        array $variables = [],
        string $httpMethod = self::HTTP_GET,
        bool $shouldCache = true,
        string $contentType = self::CONTENT_TYPE_FORM
          Severity: Minor
          Found in src/Client/ClientInterface.php - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public static function getByBookId(Bookboon $bookboon, string $bookId) : BookboonResponse
    {
        $bResponse = $bookboon->rawRequest(
            "/v1/books/$bookId/exams",
            [],
            Severity: Minor
            Found in src/Entity/Exam.php and 1 other location - About 35 mins to fix
            src/Entity/Author.php on lines 78..93

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 92.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public static function getByBookId(Bookboon $bookboon, string $bookId) : BookboonResponse
    {
        $bResponse = $bookboon->rawRequest(
            "/v1/books/$bookId/authors",
            [],
            Severity: Minor
            Found in src/Entity/Author.php and 1 other location - About 35 mins to fix
            src/Entity/Exam.php on lines 54..69

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 92.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function recursiveBlacklist has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                private static function recursiveBlacklist(array &$categories, array $blacklistedCategoryIds) : void
    {
        $hasAlteredArray = false;

        foreach ($categories as $key => $category) {
            Severity: Minor
            Found in src/Entity/Category.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function thumbnailResolver has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function thumbnailResolver($thumbnails, $size) : string
    {
        if (false === is_array($thumbnails) || count($thumbnails) === 0) {
            return '';
        }
            Severity: Minor
            Found in src/Entity/Entity.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getParentRequestHeaders has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function getParentRequestHeaders(): array
    {
        if (!function_exists('apache_request_headers')) {
            $out = [];
            Severity: Minor
            Found in src/Client/Oauth/BookboonProvider.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public static function remove(Bookboon $bookboon, string $email, ?string $alias) : bool
    {
        $options = [
            'email' => $email,
            'hasConsented' => false
            Severity: Minor
            Found in src/Entity/Subscription.php and 1 other location - About 30 mins to fix
            src/Entity/Subscription.php on lines 31..54

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 91.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public static function add(Bookboon $bookboon, string $email, bool $hasConsented, ?string $alias) : bool
    {
        $options = [
            'email' => $email,
            'hasConsented' => false
            Severity: Minor
            Found in src/Entity/Subscription.php and 1 other location - About 30 mins to fix
            src/Entity/Subscription.php on lines 63..86

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 91.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language