bookbrainz/bookbrainz-site

Function handleRemoveEntities has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    handleRemoveEntities() {
        if (this.state.selectedEntities.length) {
            const bbids = this.state.selectedEntities;
            const submissionUrl = `/collection/${this.props.collection.id}/remove`;
            request.post(submissionUrl)

Function getOrderedRevisionsForEntityPage has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

export async function getOrderedRevisionsForEntityPage(orm: any, from: number, size: number, RevisionModel, bbid: string) {
    const otherMergedBBIDs = await recursivelyGetMergedEntitiesBBIDs(orm, [bbid]);

    const revisions = await new RevisionModel()
        .query((qb) => {

Function makeSortName has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function makeSortName(name: string): string {
    const articles = ['a', 'an', 'the', 'los', 'las', 'el', 'la'];
    const suffixes = [
        'i', 'ii', 'iii', 'iv', 'v', 'vi', 'vii', 'viii', 'ix', 'x', 'xi',
        'xii', 'xiii', 'xiv', 'xv', 'jr', 'junior', 'sr', 'senior', 'phd', 'md',

Similar blocks of code found in 6 locations. Consider refactoring.

Open

function _setSeriesTitle(res) {
    res.locals.title = utils.createEntityPageTitle(
        res.locals.entity,
        'Series',
        utils.template`Series “${'name'}”`

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

function _setWorkTitle(res) {
    res.locals.title = utils.createEntityPageTitle(
        res.locals.entity,
        'Work',
        utils.template`Work “${'name'}”`

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

function _setEditionTitle(res) {
    res.locals.title = utils.createEntityPageTitle(
        res.locals.entity,
        'Edition',
        utils.template`Edition “${'name'}”`

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

function _setEditionGroupTitle(res) {
    res.locals.title = utils.createEntityPageTitle(
        res.locals.entity,
        'EditionGroup',
        utils.template`Edition Group “${'name'}”`

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

function _setAuthorTitle(res) {
    res.locals.title = utils.createEntityPageTitle(
        res.locals.entity,
        'Author',
        utils.template`Author “${'name'}”`

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

function _setPublisherTitle(res) {
    res.locals.title = utils.createEntityPageTitle(
        res.locals.entity,
        'Publisher',
        utils.template`Publisher “${'name'}”`

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

export function getEntityTable(entityType: string) {
    const tables = {
        Author: AuthorTable,
        Edition: EditionTable,
        EditionGroup: EditionGroupTable,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

export function getEntitySectionMerge(entityType: string) {
    const SECTION_MAP = {
        author: AuthorSectionMerge,
        edition: EditionSectionMerge,
        editionGroup: EditionGroupSectionMerge,

• Read up
  Read up

Function getOrderedRevisionForEditorPage has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

export async function getOrderedRevisionForEditorPage(from, size, req) {
    const {Editor, Revision} = req.app.locals.orm;

    // If editor isn't present, throw an error
    await new Editor({id: req.params.id})

Function addAuthorCreditRow has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function addAuthorCreditRow(state, newItemKey) {
    // Add a new empty author credit row
    let returnedState = state.set(newItemKey, EMPTY_CREDIT_ROW);

    const autoJoinPhraseRegex = /^(| & |, )$/;

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        const markup = ReactDOMServer.renderToString(
            <Layout    {...propHelpers.extractLayoutProps(props)}>
                <Index {...propHelpers.extractChildProps(props)}/>
            </Layout>
        );

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        const markup = ReactDOMServer.renderToString(
            <Layout {...propHelpers.extractLayoutProps(props)}>
                <CollectionsPage {...propHelpers.extractChildProps(props)}/>
            </Layout>
        );

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        const markup = ReactDOMServer.renderToString(
            <Layout {...propHelpers.extractLayoutProps(props)}>
                <RevisionsPage {...propHelpers.extractChildProps(props)}/>
            </Layout>
        );

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

    const aliases = editionGroup.aliasSet ?
        editionGroup.aliasSet.aliases.map(({languageId, ...rest}) => ({
            ...rest,
            language: languageId
        })) : [];

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

    const aliases = edition.aliasSet ?
        edition.aliasSet.aliases.map(({languageId, ...rest}) => ({
            ...rest,
            language: languageId
        })) : [];

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

    const aliases = work.aliasSet ?
        work.aliasSet.aliases.map(({languageId, ...rest}) => ({
            ...rest,
            language: languageId
        })) : [];

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

    const aliases = publisher.aliasSet ?
        publisher.aliasSet.aliases.map(({languageId, ...rest}) => ({
            ...rest,
            language: languageId
        })) : [];

• Read up
  Read up