bookbrainz/bookbrainz-site

View on GitHub
src/client/components/pages/parts/search-field.tsx

Summary

Maintainability
C
1 day
Test Coverage

Function render has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render() {
        const entityTypeSelect = Array.isArray(this.props.entityTypes) ? (
            <DropdownButton
                as={InputGroup.Append}
                id="entity-type-select"
Severity: Major
Found in src/client/components/pages/parts/search-field.tsx - About 2 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        handleChange = event => {
            if (!event.target.value.match(/^ +$/) && event.target.value !== this.state.query) {
                this.setState({query: event.target.value}, this.debouncedTriggerOnSearch);
            }
        };
    Severity: Major
    Found in src/client/components/pages/parts/search-field.tsx and 1 other location - About 2 hrs to fix
    src/client/components/pages/parts/admin-panel-search-field.tsx on lines 93..97

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 90.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            if (prevProps.type !== this.props.type) {
                // eslint-disable-next-line react/no-did-update-set-state
                this.setState({type: this.props.type});
            }
    Severity: Major
    Found in src/client/components/pages/parts/search-field.tsx and 2 other locations - About 45 mins to fix
    src/client/components/pages/parts/admin-panel-search-field.tsx on lines 74..77
    src/client/components/pages/parts/search-field.tsx on lines 83..86

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            if (prevProps.query !== this.props.query) {
                // eslint-disable-next-line react/no-did-update-set-state
                this.setState({query: this.props.query});
            }
    Severity: Major
    Found in src/client/components/pages/parts/search-field.tsx and 2 other locations - About 45 mins to fix
    src/client/components/pages/parts/admin-panel-search-field.tsx on lines 74..77
    src/client/components/pages/parts/search-field.tsx on lines 87..90

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                                    <Form.Control
                                        name="q"
                                        type="text"
                                        value={this.state.query}
                                        onChange={this.handleChange}
    Severity: Minor
    Found in src/client/components/pages/parts/search-field.tsx and 1 other location - About 35 mins to fix
    src/client/components/pages/parts/admin-panel-search-field.tsx on lines 111..116

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    const SearchButton = (
        <Button
            block
            type="submit"
            variant="success"
    Severity: Minor
    Found in src/client/components/pages/parts/search-field.tsx and 1 other location - About 35 mins to fix
    src/client/components/pages/parts/admin-panel-search-field.tsx on lines 30..38

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status