Sign upLogin

bookbrainz/bookbrainz-site

View on GitHub
Star
src/client/entity-editor/edition-section/edition-section-merge.tsx

Summary

Maintainability
B
6 hrs
Test Coverage

File edition-section-merge.tsx has 290 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright (C) 2019 Nicolas Pelletier
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
Severity: Minor
Found in src/client/entity-editor/edition-section/edition-section-merge.tsx - About 2 hrs to fix

    Function mapDispatchToProps has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function mapDispatchToProps(dispatch: Dispatch<Action>): DispatchProps {
    return {
        onAuthorCreditChange: (selectedAuthorCredit:AuthorCredit) => {
            dispatch(updateAuthorCredit(selectedAuthorCredit));
        },
    Severity: Minor
    Found in src/client/entity-editor/edition-section/edition-section-merge.tsx - About 1 hr to fix

      Function mapDispatchToProps has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      function mapDispatchToProps(dispatch: Dispatch<Action>): DispatchProps {
    return {
        onAuthorCreditChange: (selectedAuthorCredit:AuthorCredit) => {
            dispatch(updateAuthorCredit(selectedAuthorCredit));
        },
      Severity: Minor
      Found in src/client/entity-editor/edition-section/edition-section-merge.tsx - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  <MergeField
                components={{Option: LinkedEntitySelect, SingleValue: EntitySelect}}
                currentValue={publisherValue}
                label="Publisher"
                options={publisherOptions}
      Severity: Major
      Found in src/client/entity-editor/edition-section/edition-section-merge.tsx and 2 other locations - About 50 mins to fix
      src/client/entity-editor/edition-section/edition-section-merge.tsx on lines 231..237
      src/client/entity-editor/publisher-section/publisher-section-merge.tsx on lines 161..167

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  <MergeField
                components={{Option: LinkedEntitySelect, SingleValue: EntitySelect}}
                currentValue={editionGroupValue}
                label="Edition Group"
                options={editionGroupOptions}
      Severity: Major
      Found in src/client/entity-editor/edition-section/edition-section-merge.tsx and 2 other locations - About 50 mins to fix
      src/client/entity-editor/edition-section/edition-section-merge.tsx on lines 244..250
      src/client/entity-editor/publisher-section/publisher-section-merge.tsx on lines 161..167

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status