bookbrainz/bookbrainz-site

View on GitHub
src/client/entity-editor/submission-section/actions.ts

Summary

Maintainability
D
1 day
Test Coverage

Function transformFormData has 80 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function transformFormData(data:Record<string, any>):Record<string, any> {
    const newData = {};
    const nextId = 0;
    // add new series
    _.forEach(data.Series, (series, sid) => {
Severity: Major
Found in src/client/entity-editor/submission-section/actions.ts - About 3 hrs to fix

    Function submit has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function submit(
        submissionUrl: string,
        isUnifiedForm = false
    ): SubmitResult {
        return (dispatch, getState) => {
    Severity: Minor
    Found in src/client/entity-editor/submission-section/actions.ts - About 1 hr to fix

      Function submitSingleEntity has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function submitSingleEntity(submissionUrl:string, entityType:EntityTypeString, callback:(newEntity)=>void, initialState = {}):SubmitResult {
          return async (dispatch, getState) => {
              const rootState = getState();
              dispatch(setSubmitted(true));
              const JSONState = rootState.toJS();
      Severity: Minor
      Found in src/client/entity-editor/submission-section/actions.ts - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    if (response.body.alert) {
                        const alertParam = `?alert=${response.body.alert}`;
                        window.location.href = `${redirectUrl}${alertParam}`;
                    }
                    else {
        Severity: Major
        Found in src/client/entity-editor/submission-section/actions.ts and 1 other location - About 2 hrs to fix
        src/client/entity-editor/submission-section/actions.ts on lines 109..115

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 86.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    if (response.body.alert) {
                        const alertParam = `?alert=${response.body.alert}`;
                        window.location.href = `${redirectUrl}${alertParam}`;
                    }
                    else {
        Severity: Major
        Found in src/client/entity-editor/submission-section/actions.ts and 1 other location - About 2 hrs to fix
        src/client/entity-editor/submission-section/actions.ts on lines 220..226

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 86.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                catch (error) {
                    const message =
                                _.get(error, ['response', 'body', 'error'], null) ||
                                error.message;
                    dispatch(setSubmitted(false));
        Severity: Major
        Found in src/client/entity-editor/submission-section/actions.ts and 1 other location - About 1 hr to fix
        src/client/entity-editor/submission-section/actions.ts on lines 241..247

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                            (error: {message: string}) => {
                                const message =
                                _.get(error, ['response', 'body', 'error'], null) ||
                                error.message;
                                dispatch(setSubmitted(false));
        Severity: Major
        Found in src/client/entity-editor/submission-section/actions.ts and 1 other location - About 1 hr to fix
        src/client/entity-editor/submission-section/actions.ts on lines 295..301

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        export function debounceUpdateRevisionNote(value: string): Action {
            return {
                meta: {debounce: 'keystroke'},
                type: UPDATE_REVISION_NOTE,
                value
        Severity: Minor
        Found in src/client/entity-editor/submission-section/actions.ts and 1 other location - About 40 mins to fix
        src/client/entity-editor/annotation-section/actions.ts on lines 37..43

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status