Sign upLogin

bookbrainz/bookbrainz-site

View on GitHub
Star
src/client/unified-form/content-tab/content-tab.tsx

Summary

Maintainability
C
1 day
Test Coverage

File content-tab.tsx has 266 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import * as Bootstrap from 'react-bootstrap/';
import {ContentTabDispatchProps, ContentTabProps, ContentTabStateProps, State} from '../interface/type';
import {addBulkSeriesItems, addSeriesItem, removeAllSeriesItems, updateOrderType, updateSeriesType} from '../../entity-editor/series-section/actions';
import {addSeries, addWork, duplicateWork, removeSeries} from './action';
import {closeEntityModal, dumpEdition, loadEdition, openEntityModal} from '../action';
Severity: Minor
Found in src/client/unified-form/content-tab/content-tab.tsx - About 2 hrs to fix

    Function mapDispatchToProps has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    function mapDispatchToProps(dispatch, {submissionUrl}):ContentTabDispatchProps {
    const type = 'Work';
    return {
        bulkAddSeriesItems: (data) => dispatch(addBulkSeriesItems(data)),
        onAddSeriesItem: (data) => dispatch(addSeriesItem(data, data.rowID)),
    Severity: Minor
    Found in src/client/unified-form/content-tab/content-tab.tsx - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function ContentTab has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    export function ContentTab({works, onChange, onModalClose, onModalOpen, onSeriesChange, series,
     onAddSeriesItem, onSubmitWork, resetSeries, bulkAddSeriesItems, ...rest}:ContentTabProps) {
    const [isChecked, setIsChecked] = React.useState(true);
    const [copyToSeries, setCopyToSeries] = React.useState(false);
    const toggleCheck = React.useCallback(() => {
    Severity: Minor
    Found in src/client/unified-form/content-tab/content-tab.tsx - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function generateRel has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function generateRel(workEntity, seriesEntity, attributeSetId?, isAdded = false, isRemoved = false) {
    Severity: Minor
    Found in src/client/unified-form/content-tab/content-tab.tsx - About 35 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          const seriesWorkLabel = (

        <>
            <FormLabel className="font-weight-normal">
            Add Works to Series
      Severity: Major
      Found in src/client/unified-form/content-tab/content-tab.tsx and 1 other location - About 2 hrs to fix
      src/client/entity-editor/author-credit-editor/author-credit-section.tsx on lines 121..140

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 94.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          const checkLabel = (
        <>
            <FormLabel className="font-weight-normal">
            Copy Authors from Author Credit
                <OverlayTrigger
      Severity: Major
      Found in src/client/unified-form/content-tab/content-tab.tsx and 1 other location - About 2 hrs to fix
      src/client/unified-form/content-tab/work-row.tsx on lines 25..39

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 78.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      export function ContentTab({works, onChange, onModalClose, onModalOpen, onSeriesChange, series,
     onAddSeriesItem, onSubmitWork, resetSeries, bulkAddSeriesItems, ...rest}:ContentTabProps) {
    const [isChecked, setIsChecked] = React.useState(true);
    const [copyToSeries, setCopyToSeries] = React.useState(false);
    const toggleCheck = React.useCallback(() => {
      Severity: Major
      Found in src/client/unified-form/content-tab/content-tab.tsx and 1 other location - About 1 hr to fix
      src/client/entity-editor/author-credit-editor/author-credit-row.tsx on lines 82..159

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status