Sign upLogin

bookbrainz/bookbrainz-site

View on GitHub
Star
src/client/unified-form/cover-tab/action.ts

Summary

Maintainability
A
1 hr
Test Coverage

Similar blocks of code found in 8 locations. Consider refactoring.
Open

export function debouncedUpdateISBNValue(newValue: string): Action {
    return {
        meta: {debounce: 'keystroke'},
        payload: newValue,
        type: UPDATE_ISBN_VALUE
Severity: Major
Found in src/client/unified-form/cover-tab/action.ts and 7 other locations - About 50 mins to fix
src/client/entity-editor/author-section/actions.ts on lines 78..84
src/client/entity-editor/author-section/actions.ts on lines 108..114
src/client/entity-editor/name-section/actions.ts on lines 74..80
src/client/entity-editor/name-section/actions.ts on lines 90..96
src/client/entity-editor/name-section/actions.ts on lines 121..129
src/client/entity-editor/publisher-section/actions.ts on lines 79..85
src/client/entity-editor/publisher-section/actions.ts on lines 95..101

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export function addAuthor(value = null, rowId:string):Action {
    return {
        payload: {id: `a${nextAuthorId++}`, rowId, value},
        type: ADD_AUTHOR
    };
Severity: Minor
Found in src/client/unified-form/cover-tab/action.ts and 1 other location - About 30 mins to fix
src/client/entity-editor/identifier-editor/actions.ts on lines 148..157

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status