Sign upLogin

bookbrainz/bookbrainz-site

View on GitHub
Star
src/client/unified-form/helpers.ts

Summary

Maintainability
D
2 days
Test Coverage

Function crossSliceReducer has 118 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function crossSliceReducer(state:State, action:Action) {
    const {type} = action;
    let intermediateState = state;
    const activeEntityState = {
        aliasEditor: state.get('aliasEditor'),
Severity: Major
Found in src/client/unified-form/helpers.ts - About 4 hrs to fix

    File helpers.ts has 260 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import {ADD_AUTHOR, ADD_PUBLISHER} from './cover-tab/action';
import {Action, State} from './interface/type';
import {CLOSE_ENTITY_MODAL, DUMP_EDITION, LOAD_EDITION, OPEN_ENTITY_MODAL} from './action';
import {ISBNReducer, authorsReducer, autoISBNReducer, publishersReducer} from './cover-tab/reducer';
import {seriesReducer, worksReducer} from './content-tab/reducer';
    Severity: Minor
    Found in src/client/unified-form/helpers.ts - About 2 hrs to fix

      Function createRootReducer has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function createRootReducer() {
    return (state: Immutable.Map<string, any>, action) => {
        // first pass the state to our cross slice reducer to handle UF specific actions.
        const intermediateState = crossSliceReducer(state, action);
        return combineReducers({
      Severity: Minor
      Found in src/client/unified-form/helpers.ts - About 1 hr to fix

        Function crossSliceReducer has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

        function crossSliceReducer(state:State, action:Action) {
    const {type} = action;
    let intermediateState = state;
    const activeEntityState = {
        aliasEditor: state.get('aliasEditor'),
        Severity: Minor
        Found in src/client/unified-form/helpers.ts - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                return combineReducers({
            Authors: authorsReducer,
            EditionGroups: editionGroupsReducer,
            Editions: newEditionReducer,
            ISBN: ISBNReducer,
        Severity: Major
        Found in src/client/unified-form/helpers.ts and 1 other location - About 4 hrs to fix
        src/client/entity-editor/author-section/author-section.tsx on lines 137..161

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 116.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                            relationship.sourceEntity = {
                        bbid: relationship.source.bbid,
                        defaultAlias: {
                            name: relationship.source.name
                        },
        Severity: Major
        Found in src/client/unified-form/helpers.ts and 1 other location - About 1 hr to fix
        src/client/unified-form/helpers.ts on lines 200..206

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            switch (type) {
        case DUMP_EDITION:
            return state.set(payload.id, Immutable.fromJS(payload.value));
        case LOAD_EDITION:
            return Immutable.Map({});
        Severity: Major
        Found in src/client/unified-form/helpers.ts and 1 other location - About 1 hr to fix
        src/client/unified-form/detail-tab/reducer.ts on lines 6..13

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                            relationship.targetEntity = {
                        bbid: relationship.target.bbid,
                        defaultAlias: {
                            name: relationship.target.name
                        },
        Severity: Major
        Found in src/client/unified-form/helpers.ts and 1 other location - About 1 hr to fix
        src/client/unified-form/helpers.ts on lines 193..199

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status