Sign upLogin

bookbrainz/bookbrainz-site

View on GitHub
Star
src/server/helpers/entityRouteUtils.tsx

Summary

Maintainability
D
1 day
Test Coverage

File entityRouteUtils.tsx has 269 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright (C) 2017  Eshan Singh
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
Severity: Minor
Found in src/server/helpers/entityRouteUtils.tsx - About 2 hrs to fix

    Function validateUnifiedForm has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    function validateUnifiedForm(body:Record<string, any>):boolean {
    for (const entityKey in body) {
        if (Object.prototype.hasOwnProperty.call(body, entityKey)) {
            const entityForm = body[entityKey];
            const entityType = _.camelCase(entityForm.type);
    Severity: Minor
    Found in src/server/helpers/entityRouteUtils.tsx - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function addInitialRelationship has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function addInitialRelationship(props, relationshipTypeId, relationshipIndex, targetEntity) {
    // Prepend 'i' here to indicate initail relationship row identifier
    const rowId = `i${relationshipIndex || 0}`;
    const relationship = props.relationshipTypes.find(
        relationshipType => relationshipType.id === relationshipTypeId
    Severity: Minor
    Found in src/server/helpers/entityRouteUtils.tsx - About 1 hr to fix

      Function generateEntityProps has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          entityType: string,
    req: PassportRequest, res: $Response,
    additionalProps: any,
    initialStateCallback: (entity: any) => any = () => new Object()
      Severity: Minor
      Found in src/server/helpers/entityRouteUtils.tsx - About 35 mins to fix

        Function generateEntityProps has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        export function generateEntityProps(
    entityType: string,
    req: PassportRequest, res: $Response,
    additionalProps: any,
    initialStateCallback: (entity: any) => any = () => new Object()
        Severity: Minor
        Found in src/server/helpers/entityRouteUtils.tsx - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            const markup = ReactDOMServer.renderToString(
        <Layout {...propHelpers.extractLayoutProps(rest)}>
            <Provider store={store}>
                <EntityEditor
                    validate={getValidator(props.entityType)}
        Severity: Major
        Found in src/server/helpers/entityRouteUtils.tsx and 1 other location - About 3 hrs to fix
        src/server/helpers/entityRouteUtils.tsx on lines 204..215

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 104.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            const markup = ReactDOMServer.renderToString(
        <Layout {...propHelpers.extractLayoutProps(rest)}>
            <Provider store={store}>
                <EntityMerge
                    validate={getValidator(props.entityType)}
        Severity: Major
        Found in src/server/helpers/entityRouteUtils.tsx and 1 other location - About 3 hrs to fix
        src/server/helpers/entityRouteUtils.tsx on lines 169..180

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 104.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status