Sign upLogin

bookbrainz/bookbrainz-site

View on GitHub
Star
src/server/helpers/typeRouteUtils.ts

Summary

Maintainability
C
1 day
Test Coverage

Function relationshipTypeCreateOrEditHandler has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export async function relationshipTypeCreateOrEditHandler(req, res, next) {
    try {
        const {RelationshipType, RelationshipTypeAttributeType, bookshelf} = req.app.locals.orm;
        const trx = await bookshelf.transaction();
        let newRelationshipType;
Severity: Major
Found in src/server/helpers/typeRouteUtils.ts - About 2 hrs to fix

    Function identifierTypeCreateOrEditHandler has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export async function identifierTypeCreateOrEditHandler(req, res) {
    try {
        const {IdentifierType} = req.app.locals.orm;
        let newIdentifierType;
        let method;
    Severity: Minor
    Found in src/server/helpers/typeRouteUtils.ts - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if (!req.params.id) {
            newRelationshipType = await RelationshipType.forge();
            method = 'insert';
        }
        else {
      Severity: Major
      Found in src/server/helpers/typeRouteUtils.ts and 1 other location - About 3 hrs to fix
      src/server/helpers/typeRouteUtils.ts on lines 123..132

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 101.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if (!req.params.id) {
            newIdentifierType = await IdentifierType.forge();
            method = 'insert';
        }
        else {
      Severity: Major
      Found in src/server/helpers/typeRouteUtils.ts and 1 other location - About 3 hrs to fix
      src/server/helpers/typeRouteUtils.ts on lines 44..53

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 101.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status