Sign upLogin

bookbrainz/bookbrainz-site

View on GitHub
Star
src/server/routes/editor.tsx

Summary

Maintainability
F
3 days
Test Coverage

File editor.tsx has 564 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright (C) 2015, 2020  Ben Ockmore
 *               2015-2016   Sean Burke
 *
 * This program is free software; you can redistribute it and/or modify
Severity: Major
Found in src/server/routes/editor.tsx - About 1 day to fix

    Function getProgress has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    async function getProgress(achievementId, editorId, orm) {
    const revisionist = [1, 2, 3];
    if (revisionist.includes(achievementId)) {
        const {Editor} = orm;
        const editor = await new Editor({id: editorId})
    Severity: Major
    Found in src/server/routes/editor.tsx - About 2 hrs to fix

      Function getEditorActivity has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export async function getEditorActivity(editorId, startDate, Revision, endDate = Date.now()) {
    if (!isValid(startDate)) {
        throw new Error('Start date is invalid');
    }
    if (!isValid(endDate)) {
      Severity: Minor
      Found in src/server/routes/editor.tsx - About 1 hr to fix

        Function getProgress has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

        async function getProgress(achievementId, editorId, orm) {
    const revisionist = [1, 2, 3];
    if (revisionist.includes(achievementId)) {
        const {Editor} = orm;
        const editor = await new Editor({id: editorId})
        Severity: Minor
        Found in src/server/routes/editor.tsx - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this function.
        Open

                return getTypeCreation(new PublisherRevision(), 'publisher_revision', editorId);
        Severity: Major
        Found in src/server/routes/editor.tsx - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return getEntityVisits(orm, editorId);
          Severity: Major
          Found in src/server/routes/editor.tsx - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return getTypeCreation(new SeriesRevision(), 'series_revision', editorId);
            Severity: Major
            Found in src/server/routes/editor.tsx - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return 0;
              Severity: Major
              Found in src/server/routes/editor.tsx - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return getConsecutiveDaysWithEdits(orm, editorId, 29);
                Severity: Major
                Found in src/server/routes/editor.tsx - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return getTypeCreation(new WorkRevision(), 'work_revision', editorId);
                  Severity: Major
                  Found in src/server/routes/editor.tsx - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                            return out.rowCount;
                    Severity: Major
                    Found in src/server/routes/editor.tsx - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                              return getConsecutiveDaysWithEdits(orm, editorId, 6);
                      Severity: Major
                      Found in src/server/routes/editor.tsx - About 30 mins to fix

                        Function getEditorActivity has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                        export async function getEditorActivity(editorId, startDate, Revision, endDate = Date.now()) {
    if (!isValid(startDate)) {
        throw new Error('Start date is invalid');
    }
    if (!isValid(endDate)) {
                        Severity: Minor
                        Found in src/server/routes/editor.tsx - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                const markup = ReactDOMServer.renderToString(
            <Layout {...propHelpers.extractLayoutProps(props)}>
                <EditorContainer
                    {...propHelpers.extractEditorProps(props)}
                >
                        Severity: Major
                        Found in src/server/routes/editor.tsx and 1 other location - About 2 hrs to fix
                        src/server/routes/editor.tsx on lines 389..399

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 80.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                const markup = ReactDOMServer.renderToString(
            <Layout {...propHelpers.extractLayoutProps(props)}>
                <EditorContainer
                    {...propHelpers.extractEditorProps(props)}
                >
                        Severity: Major
                        Found in src/server/routes/editor.tsx and 1 other location - About 2 hrs to fix
                        src/server/routes/editor.tsx on lines 671..681

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 80.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                            const achievementColPromise = new AchievementUnlock()
        .where('editor_id', userId)
        .where('profile_rank', '<=', '3')
        .query((qb) => qb.limit(3))
        .orderBy('profile_rank', 'ASC')
                        Severity: Major
                        Found in src/server/routes/editor.tsx and 1 other location - About 1 hr to fix
                        src/server/routes/editor.tsx on lines 312..320

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 73.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                                const achievementCol = await new AchievementUnlock()
            .where('editor_id', userId)
            .where('profile_rank', '<=', '3')
            .query((qb) => qb.limit(3))
            .orderBy('profile_rank', 'ASC')
                        Severity: Major
                        Found in src/server/routes/editor.tsx and 1 other location - About 1 hr to fix
                        src/server/routes/editor.tsx on lines 533..541

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 73.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                res.send(target({
            markup,
            page: 'revisions',
            props: escapeProps(props),
            script: '/js/editor/editor.js',
                        Severity: Major
                        Found in src/server/routes/editor.tsx and 1 other location - About 1 hr to fix
                        src/server/routes/editor.tsx on lines 683..689

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 62.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                res.send(target({
            markup,
            page: 'collections',
            props: escapeProps(props),
            script: '/js/editor/editor.js',
                        Severity: Major
                        Found in src/server/routes/editor.tsx and 1 other location - About 1 hr to fix
                        src/server/routes/editor.tsx on lines 401..407

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 62.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status