Sign upLogin

bookbrainz/bookbrainz-site

View on GitHub
Star
src/server/routes/entity/edition-group.ts

Summary

Maintainability
F
6 days
Test Coverage

Function editionGroupToFormState has 84 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function editionGroupToFormState(editionGroup) {
    /** The front-end expects a language id rather than the language object. */
    const aliases = editionGroup.aliasSet ?
        editionGroup.aliasSet.aliases.map(({languageId, ...rest}) => ({
            ...rest,
Severity: Major
Found in src/server/routes/entity/edition-group.ts - About 3 hrs to fix

    File edition-group.ts has 291 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 * Copyright (C) 2015       Ben Ockmore
 *               2015-2016  Sean Burke
 *
 * This program is free software; you can redistribute it and/or modify
    Severity: Minor
    Found in src/server/routes/entity/edition-group.ts - About 3 hrs to fix

      Function transformNewForm has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function transformNewForm(data) {
    const aliases = entityRoutes.constructAliases(
        data.aliasEditor, data.nameSection
    );
      Severity: Minor
      Found in src/server/routes/entity/edition-group.ts - About 1 hr to fix

        Function editionGroupToFormState has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

        export function editionGroupToFormState(editionGroup) {
    /** The front-end expects a language id rather than the language object. */
    const aliases = editionGroup.aliasSet ?
        editionGroup.aliasSet.aliases.map(({languageId, ...rest}) => ({
            ...rest,
        Severity: Minor
        Found in src/server/routes/entity/edition-group.ts - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        router.get(
    '/create', auth.isAuthenticated, auth.isAuthorized(ENTITY_EDITOR), middleware.loadIdentifierTypes,
    middleware.loadLanguages, middleware.loadEditionGroupTypes,
    middleware.loadRelationshipTypes,
     async (req, res) => {
        Severity: Major
        Found in src/server/routes/entity/edition-group.ts and 1 other location - About 1 day to fix
        src/server/routes/entity/publisher.ts on lines 99..135

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 314.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

        router.get(
    '/:bbid/edit', auth.isAuthenticated, auth.isAuthorized(ENTITY_EDITOR), middleware.loadIdentifierTypes,
    middleware.loadEditionGroupTypes, middleware.loadLanguages,
     middleware.loadEntityRelationships, middleware.loadRelationshipTypes,
    (req, res) => {
        Severity: Major
        Found in src/server/routes/entity/edition-group.ts and 3 other locations - About 4 hrs to fix
        src/server/routes/entity/publisher.ts on lines 336..352
        src/server/routes/entity/series.ts on lines 328..344
        src/server/routes/entity/work.ts on lines 348..364

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 133.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

            editionGroup.relationships.forEach((relationship) => (
        relationshipSection.relationships[`n${relationship.id}`] = {
            attributeSetId: relationship.attributeSetId,
            attributes: relationship.attributeSet ? relationship.attributeSet.relationshipAttributes : [],
            relationshipType: relationship.type,
        Severity: Major
        Found in src/server/routes/entity/edition-group.ts and 4 other locations - About 4 hrs to fix
        src/server/routes/entity/author.ts on lines 306..315
        src/server/routes/entity/edition.ts on lines 513..522
        src/server/routes/entity/publisher.ts on lines 309..318
        src/server/routes/entity/work.ts on lines 321..330

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 123.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            if (!authorCreditEnable) {
        authorCredit = null;
    }
    else if (!_.isNil(data.authorCredit)) {
        // When merging entities, we use a separate reducer "authorCredit"
        Severity: Major
        Found in src/server/routes/entity/edition-group.ts and 1 other location - About 3 hrs to fix
        src/server/routes/entity/edition.ts on lines 90..99

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 96.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

        router.post(
    '/:bbid/delete/handler', auth.isAuthenticatedForHandler, auth.isAuthorized(ENTITY_EDITOR),
    (req, res) => {
        const {orm} = req.app.locals;
        const {EditionGroupHeader, EditionGroupRevision} = orm;
        Severity: Major
        Found in src/server/routes/entity/edition-group.ts and 5 other locations - About 2 hrs to fix
        src/server/routes/entity/author.ts on lines 226..235
        src/server/routes/entity/edition.ts on lines 397..406
        src/server/routes/entity/publisher.ts on lines 232..241
        src/server/routes/entity/series.ts on lines 221..230
        src/server/routes/entity/work.ts on lines 245..254

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 87.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

        router.get('/:bbid/delete', auth.isAuthenticated, auth.isAuthorized(ENTITY_EDITOR), (req, res, next) => {
    if (!res.locals.entity.dataId) {
        return next(new ConflictError('This entity has already been deleted'));
    }
    _setEditionGroupTitle(res);
        Severity: Major
        Found in src/server/routes/entity/edition-group.ts and 5 other locations - About 2 hrs to fix
        src/server/routes/entity/author.ts on lines 218..224
        src/server/routes/entity/edition.ts on lines 389..395
        src/server/routes/entity/publisher.ts on lines 224..230
        src/server/routes/entity/series.ts on lines 213..219
        src/server/routes/entity/work.ts on lines 237..243

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 85.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 12 locations. Consider refactoring.
        Open

        router.get('/:bbid/revisions', (req, res, next) => {
    const {EditionGroupRevision} = req.app.locals.orm;
    _setEditionGroupTitle(res);
    entityRoutes.displayRevisions(req, res, next, EditionGroupRevision);
});
        Severity: Major
        Found in src/server/routes/entity/edition-group.ts and 11 other locations - About 1 hr to fix
        src/server/routes/entity/author.ts on lines 237..241
        src/server/routes/entity/author.ts on lines 243..247
        src/server/routes/entity/edition-group.ts on lines 237..241
        src/server/routes/entity/edition.ts on lines 376..380
        src/server/routes/entity/edition.ts on lines 382..386
        src/server/routes/entity/publisher.ts on lines 243..247
        src/server/routes/entity/publisher.ts on lines 249..253
        src/server/routes/entity/series.ts on lines 232..236
        src/server/routes/entity/series.ts on lines 238..242
        src/server/routes/entity/work.ts on lines 256..260
        src/server/routes/entity/work.ts on lines 262..266

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 66.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 12 locations. Consider refactoring.
        Open

        router.get('/:bbid/revisions/revisions', (req, res, next) => {
    const {EditionGroupRevision} = req.app.locals.orm;
    _setEditionGroupTitle(res);
    entityRoutes.updateDisplayedRevisions(req, res, next, EditionGroupRevision);
});
        Severity: Major
        Found in src/server/routes/entity/edition-group.ts and 11 other locations - About 1 hr to fix
        src/server/routes/entity/author.ts on lines 237..241
        src/server/routes/entity/author.ts on lines 243..247
        src/server/routes/entity/edition-group.ts on lines 231..235
        src/server/routes/entity/edition.ts on lines 376..380
        src/server/routes/entity/edition.ts on lines 382..386
        src/server/routes/entity/publisher.ts on lines 243..247
        src/server/routes/entity/publisher.ts on lines 249..253
        src/server/routes/entity/series.ts on lines 232..236
        src/server/routes/entity/series.ts on lines 238..242
        src/server/routes/entity/work.ts on lines 256..260
        src/server/routes/entity/work.ts on lines 262..266

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 66.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            const credits = editionGroup.authorCredit ? editionGroup.authorCredit.names.map(
        ({author, ...rest}) => ({
            author: utils.entityToOption(author),
            ...rest
        })
        Severity: Major
        Found in src/server/routes/entity/edition-group.ts and 1 other location - About 1 hr to fix
        src/server/routes/entity/edition.ts on lines 436..441

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 64.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

            const identifiers = editionGroup.identifierSet ?
        editionGroup.identifierSet.identifiers.map(({type, ...rest}) => ({
            type: type.id,
            ...rest
        })) : [];
        Severity: Major
        Found in src/server/routes/entity/edition-group.ts and 5 other locations - About 1 hr to fix
        src/server/routes/entity/author.ts on lines 277..281
        src/server/routes/entity/edition.ts on lines 457..461
        src/server/routes/entity/publisher.ts on lines 283..287
        src/server/routes/entity/series.ts on lines 270..274
        src/server/routes/entity/work.ts on lines 295..299

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 60.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

        function _setEditionGroupTitle(res) {
    res.locals.title = utils.createEntityPageTitle(
        res.locals.entity,
        'EditionGroup',
        utils.template`Edition Group “${'name'}”`
        Severity: Major
        Found in src/server/routes/entity/edition-group.ts and 5 other locations - About 1 hr to fix
        src/server/routes/entity/author.ts on lines 205..211
        src/server/routes/entity/edition.ts on lines 362..368
        src/server/routes/entity/publisher.ts on lines 190..196
        src/server/routes/entity/series.ts on lines 199..205
        src/server/routes/entity/work.ts on lines 224..230

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 59.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

            const aliases = editionGroup.aliasSet ?
        editionGroup.aliasSet.aliases.map(({languageId, ...rest}) => ({
            ...rest,
            language: languageId
        })) : [];
        Severity: Major
        Found in src/server/routes/entity/edition-group.ts and 4 other locations - About 1 hr to fix
        src/server/routes/entity/author.ts on lines 252..256
        src/server/routes/entity/edition.ts on lines 411..415
        src/server/routes/entity/publisher.ts on lines 258..262
        src/server/routes/entity/work.ts on lines 270..274

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 58.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if (_.isEmpty(authorCreditEditor) && editionGroup.creditSection) {
        authorCreditEditor.n0 = {
            author: null,
            joinPhrase: '',
            name: ''
        Severity: Minor
        Found in src/server/routes/entity/edition-group.ts and 1 other location - About 45 mins to fix
        src/server/routes/entity/edition.ts on lines 450..456

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status