Sign upLogin

bookbrainz/bookbrainz-site

View on GitHub
Star
src/server/routes/merge.ts

Summary

Maintainability
D
2 days
Test Coverage

Function entitiesToFormState has 111 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function entitiesToFormState(entities: any[]) {
    const [targetEntity, ...otherEntities] = entities;
    const aliases: any[] = entities.reduce((returnValue, entity) => {
        if (Array.isArray(_.get(entity, 'aliasSet.aliases'))) {
            return returnValue.concat(
Severity: Major
Found in src/server/routes/merge.ts - About 4 hrs to fix

    File merge.ts has 331 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 * Copyright (C) 2019  Nicolas Pelletier
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
    Severity: Minor
    Found in src/server/routes/merge.ts - About 3 hrs to fix

      Function entitiesToFormState has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

      function entitiesToFormState(entities: any[]) {
    const [targetEntity, ...otherEntities] = entities;
    const aliases: any[] = entities.reduce((returnValue, entity) => {
        if (Array.isArray(_.get(entity, 'aliasSet.aliases'))) {
            return returnValue.concat(
      Severity: Minor
      Found in src/server/routes/merge.ts - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function loadEntityRelationships has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      async function loadEntityRelationships(entity, orm, transacting): Promise<any> {
    async function getEntityWithAlias(relEntity) {
        const redirectBbid = await orm.func.entity.recursivelyGetRedirectBBID(orm, relEntity.bbid, null);
        const model = commonUtils.getEntityModelByType(orm, relEntity.type);
        return model.forge({bbid: redirectBbid})
      Severity: Minor
      Found in src/server/routes/merge.ts - About 1 hr to fix

        Avoid too many return statements within this function.
        Open

                    return next(error);
        Severity: Major
        Found in src/server/routes/merge.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return next(conflictError);
          Severity: Major
          Found in src/server/routes/merge.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return res.send(targetTemplate({
            markup,
            props: escapeProps(props),
            script: '/js/entity-editor.js',
            title: `Merge ${mergingFetchedEntities.length} ${_.startCase(entityType)}s`
            Severity: Major
            Found in src/server/routes/merge.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return res.redirect(req.headers.referer);
              Severity: Major
              Found in src/server/routes/merge.ts - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      const relationships = await Promise.all(entity.relationships.map(async (relationship) => {
            const [relationshipSource, relationshipTarget] = await Promise.all([
                getEntityWithAlias(relationship.source),
                getEntityWithAlias(relationship.target)
            ]);
                Severity: Major
                Found in src/server/routes/merge.ts and 1 other location - About 3 hrs to fix
                src/server/helpers/middleware.ts on lines 164..170

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 97.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    const relationships = entities.reduce((returnValue, entity) => {
        if (entity.relationships) {
            return returnValue.concat(entity.relationships);
        }
        return returnValue;
                Severity: Minor
                Found in src/server/routes/merge.ts and 1 other location - About 55 mins to fix
                src/server/routes/merge.ts on lines 153..158

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 53.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    const authorCredits = entities.reduce((returnValue, entity) => {
        if (entity.authorCredit) {
            return returnValue.concat(entity.authorCredit);
        }
        return returnValue;
                Severity: Minor
                Found in src/server/routes/merge.ts and 1 other location - About 55 mins to fix
                src/server/routes/merge.ts on lines 114..119

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 53.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status