Sign upLogin

boopathi/react-svg-loader

View on GitHub
Star

Showing 8 of 8 total issues

Function default has 111 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function(babel: BabelCore) {
  const t = babel.types;
  const restElement = t.restElement ? t.restElement : t.restProperty;

  const createClass = (className: string) =>
Severity: Major
Found in packages/babel-plugin-react-svg/src/index.ts - About 4 hrs to fix

    Function default has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

    export default function(babel: BabelCore) {
  const t = babel.types;
  const restElement = t.restElement ? t.restElement : t.restProperty;

  const createClass = (className: string) =>
    Severity: Minor
    Found in packages/babel-plugin-react-svg/src/index.ts - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function validateAndFix has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

    export function validateAndFix(opts: any = {}) {
  if (!isPlainObject(opts))
    throw new Error("Expected options.svgo to be Object.");

  let cleanOpts = cloneDeep(opts);
    Severity: Minor
    Found in packages/react-svg-core/src/svgo.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function JSXAttribute has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        JSXAttribute(path: any) {
      const name = path.get("name");
      const value = path.get("value");

      if (name.isJSXNamespacedName()) {
    Severity: Minor
    Found in packages/babel-plugin-react-svg/src/index.ts - About 1 hr to fix

      Function validateAndFix has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function validateAndFix(opts: any = {}) {
  if (!isPlainObject(opts))
    throw new Error("Expected options.svgo to be Object.");

  let cleanOpts = cloneDeep(opts);
      Severity: Minor
      Found in packages/react-svg-core/src/svgo.ts - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          Promise.resolve(String(content))
    .then(optimize(loaderOpts.svgo))
    .then(transform({ jsx: loaderOpts.jsx }))
    .then((result: any) => cb(null, result.code))
        Severity: Major
        Found in packages/react-svg-loader/src/loader.ts and 1 other location - About 1 hr to fix
        packages/rollup-plugin-react-svg/src/index.ts on lines 23..26

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              return Promise.resolve(String(contents))
        .then(optimize(options.svgo))
        .then(transform({ jsx: options.jsx }))
        .then((result: any) => result.code);
        Severity: Major
        Found in packages/rollup-plugin-react-svg/src/index.ts and 1 other location - About 1 hr to fix
        packages/react-svg-loader/src/loader.ts on lines 9..12

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function getSVGOOpts has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

        function getSVGOOpts(argv) {
  let svgoOpts: any = {};

  if (typeof argv.svgo === "string") {
    svgoOpts = handlePath(argv.svgo);
        Severity: Minor
        Found in packages/react-svg-loader-cli/src/cli.ts - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language