Sign upLogin

borgbackup/borg

View on GitHub
Star

Showing 611 of 611 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

elif is_darwin:  # pragma: darwin only
    from .darwin import API_VERSION as OS_API_VERSION
    from .darwin import listxattr, getxattr, setxattr
    from .darwin import acl_get, acl_set
    from .base import set_flags, get_flags
Severity: Major
Found in src/borg/platform/__init__.py and 2 other locations - About 55 mins to fix
src/borg/platform/__init__.py on lines 13..22
src/borg/platform/__init__.py on lines 23..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 37.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        assert idx.size() == 1024 + num_buckets * (32 + 3 * 4)
Severity: Minor
Found in src/borg/testsuite/hashindex_test.py and 1 other location - About 55 mins to fix
src/borg/testsuite/hashindex_test.py on lines 328..328

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 37.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        assert cpt.size() == 1024 + num_entries * (32 + 3 * 4)
Severity: Minor
Found in src/borg/testsuite/hashindex_test.py and 1 other location - About 55 mins to fix
src/borg/testsuite/hashindex_test.py on lines 327..327

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 37.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function cache_if_remote has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

def cache_if_remote(repository, *, decrypted_cache=False, pack=None, unpack=None, transform=None, force_cache=False):
Severity: Major
Found in src/borg/remote.py - About 50 mins to fix

    Function __init__ has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(self, format, repository, manifest, key, *, iec=False):
    Severity: Major
    Found in src/borg/helpers/parseformat.py - About 50 mins to fix

      Function __init__ has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __init__(
      Severity: Major
      Found in src/borg/helpers/msgpack.py - About 50 mins to fix

        Function text_validator has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def text_validator(*, name, max_length, min_length=0, invalid_ctrl_chars="\0", invalid_chars="", no_blanks=False):
        Severity: Major
        Found in src/borg/helpers/parseformat.py - About 50 mins to fix

          Function setup_logging has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def setup_logging(
          Severity: Major
          Found in src/borg/logger.py - About 50 mins to fix

            Function sizeof_fmt has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def sizeof_fmt(num, suffix="B", units=None, power=None, sep="", precision=2, sign=False):
            Severity: Major
            Found in src/borg/helpers/parseformat.py - About 50 mins to fix

              Function process_dev has 7 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def process_dev(self, *, path, parent_fd, name, st, dev_type, strip_prefix):
              Severity: Major
              Found in src/borg/archive.py - About 50 mins to fix

                Function _read has 7 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def _read(self, fd, header, segment, offset, acceptable_tags, read_data=True):
                Severity: Major
                Found in src/borg/legacyrepository.py - About 50 mins to fix

                  Function get_item_uid_gid has 7 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  def get_item_uid_gid(item, *, numeric, uid_forced=None, gid_forced=None, uid_default=0, gid_default=0):
                  Severity: Major
                  Found in src/borg/archive.py - About 50 mins to fix

                    Function OsOpen has 7 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    def OsOpen(*, flags, path=None, parent_fd=None, name=None, noatime=False, op="open"):
                    Severity: Major
                    Found in src/borg/archive.py - About 50 mins to fix

                      Function process_pipe has 7 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          def process_pipe(self, *, path, cache, fd, mode, user=None, group=None):
                      Severity: Major
                      Found in src/borg/archive.py - About 50 mins to fix

                        Function cache_if_remote has 7 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                        def cache_if_remote(repository, *, decrypted_cache=False, pack=None, unpack=None, transform=None, force_cache=False):
                        Severity: Major
                        Found in src/borg/legacyremote.py - About 50 mins to fix

                          Function read has 7 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              def read(self, segment, offset, id, *, read_data=True, expected_size=None):
                          Severity: Major
                          Found in src/borg/legacyrepository.py - About 50 mins to fix

                            Function with_repository has 7 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                            def with_repository(
                            Severity: Major
                            Found in src/borg/archiver/_common.py - About 50 mins to fix

                              Function compat_check has 7 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                              def compat_check(*, create, manifest, key, cache, compatibility, decorator_name):
                              Severity: Major
                              Found in src/borg/archiver/_common.py - About 50 mins to fix

                                Function find_chunks has 7 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                def find_chunks(repository, repo_objs, cache, stats, ctype, clevel, olevel):
                                Severity: Major
                                Found in src/borg/archiver/repo_compress_cmd.py - About 50 mins to fix

                                  Function do_transfer has 7 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                      def do_transfer(self, args, *, repository, manifest, cache, other_repository=None, other_manifest=None):
                                  Severity: Major
                                  Found in src/borg/archiver/transfer_cmd.py - About 50 mins to fix
                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language