Sign upLogin

borgbackup/borg

View on GitHub
Star

Showing 611 of 611 total issues

Identical blocks of code found in 3 locations. Consider refactoring.
Open

    key_file = archiver.keys_path + "/" + os.listdir(archiver.keys_path)[0]
Severity: Minor
Found in src/borg/testsuite/archiver/key_cmds_test.py and 2 other locations - About 35 mins to fix
src/borg/testsuite/archiver/key_cmds_test.py on lines 232..232
src/borg/testsuite/archiver/key_cmds_test.py on lines 261..261

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            if strip_components:
                item.path = os.sep.join(orig_path.split(os.sep)[strip_components:])
Severity: Minor
Found in src/borg/archiver/tar_cmds.py and 1 other location - About 35 mins to fix
src/borg/archiver/extract_cmd.py on lines 61..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            if strip_components:
                item.path = os.sep.join(orig_path.split(os.sep)[strip_components:])
Severity: Minor
Found in src/borg/archiver/extract_cmd.py and 1 other location - About 35 mins to fix
src/borg/archiver/tar_cmds.py on lines 231..232

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    with changedir("output"):
        with patch.object(xattr, "setxattr", patched_setxattr_EACCES):
            cmd(archiver, "extract", "test", exit_code=EXIT_WARNING)
Severity: Minor
Found in src/borg/testsuite/archiver/extract_cmd_test.py and 1 other location - About 35 mins to fix
src/borg/testsuite/archiver/extract_cmd_test.py on lines 646..648

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

    key_file = archiver.keys_path + "/" + os.listdir(archiver.keys_path)[0]
Severity: Minor
Found in src/borg/testsuite/archiver/key_cmds_test.py and 2 other locations - About 35 mins to fix
src/borg/testsuite/archiver/key_cmds_test.py on lines 81..81
src/borg/testsuite/archiver/key_cmds_test.py on lines 261..261

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function assert_no_manifest_replay has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def assert_no_manifest_replay(self, manifest, key):
        try:
            with open(self.manifest_ts_file) as fd:
                timestamp = fd.read()
            logger.debug("security: read manifest timestamp %r", timestamp)
Severity: Minor
Found in src/borg/cache.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

                return dict(name=name, id=values["id"], time=values["time"])
Severity: Major
Found in src/borg/manifest.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return super().default(o)
    Severity: Major
    Found in src/borg/helpers/parseformat.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return default
      Severity: Major
      Found in src/borg/helpers/yes_no.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return ""
        Severity: Major
        Found in src/borg/helpers/parseformat.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return 1
          Severity: Major
          Found in scripts/make.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return False
            Severity: Major
            Found in src/borg/helpers/parseformat.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return ec1
              Severity: Major
              Found in src/borg/helpers/__init__.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                                return False
                Severity: Major
                Found in src/borg/legacyrepository.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return ec2
                  Severity: Major
                  Found in src/borg/helpers/__init__.py - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                            return
                    Severity: Major
                    Found in src/borg/archive.py - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                              return
                      Severity: Major
                      Found in src/borg/archive.py - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                            return EXIT_SUCCESS
                        Severity: Major
                        Found in src/borg/helpers/__init__.py - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                              return any(key_serialized.startswith(pattern) for pattern in keys_serialized)
                          Severity: Major
                          Found in src/borg/archive.py - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                    return seen_commit
                            Severity: Major
                            Found in src/borg/legacyrepository.py - About 30 mins to fix
                              Severity
                              Category
                              Status
                              Source
                              Language