Sign upLogin

borgbackup/borg

View on GitHub
Star
src/borg/archiver/key_cmds.py

Summary

Maintainability
B
6 hrs
Test Coverage

Function do_change_location has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    def do_change_location(self, args, repository, manifest, cache):
        """Change repository key location"""
        key = manifest.key
        if not hasattr(key, "change_passphrase"):
            raise CommandError("This repository is not encrypted, cannot change the key location.")
Severity: Minor
Found in src/borg/archiver/key_cmds.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File key_cmds.py has 251 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import argparse
import functools
import os

from ..constants import *  # NOQA
Severity: Minor
Found in src/borg/archiver/key_cmds.py - About 2 hrs to fix

    Function do_key_import has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def do_key_import(self, args, repository):
        """Import the repository key from backup"""
        manager = KeyManager(repository)
        if args.paper:
            if args.path:
    Severity: Minor
    Found in src/borg/archiver/key_cmds.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function do_key_export has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def do_key_export(self, args, repository):
        """Export the repository key for backup"""
        manager = KeyManager(repository)
        manager.load_keyblob()
        if args.paper:
    Severity: Minor
    Found in src/borg/archiver/key_cmds.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status