Sign upLogin

bowheart/zedux

View on GitHub
Star

Showing 14 of 16 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  const onEnter = (action: Reactable, subscriber: EffectsSubscriber) => {
    const actionType = extractActionType('withMachineHooks.onEnter')(action)

    if (!enterSubscribers[actionType]) {
      enterSubscribers[actionType] = new Map<EffectsSubscriber, true>()
Severity: Major
Found in src/api/applyMachineHooks.ts and 1 other location - About 3 hrs to fix
src/api/applyMachineHooks.ts on lines 52..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  const onLeave = (action: Reactable, subscriber: EffectsSubscriber) => {
    const actionType = extractActionType('withMachineHooks.onLeave')(action)

    if (!leaveSubscribers[actionType]) {
      leaveSubscribers[actionType] = new Map<EffectsSubscriber, true>()
Severity: Major
Found in src/api/applyMachineHooks.ts and 1 other location - About 3 hrs to fix
src/api/applyMachineHooks.ts on lines 40..50

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File createStore.ts has 288 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { hierarchyDescriptorToDiffTree } from '../hierarchy/create'
import { mergeDiffTrees, mergeStateTrees } from '../hierarchy/merge'
import { delegate, propagateChange } from '../hierarchy/traverse'
import {
  Action,
Severity: Minor
Found in src/api/createStore.ts - About 2 hrs to fix

    Function createMachine has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    export const createMachine = <State extends string = string>(
  initialState?: Reactable
) => {
  const method = `createMachine()`
    Severity: Minor
    Found in src/api/createMachine.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function createMachine has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export const createMachine = <State extends string = string>(
  initialState?: Reactable
) => {
  const method = `createMachine()`
    Severity: Minor
    Found in src/api/createMachine.ts - About 1 hr to fix

      Function applyMachineHooks has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export const applyMachineHooks = <T = any>(
  store: Store<T>,
  getMachineState: (state: T) => string
) => {
  const enterSubscribers: SubscribersHash = {}
      Severity: Minor
      Found in src/api/applyMachineHooks.ts - About 1 hr to fix

        Function Home has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function Home() {
  const { siteConfig } = useDocusaurusContext()

  return (
    <Layout
        Severity: Minor
        Found in docs/src/pages/index.tsx - About 1 hr to fix

          Function subscribe has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            const subscribe = (subscriber: Subscriber<State>) => {
    const subscriberObj =
      typeof subscriber === 'function' ? { next: subscriber } : subscriber

    if (subscriberObj.next) {
          Severity: Minor
          Found in src/api/createStore.ts - About 1 hr to fix

            Function registerChildStore has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              const registerChildStore = (childStorePath: string[], childStore: Store) => {
    const effectsSubscriber: EffectsSubscriber<State> = ({
      action,
      effects,
      error,
            Severity: Minor
            Found in src/api/createStore.ts - About 1 hr to fix

              Function applyMachineHooks has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

              export const applyMachineHooks = <T = any>(
  store: Store<T>,
  getMachineState: (state: T) => string
) => {
  const enterSubscribers: SubscribersHash = {}
              Severity: Minor
              Found in src/api/applyMachineHooks.ts - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              export interface ActionMeta<Payload = any, Data = any> {
  metaType: string
  metaData?: Data
  payload: ActionChain<Payload>
}
              Severity: Minor
              Found in src/types.ts and 1 other location - About 40 mins to fix
              src/types.ts on lines 54..58

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 49.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              export interface EffectMeta<Payload = any, Data = any> {
  metaType: string
  metaData?: Data
  payload: EffectChain<Payload>
}
              Severity: Minor
              Found in src/types.ts and 1 other location - About 40 mins to fix
              src/types.ts on lines 13..17

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 49.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Parsing error: parser.parse is not a function
              Open

              module.exports = {
              Severity: Minor
              Found in docs/sidebars.js by eslint

              For more information visit Source: http://eslint.org/docs/rules/

              Parsing error: parser.parse is not a function
              Open

              module.exports = {
              Severity: Minor
              Found in docs/docusaurus.config.js by eslint

              For more information visit Source: http://eslint.org/docs/rules/

              Severity
              Category
              Status
              Source
              Language