Sign upLogin

bpaulin/SetupEzContentTypeBundle

View on GitHub
Star

Showing 25 of 25 total issues

Method testCommandWithDryRunOrForce has 81 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testCommandWithDryRunOrForce( $param, $called, $display)
    {
        $tree = array(
            "group1" => array(
                "type1" => array(
Severity: Major
Found in src/Tests/Command/SetupEzContentTypeCommandTest.php - About 3 hrs to fix

    Method getTreeProvider has 80 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getTreeProvider()
    {
        return array(
            array(
                array(
    Severity: Major
    Found in src/Tests/DependencyInjection/BpaulinSetupEzContentTypeExtensionTest.php - About 3 hrs to fix

      Method processGroupProvider has 74 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function processGroupProvider()
    {
        return array(
            array(
                array(
      Severity: Major
      Found in src/Tests/DependencyInjection/BpaulinSetupEzContentTypeExtensionTest.php - About 2 hrs to fix

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            public function afterFieldDraftLoading(ImportEvent $event)
    {
        if ( $this->output->isVerbose() )
        {
            $markMatches = array(
        Severity: Major
        Found in src/Command/SetupEzContentTypeCommand.php and 3 other locations - About 2 hrs to fix
        src/Command/SetupEzContentTypeCommand.php on lines 206..222
        src/Command/SetupEzContentTypeCommand.php on lines 224..240
        src/Command/SetupEzContentTypeCommand.php on lines 242..258

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 135.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            public function afterGroupLoading(ImportEvent $event)
    {
        if ( $this->output->isVerbose() )
        {
            $markMatches = array(
        Severity: Major
        Found in src/Command/SetupEzContentTypeCommand.php and 3 other locations - About 2 hrs to fix
        src/Command/SetupEzContentTypeCommand.php on lines 224..240
        src/Command/SetupEzContentTypeCommand.php on lines 242..258
        src/Command/SetupEzContentTypeCommand.php on lines 260..276

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 135.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            public function afterTypeDraftLoading(ImportEvent $event)
    {
        if ( $this->output->isVeryVerbose() )
        {
            $markMatches = array(
        Severity: Major
        Found in src/Command/SetupEzContentTypeCommand.php and 3 other locations - About 2 hrs to fix
        src/Command/SetupEzContentTypeCommand.php on lines 206..222
        src/Command/SetupEzContentTypeCommand.php on lines 224..240
        src/Command/SetupEzContentTypeCommand.php on lines 260..276

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 135.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            public function afterTypeLoading(ImportEvent $event)
    {
        if ( $this->output->isVerbose() )
        {
            $markMatches = array(
        Severity: Major
        Found in src/Command/SetupEzContentTypeCommand.php and 3 other locations - About 2 hrs to fix
        src/Command/SetupEzContentTypeCommand.php on lines 206..222
        src/Command/SetupEzContentTypeCommand.php on lines 242..258
        src/Command/SetupEzContentTypeCommand.php on lines 260..276

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 135.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        File BpaulinSetupEzContentTypeExtensionTest.php has 277 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
/**
 * Created by PhpStorm.
 * User: bpaulin
 * Date: 12/06/15
        Severity: Minor
        Found in src/Tests/DependencyInjection/BpaulinSetupEzContentTypeExtensionTest.php - About 2 hrs to fix

          File Import.php has 272 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
/**
 * Import Service
 */
namespace Bpaulin\SetupEzContentTypeBundle\Service;
          Severity: Minor
          Found in src/Service/Import.php - About 2 hrs to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public function testAfterGroupLoadingNotVerbose()
    {
        $command = new SetupEzContentTypeCommand();
        $event = new ImportEvent();
        $event->setObjectName( 'groupname' )->setStatus( Events::STATUS_CREATED );
            Severity: Major
            Found in src/Tests/Command/SetupEzContentTypeCommandTest.php and 1 other location - About 2 hrs to fix
            src/Tests/Command/SetupEzContentTypeCommandTest.php on lines 187..201

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 129.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public function testAfterGroupLoadingVerbose()
    {
        $command = new SetupEzContentTypeCommand();
        $event = new ImportEvent();
        $event->setObjectName( 'groupname' )->setStatus( Events::STATUS_CREATED );
            Severity: Major
            Found in src/Tests/Command/SetupEzContentTypeCommandTest.php and 1 other location - About 2 hrs to fix
            src/Tests/Command/SetupEzContentTypeCommandTest.php on lines 203..217

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 129.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function checkTree has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function checkTree( $groups )
    {
        foreach ( $groups as $group )
        {
            foreach ( $group as $typeName => $type )
            Severity: Minor
            Found in src/DependencyInjection/BpaulinSetupEzContentTypeExtension.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method getConfigTreeBuilder has 48 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function getConfigTreeBuilder()
    {
        $treeBuilder = new TreeBuilder();
        $rootNode = $treeBuilder->root( 'bpaulin_setup_ez_content_type' );
            Severity: Minor
            Found in src/DependencyInjection/Configuration.php - About 1 hr to fix

              Function execute has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function execute(InputInterface $input, OutputInterface $output)
    {
        /*
         * store properties
         */
              Severity: Minor
              Found in src/Command/SetupEzContentTypeCommand.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method runImport has 45 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected function runImport()
    {
        $tree = $this->getContainer()->getParameter( 'bpaulin_setup_ez_content_type.groups' );
        $importService = $this->getContainer()->get( 'bpaulin.setupezcontenttype.import' );
        $importService->setForce( $this->input->getOption( 'force' ) );
              Severity: Minor
              Found in src/Command/SetupEzContentTypeCommand.php - About 1 hr to fix

                Function buildExtendsTree has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                Open

                    protected function buildExtendsTree( $types )
    {
        $extends = array();
        foreach ( $types as $typeKey => $type )
        {
                Severity: Minor
                Found in src/DependencyInjection/BpaulinSetupEzContentTypeExtension.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method hydrateField has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function hydrateField($fieldDraft, $fieldStructure, $fieldData)
    {
        $fields = array(
            'position',
            'isTranslatable',
                Severity: Minor
                Found in src/Service/Import.php - About 1 hr to fix

                  Method mergeTypeProvider has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function mergeTypeProvider()
    {
        return array(
            array(
                array(
                  Severity: Minor
                  Found in src/Tests/DependencyInjection/BpaulinSetupEzContentTypeExtensionTest.php - About 1 hr to fix

                    Method testForceGetNewGroup has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function testForceGetNewGroup()
    {
        $this->contentTypeService->expects( $this->once() )
            ->method( 'loadContentTypeGroupByIdentifier' )
            ->will(
                    Severity: Minor
                    Found in src/Tests/Service/ImportTest.php - About 1 hr to fix

                      Function runImport has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                      Open

                          protected function runImport()
    {
        $tree = $this->getContainer()->getParameter( 'bpaulin_setup_ez_content_type.groups' );
        $importService = $this->getContainer()->get( 'bpaulin.setupezcontenttype.import' );
        $importService->setForce( $this->input->getOption( 'force' ) );
                      Severity: Minor
                      Found in src/Command/SetupEzContentTypeCommand.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language