Sign upLogin

bpicode/fritzctl

View on GitHub
Star
manifest/applier_aha_http_test.go

Summary

Maintainability
F
3 days
Test Coverage

Function TestApplyViaAhaLargeSystemWithErrors has 59 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func TestApplyViaAhaLargeSystemWithErrors(t *testing.T) {
    applier := NewApplier(&fritzAlwaysError{})
    err := applier.Apply(
        &Plan{
            Switches: []Switch{
Severity: Minor
Found in manifest/applier_aha_http_test.go - About 1 hr to fix

    Function TestApplyViaAhaLargeSystem has 59 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func TestApplyViaAhaLargeSystem(t *testing.T) {
    applier := NewApplier(&fritzAlwaysSuccess{})
    err := applier.Apply(
        &Plan{
            Switches: []Switch{
    Severity: Minor
    Found in manifest/applier_aha_http_test.go - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func TestApplyViaAhaLargeSystem(t *testing.T) {
    applier := NewApplier(&fritzAlwaysSuccess{})
    err := applier.Apply(
        &Plan{
            Switches: []Switch{
      Severity: Major
      Found in manifest/applier_aha_http_test.go and 1 other location - About 1 day to fix
      manifest/applier_aha_http_test.go on lines 170..230

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 643.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func TestApplyViaAhaLargeSystemWithErrors(t *testing.T) {
    applier := NewApplier(&fritzAlwaysError{})
    err := applier.Apply(
        &Plan{
            Switches: []Switch{
      Severity: Major
      Found in manifest/applier_aha_http_test.go and 1 other location - About 1 day to fix
      manifest/applier_aha_http_test.go on lines 44..104

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 643.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

      func TestApplyViaAhaErrorByMalformedPlan(t *testing.T) {
    applier := NewApplier(&fritzAlwaysError{})
    err := applier.Apply(
        &Plan{
            Switches:    []Switch{{Name: "s", State: false}},
      Severity: Major
      Found in manifest/applier_aha_http_test.go and 3 other locations - About 1 hr to fix
      manifest/applier_aha_http_test.go on lines 29..41
      manifest/applier_aha_http_test.go on lines 125..137
      manifest/applier_aha_http_test.go on lines 140..152

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 163.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

      func TestApplyViaAhaErrorByThermostat(t *testing.T) {
    applier := NewApplier(&fritzAlwaysError{})
    err := applier.Apply(
        &Plan{
            Switches:    []Switch{{Name: "s", State: true}},
      Severity: Major
      Found in manifest/applier_aha_http_test.go and 3 other locations - About 1 hr to fix
      manifest/applier_aha_http_test.go on lines 29..41
      manifest/applier_aha_http_test.go on lines 140..152
      manifest/applier_aha_http_test.go on lines 155..167

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 163.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

      func TestApplyViaAha(t *testing.T) {
    applier := NewApplier(&fritzAlwaysSuccess{})
    err := applier.Apply(
        &Plan{
            Switches:    []Switch{{Name: "s", State: true}},
      Severity: Major
      Found in manifest/applier_aha_http_test.go and 3 other locations - About 1 hr to fix
      manifest/applier_aha_http_test.go on lines 125..137
      manifest/applier_aha_http_test.go on lines 140..152
      manifest/applier_aha_http_test.go on lines 155..167

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 163.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

      func TestApplyViaAhaErrorBySwitch(t *testing.T) {
    applier := NewApplier(&fritzAlwaysError{})
    err := applier.Apply(
        &Plan{
            Switches:    []Switch{{Name: "s", State: false}},
      Severity: Major
      Found in manifest/applier_aha_http_test.go and 3 other locations - About 1 hr to fix
      manifest/applier_aha_http_test.go on lines 29..41
      manifest/applier_aha_http_test.go on lines 125..137
      manifest/applier_aha_http_test.go on lines 155..167

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 163.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status