bpot/poseidon

View on GitHub
lib/poseidon/protocol/protocol_struct.rb

Summary

Maintainability
C
1 day
Test Coverage

Class ProtocolStruct has 28 methods (exceeds 20 allowed). Consider refactoring.
Open

    class ProtocolStruct < Struct
      class EncodingError < StandardError;end
      class DecodingError < StandardError;end

      def self.new(hash)
Severity: Minor
Found in lib/poseidon/protocol/protocol_struct.rb - About 3 hrs to fix

    Method read has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

          def read(buffer)
            if self.class.prepend_size?
              if !have_header?(buffer)
                @truncated = true
                return
    Severity: Minor
    Found in lib/poseidon/protocol/protocol_struct.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method objects_with_errors has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

          def objects_with_errors
            children = []
            each_pair do |member, value|
              case value
              when Array
    Severity: Minor
    Found in lib/poseidon/protocol/protocol_struct.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method read_member has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

          def read_member(buffer, member)
            case type = type_map[member]
            when Array
              if self.class.size_bound_array?(member)
                if @size
    Severity: Minor
    Found in lib/poseidon/protocol/protocol_struct.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method read has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def read(buffer)
            if self.class.prepend_size?
              if !have_header?(buffer)
                @truncated = true
                return
    Severity: Minor
    Found in lib/poseidon/protocol/protocol_struct.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status