Sign upLogin

bq/corbel-js

View on GitHub
Star

Showing 172 of 172 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        _buildUri: function(path,eventType) {
            var uri = '';
            var urlBase =  this.driver.config.getCurrentEndpoint(corbel.Evci.moduleName, this._buildPort(this.driver.config));

            uri = urlBase + path;
Severity: Major
Found in src/evci/eventBuilder.js and 2 other locations - About 3 hrs to fix
src/assets/assets-builder.js on lines 125..134
src/scheduler/schedulerBuilder.js on lines 56..65

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 99.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        get: function() {
            console.log('iamInterface.group.get');
            corbel.validate.value('id', this.id);
            return this.request({
                url: this._buildUriWithDomain(this.uri, this.id),
Severity: Major
Found in src/iam/groupsBuilder.js and 1 other location - About 3 hrs to fix
src/iam/groupsBuilder.js on lines 165..173

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 99.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

        _closeSessions: function() {
            console.log('iamInterface.user.close.sessions');
            corbel.validate.value('id', this.id);
            return this.request({
                url: this._buildUriWithDomain(this.uri, this.id) + '/session',
Severity: Major
Found in src/iam/usersBuilder.js and 5 other locations - About 3 hrs to fix
src/iam/usersBuilder.js on lines 125..132
src/iam/usersBuilder.js on lines 140..147
src/iam/usersBuilder.js on lines 155..162
src/iam/usersBuilder.js on lines 206..213
src/iam/usersBuilder.js on lines 301..308

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

        _getIdentities: function() {
            console.log('iamInterface.user.getIdentities');
            corbel.validate.value('id', this.id);
            return this.request({
                url: this._buildUriWithDomain(this.uri, this.id) + '/identity',
Severity: Major
Found in src/iam/usersBuilder.js and 5 other locations - About 3 hrs to fix
src/iam/usersBuilder.js on lines 125..132
src/iam/usersBuilder.js on lines 140..147
src/iam/usersBuilder.js on lines 155..162
src/iam/usersBuilder.js on lines 171..178
src/iam/usersBuilder.js on lines 301..308

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

        _signOut: function() {
            console.log('iamInterface.users.signOutMe');
            corbel.validate.value('id', this.id);
            return this.request({
                url: this._buildUriWithDomain(this.uri, this.id) + '/signout',
Severity: Major
Found in src/iam/usersBuilder.js and 5 other locations - About 3 hrs to fix
src/iam/usersBuilder.js on lines 140..147
src/iam/usersBuilder.js on lines 155..162
src/iam/usersBuilder.js on lines 171..178
src/iam/usersBuilder.js on lines 206..213
src/iam/usersBuilder.js on lines 301..308

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

        _getSession: function() {
            console.log('iamInterface.user.get.session');
            corbel.validate.value('id', this.id);
            return this.request({
                url: this._buildUriWithDomain(this.uri, this.id) + '/session',
Severity: Major
Found in src/iam/usersBuilder.js and 5 other locations - About 3 hrs to fix
src/iam/usersBuilder.js on lines 125..132
src/iam/usersBuilder.js on lines 140..147
src/iam/usersBuilder.js on lines 171..178
src/iam/usersBuilder.js on lines 206..213
src/iam/usersBuilder.js on lines 301..308

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

        _disconnect: function() {
            console.log('iamInterface.user.disconnect');
            corbel.validate.value('id', this.id);
            return this.request({
                url: this._buildUriWithDomain(this.uri, this.id) + '/disconnect',
Severity: Major
Found in src/iam/usersBuilder.js and 5 other locations - About 3 hrs to fix
src/iam/usersBuilder.js on lines 125..132
src/iam/usersBuilder.js on lines 155..162
src/iam/usersBuilder.js on lines 171..178
src/iam/usersBuilder.js on lines 206..213
src/iam/usersBuilder.js on lines 301..308

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

        _getProfile: function() {
            console.log('iamInterface.user.getProfile');
            corbel.validate.value('id', this.id);
            return this.request({
                url: this._buildUriWithDomain(this.uri, this.id) + '/profile',
Severity: Major
Found in src/iam/usersBuilder.js and 5 other locations - About 3 hrs to fix
src/iam/usersBuilder.js on lines 125..132
src/iam/usersBuilder.js on lines 140..147
src/iam/usersBuilder.js on lines 155..162
src/iam/usersBuilder.js on lines 171..178
src/iam/usersBuilder.js on lines 206..213

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    getAll: function (params, userId) {
      console.log('ecInterface.purchase.getAll');

      return this.request({
        url: this._buildUri(this.uri, null, null, userId),
Severity: Major
Found in src/ec/purchaseBuilder.js and 1 other location - About 3 hrs to fix
src/ec/paymentBuilder.js on lines 43..51

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 97.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    get: function (params, userId) {
      console.log('ecInterface.payment.get');

      return this.request({
        url: this._buildUri(this.uri, null, null, userId),
Severity: Major
Found in src/ec/paymentBuilder.js and 1 other location - About 3 hrs to fix
src/ec/purchaseBuilder.js on lines 62..70

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 97.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        update: function(data) {
            console.log('notificationsInterface.template.update', data);
            corbel.validate.value('id', this.id);
            return this.request({
                url: this.buildUri(this.uri, this.id),
Severity: Major
Found in src/notifications/notificationsTemplateBuilder.js and 1 other location - About 3 hrs to fix
src/scheduler/schedulerBuilder.js on lines 37..45

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 96.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        update: function(task) {
            console.log('schedulerInterface.task.update', task);
            corbel.validate.value('id', this.id);
            return this.request({
                url: this._buildUri(this.uri, this.id),
Severity: Major
Found in src/scheduler/schedulerBuilder.js and 1 other location - About 3 hrs to fix
src/notifications/notificationsTemplateBuilder.js on lines 64..72

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 96.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

        renewForMe: function() {
            console.log('borrowInterface.resource.renewForMe');
            corbel.validate.value('id', this.id);
            return this.request({
                url: this._buildUri(this.uri, this.id, 'renewal/me'),
Severity: Major
Found in src/borrow/borrowBuilder.js and 5 other locations - About 3 hrs to fix
src/borrow/borrowBuilder.js on lines 142..149
src/borrow/borrowBuilder.js on lines 178..185
src/borrow/borrowBuilder.js on lines 215..222
src/borrow/borrowBuilder.js on lines 289..296
src/borrow/borrowBuilder.js on lines 326..333

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

        applyForMe: function() {
            console.log('borrowInterface.resource.applyForMe');
            corbel.validate.value('id', this.id);
            return this.request({
                url: this._buildUri(this.uri, this.id, 'loan/me'),
Severity: Major
Found in src/borrow/borrowBuilder.js and 5 other locations - About 3 hrs to fix
src/borrow/borrowBuilder.js on lines 178..185
src/borrow/borrowBuilder.js on lines 215..222
src/borrow/borrowBuilder.js on lines 252..259
src/borrow/borrowBuilder.js on lines 289..296
src/borrow/borrowBuilder.js on lines 326..333

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

        returnMyLoan: function() {
            console.log('borrowInterface.resource.returnMyLoan');
            corbel.validate.value('id', this.id);
            return this.request({
                url: this._buildUri(this.uri, this.id, 'loan/me'),
Severity: Major
Found in src/borrow/borrowBuilder.js and 5 other locations - About 3 hrs to fix
src/borrow/borrowBuilder.js on lines 142..149
src/borrow/borrowBuilder.js on lines 178..185
src/borrow/borrowBuilder.js on lines 252..259
src/borrow/borrowBuilder.js on lines 289..296
src/borrow/borrowBuilder.js on lines 326..333

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

        cancelMyReservation: function() {
            console.log('borrowInterface.resource.cancelMyReservation');
            corbel.validate.value('id', this.id);
            return this.request({
                url: this._buildUri(this.uri, this.id, 'reservation/me'),
Severity: Major
Found in src/borrow/borrowBuilder.js and 5 other locations - About 3 hrs to fix
src/borrow/borrowBuilder.js on lines 142..149
src/borrow/borrowBuilder.js on lines 178..185
src/borrow/borrowBuilder.js on lines 215..222
src/borrow/borrowBuilder.js on lines 252..259
src/borrow/borrowBuilder.js on lines 289..296

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

        reserveForMe: function() {
            console.log('borrowInterface.resource.reserveForMe');
            corbel.validate.value('id', this.id);
            return this.request({
                url: this._buildUri(this.uri, this.id, 'reservation/me'),
Severity: Major
Found in src/borrow/borrowBuilder.js and 5 other locations - About 3 hrs to fix
src/borrow/borrowBuilder.js on lines 142..149
src/borrow/borrowBuilder.js on lines 178..185
src/borrow/borrowBuilder.js on lines 215..222
src/borrow/borrowBuilder.js on lines 252..259
src/borrow/borrowBuilder.js on lines 326..333

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

        getMyLent: function() {
            console.log('borrowInterface.resource.getMyLent');
            corbel.validate.value('id', this.id);
            return this.request({
                url: this._buildUri(this.uri, this.id, 'loan/me'),
Severity: Major
Found in src/borrow/borrowBuilder.js and 5 other locations - About 3 hrs to fix
src/borrow/borrowBuilder.js on lines 142..149
src/borrow/borrowBuilder.js on lines 215..222
src/borrow/borrowBuilder.js on lines 252..259
src/borrow/borrowBuilder.js on lines 289..296
src/borrow/borrowBuilder.js on lines 326..333

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    get: function () {
      console.log('ecInterface.order.get');

      corbel.validate.value('id', this.id);
      return this.request({
Severity: Major
Found in src/ec/orderBuilder.js and 5 other locations - About 2 hrs to fix
src/borrow/borrowBuilder.js on lines 60..67
src/borrow/borrowBuilder.js on lines 76..83
src/ec/orderBuilder.js on lines 89..97
src/ec/productBuilder.js on lines 175..183
src/notifications/notificationsTemplateBuilder.js on lines 79..86

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

        getFullHistory: function(params) {
            console.log('borrowInterface.resource.getFullHistory');
            return this.request({
                url: this._buildUri(this.uri, 'history/'),
                method: corbel.request.method.GET,
Severity: Major
Found in src/borrow/borrowBuilder.js and 4 other locations - About 2 hrs to fix
src/borrow/lenderBuilder.js on lines 108..115
src/borrow/lenderBuilder.js on lines 124..131
src/ec/paymentBuilder.js on lines 66..74
src/ec/paymentPlanBuilder.js on lines 141..149

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language