bragento/bragento-composer-installer

View on GitHub

Showing 24 of 24 total issues

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        PackageInterface $package,
        $deployAction,
        SplFileInfo $sourceDir,
        SplFileInfo $destDir,
        $deployStrategy = Factory::STRATEGY_SYMLINK
Severity: Minor
Found in src/Deploy/Operation/DeployPackage.php - About 35 mins to fix

Function removeDelegates has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    protected function removeDelegates()
    {
        if (is_array($this->getDeployedDelegatesMapping())) {
            /** @var Mapping\MapEntity $map */
            foreach ($this->getDeployedDelegatesMapping() as $map) {
Severity: Minor
Found in src/Deploy/Strategy/AbstractStrategy.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function moveFiles has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    protected function moveFiles($sourceRoot, $targetRoot, IOInterface $io)
    {
        foreach ($this->getFiles() as $item) {
            $source = $this->getFs()->joinFileUris($sourceRoot, $item);
            $target = $this->getFs()->joinFileUris($targetRoot, $item);
Severity: Minor
Found in src/Updater/Core.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parseMappings has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    protected function parseMappings()
    {
        $map = array();
        $file = $this->getModmanFileObject();

Severity: Minor
Found in src/Mapping/Modman.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language