brandon14/ebay-sdk-php

View on GitHub

Showing 3,709 of 3,709 total issues

LocationApi has 40 functions (exceeds 20 allowed). Consider refactoring.
Open

class LocationApi
{
    /**
     * @var ClientInterface
     */
Severity: Minor
Found in src/Sell/Inventory/V1/Api/LocationApi.php - About 5 hrs to fix

    Product has 40 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Product implements ModelInterface, \ArrayAccess, \JsonSerializable
    {
        public const DISCRIMINATOR = null;
    
        /**
    Severity: Minor
    Found in src/Sell/Inventory/V1/Model/Product.php - About 5 hrs to fix

      InventoryItemApi has 40 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class InventoryItemApi
      {
          /**
           * @var ClientInterface
           */
      Severity: Minor
      Found in src/Sell/Inventory/V1/Api/InventoryItemApi.php - About 5 hrs to fix

        Offer has 40 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class Offer implements ModelInterface, \ArrayAccess, \JsonSerializable
        {
            public const DISCRIMINATOR = null;
        
            /**
        Severity: Minor
        Found in src/Sell/Negotiation/V1/Model/Offer.php - About 5 hrs to fix

          File ShippingQuoteApi.php has 387 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
          
          /**
           * This file is part of the trollandtoad/ebay-sdk-php package.
           *
          Severity: Minor
          Found in src/Sell/Logistics/V1/Api/ShippingQuoteApi.php - About 5 hrs to fix

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

                public function createOrReplaceSalesTaxAsyncWithHttpInfo($country_code, $jurisdiction_id, $sales_tax_base)
                {
                    $returnType = '';
                    $request = $this->createOrReplaceSalesTaxRequest($country_code, $jurisdiction_id, $sales_tax_base);
            
            
            Severity: Major
            Found in src/Sell/Account/V1/Api/SalesTaxApi.php and 4 other locations - About 5 hrs to fix
            src/Sell/Account/V1/Api/CustomPolicyApi.php on lines 1030..1048
            src/Sell/Marketing/V1/Api/AdApi.php on lines 4248..4266
            src/Sell/Marketing/V1/Api/AdGroupApi.php on lines 1627..1645
            src/Sell/Marketing/V1/Api/KeywordApi.php on lines 1610..1628

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 189.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

                public function updateAdGroupAsyncWithHttpInfo($ad_group_id, $campaign_id, $update_ad_group_request)
                {
                    $returnType = '';
                    $request = $this->updateAdGroupRequest($ad_group_id, $campaign_id, $update_ad_group_request);
            
            
            Severity: Major
            Found in src/Sell/Marketing/V1/Api/AdGroupApi.php and 4 other locations - About 5 hrs to fix
            src/Sell/Account/V1/Api/CustomPolicyApi.php on lines 1030..1048
            src/Sell/Account/V1/Api/SalesTaxApi.php on lines 245..263
            src/Sell/Marketing/V1/Api/AdApi.php on lines 4248..4266
            src/Sell/Marketing/V1/Api/KeywordApi.php on lines 1610..1628

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 189.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

                public function updateBidAsyncWithHttpInfo($ad_id, $campaign_id, $update_bid_percentage_request)
                {
                    $returnType = '';
                    $request = $this->updateBidRequest($ad_id, $campaign_id, $update_bid_percentage_request);
            
            
            Severity: Major
            Found in src/Sell/Marketing/V1/Api/AdApi.php and 4 other locations - About 5 hrs to fix
            src/Sell/Account/V1/Api/CustomPolicyApi.php on lines 1030..1048
            src/Sell/Account/V1/Api/SalesTaxApi.php on lines 245..263
            src/Sell/Marketing/V1/Api/AdGroupApi.php on lines 1627..1645
            src/Sell/Marketing/V1/Api/KeywordApi.php on lines 1610..1628

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 189.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

                public function updateCustomPolicyAsyncWithHttpInfo($custom_policy_id, $x_ebay_c_marketplace_id, $custom_policy_request)
                {
                    $returnType = '';
                    $request = $this->updateCustomPolicyRequest($custom_policy_id, $x_ebay_c_marketplace_id, $custom_policy_request);
            
            
            Severity: Major
            Found in src/Sell/Account/V1/Api/CustomPolicyApi.php and 4 other locations - About 5 hrs to fix
            src/Sell/Account/V1/Api/SalesTaxApi.php on lines 245..263
            src/Sell/Marketing/V1/Api/AdApi.php on lines 4248..4266
            src/Sell/Marketing/V1/Api/AdGroupApi.php on lines 1627..1645
            src/Sell/Marketing/V1/Api/KeywordApi.php on lines 1610..1628

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 189.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

                public function updateKeywordAsyncWithHttpInfo($campaign_id, $keyword_id, $update_keyword_request)
                {
                    $returnType = '';
                    $request = $this->updateKeywordRequest($campaign_id, $keyword_id, $update_keyword_request);
            
            
            Severity: Major
            Found in src/Sell/Marketing/V1/Api/KeywordApi.php and 4 other locations - About 5 hrs to fix
            src/Sell/Account/V1/Api/CustomPolicyApi.php on lines 1030..1048
            src/Sell/Account/V1/Api/SalesTaxApi.php on lines 245..263
            src/Sell/Marketing/V1/Api/AdApi.php on lines 4248..4266
            src/Sell/Marketing/V1/Api/AdGroupApi.php on lines 1627..1645

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 189.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            File SellerStandardsProfileApi.php has 382 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php
            
            /**
             * This file is part of the trollandtoad/ebay-sdk-php package.
             *
            Severity: Minor
            Found in src/Sell/Analytics/V1/Api/SellerStandardsProfileApi.php - About 5 hrs to fix

              Function getItemFeedRequest has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getItemFeedRequest($accept, $x_ebay_c_marketplace_id, $range, $feed_scope, $category_id, $date = null)
                  {
                      // Verify the required parameter 'accept' is set.
                      if ($accept === null || (\is_array($accept) && count($accept) === 0)) {
                          throw new \InvalidArgumentException('Missing the required parameter $accept when calling getItemFeed');
              Severity: Minor
              Found in src/Buy/FeedBeta/V1/Api/ItemApi.php - About 5 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getItemPriorityFeedRequest has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getItemPriorityFeedRequest($accept, $x_ebay_c_marketplace_id, $range, $category_id, $date)
                  {
                      // Verify the required parameter 'accept' is set.
                      if ($accept === null || (\is_array($accept) && count($accept) === 0)) {
                          throw new \InvalidArgumentException('Missing the required parameter $accept when calling getItemPriorityFeed');
              Severity: Minor
              Found in src/Buy/FeedBeta/V1/Api/ItemPriorityApi.php - About 5 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getItemSnapshotFeedRequest has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getItemSnapshotFeedRequest($accept, $x_ebay_c_marketplace_id, $range, $category_id, $snapshot_date)
                  {
                      // Verify the required parameter 'accept' is set.
                      if ($accept === null || (\is_array($accept) && count($accept) === 0)) {
                          throw new \InvalidArgumentException('Missing the required parameter $accept when calling getItemSnapshotFeed');
              Severity: Minor
              Found in src/Buy/FeedBeta/V1/Api/ItemSnapshotApi.php - About 5 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              File EventItem.php has 378 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              <?php
              
              /**
               * This file is part of the trollandtoad/ebay-sdk-php package.
               *
              Severity: Minor
              Found in src/Buy/Deal/V1/Model/EventItem.php - About 5 hrs to fix

                File Transaction.php has 378 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                <?php
                
                /**
                 * This file is part of the trollandtoad/ebay-sdk-php package.
                 *
                Severity: Minor
                Found in src/Sell/Finances/V1/Model/Transaction.php - About 5 hrs to fix

                  File AdReportMetadataApi.php has 378 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  <?php
                  
                  /**
                   * This file is part of the trollandtoad/ebay-sdk-php package.
                   *
                  Severity: Minor
                  Found in src/Sell/Marketing/V1/Api/AdReportMetadataApi.php - About 5 hrs to fix

                    File PaymentDispute.php has 378 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    <?php
                    
                    /**
                     * This file is part of the trollandtoad/ebay-sdk-php package.
                     *
                    Severity: Minor
                    Found in src/Sell/Fulfillment/V1/Model/PaymentDispute.php - About 5 hrs to fix

                      SellerLegalInfo has 38 functions (exceeds 20 allowed). Consider refactoring.
                      Open

                      class SellerLegalInfo implements ModelInterface, \ArrayAccess, \JsonSerializable
                      {
                          public const DISCRIMINATOR = null;
                      
                          /**
                      Severity: Minor
                      Found in src/Buy/Browse/V1/Model/SellerLegalInfo.php - About 5 hrs to fix

                        FileMetadata has 38 functions (exceeds 20 allowed). Consider refactoring.
                        Open

                        class FileMetadata implements ModelInterface, \ArrayAccess, \JsonSerializable
                        {
                            public const DISCRIMINATOR = null;
                        
                            /**
                        Severity: Minor
                        Found in src/Buy/Feed/V1/Model/FileMetadata.php - About 5 hrs to fix
                          Severity
                          Category
                          Status
                          Source
                          Language