File ItemApi.php
has 930 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* This file is part of the trollandtoad/ebay-sdk-php package.
*
Function checkCompatibilityRequest
has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring. Open
public function checkCompatibilityRequest($item_id, $x_ebay_c_marketplace_id, $compatibility_payload = null)
{
// Verify the required parameter 'item_id' is set.
if ($item_id === null || (\is_array($item_id) && count($item_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $item_id when calling checkCompatibility');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
ItemApi
has 30 functions (exceeds 20 allowed). Consider refactoring. Open
class ItemApi
{
/**
* @var ClientInterface
*/
Method getItemByLegacyIdRequest
has 88 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getItemByLegacyIdRequest($legacy_item_id, $fieldgroups = null, $legacy_variation_id = null, $legacy_variation_sku = null)
{
// Verify the required parameter 'legacy_item_id' is set.
if ($legacy_item_id === null || (\is_array($legacy_item_id) && count($legacy_item_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $legacy_item_id when calling getItemByLegacyId');
Method checkCompatibilityRequest
has 79 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function checkCompatibilityRequest($item_id, $x_ebay_c_marketplace_id, $compatibility_payload = null)
{
// Verify the required parameter 'item_id' is set.
if ($item_id === null || (\is_array($item_id) && count($item_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $item_id when calling checkCompatibility');
Method getItemRequest
has 74 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getItemRequest($item_id, $fieldgroups = null)
{
// Verify the required parameter 'item_id' is set.
if ($item_id === null || (\is_array($item_id) && count($item_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $item_id when calling getItem');
Function getItemRequest
has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring. Open
public function getItemRequest($item_id, $fieldgroups = null)
{
// Verify the required parameter 'item_id' is set.
if ($item_id === null || (\is_array($item_id) && count($item_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $item_id when calling getItem');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getItemsRequest
has 71 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getItemsRequest($item_ids = null, $item_group_ids = null)
{
$resourcePath = '/item/';
$formParams = [];
$queryParams = [];
Function getItemByLegacyIdRequest
has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring. Open
public function getItemByLegacyIdRequest($legacy_item_id, $fieldgroups = null, $legacy_variation_id = null, $legacy_variation_sku = null)
{
// Verify the required parameter 'legacy_item_id' is set.
if ($legacy_item_id === null || (\is_array($legacy_item_id) && count($legacy_item_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $legacy_item_id when calling getItemByLegacyId');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getItemsByItemGroupRequest
has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring. Open
public function getItemsByItemGroupRequest($item_group_id)
{
// Verify the required parameter 'item_group_id' is set.
if ($item_group_id === null || (\is_array($item_group_id) && count($item_group_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $item_group_id when calling getItemsByItemGroup');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getItemsByItemGroupRequest
has 67 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getItemsByItemGroupRequest($item_group_id)
{
// Verify the required parameter 'item_group_id' is set.
if ($item_group_id === null || (\is_array($item_group_id) && count($item_group_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $item_group_id when calling getItemsByItemGroup');
Function getItemsRequest
has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
public function getItemsRequest($item_ids = null, $item_group_ids = null)
{
$resourcePath = '/item/';
$formParams = [];
$queryParams = [];
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method checkCompatibilityWithHttpInfo
has 53 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function checkCompatibilityWithHttpInfo($item_id, $x_ebay_c_marketplace_id, $compatibility_payload = null)
{
$request = $this->checkCompatibilityRequest($item_id, $x_ebay_c_marketplace_id, $compatibility_payload);
try {
Method getItemByLegacyIdWithHttpInfo
has 53 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getItemByLegacyIdWithHttpInfo($legacy_item_id, $fieldgroups = null, $legacy_variation_id = null, $legacy_variation_sku = null)
{
$request = $this->getItemByLegacyIdRequest($legacy_item_id, $fieldgroups, $legacy_variation_id, $legacy_variation_sku);
try {
Method getItemWithHttpInfo
has 53 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getItemWithHttpInfo($item_id, $fieldgroups = null)
{
$request = $this->getItemRequest($item_id, $fieldgroups);
try {
Method getItemsWithHttpInfo
has 53 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getItemsWithHttpInfo($item_ids = null, $item_group_ids = null)
{
$request = $this->getItemsRequest($item_ids, $item_group_ids);
try {
Method getItemsByItemGroupWithHttpInfo
has 53 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getItemsByItemGroupWithHttpInfo($item_group_id)
{
$request = $this->getItemsByItemGroupRequest($item_group_id);
try {
Function getItemsByItemGroupWithHttpInfo
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
public function getItemsByItemGroupWithHttpInfo($item_group_id)
{
$request = $this->getItemsByItemGroupRequest($item_group_id);
try {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getItemsWithHttpInfo
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
public function getItemsWithHttpInfo($item_ids = null, $item_group_ids = null)
{
$request = $this->getItemsRequest($item_ids, $item_group_ids);
try {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function checkCompatibilityWithHttpInfo
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
public function checkCompatibilityWithHttpInfo($item_id, $x_ebay_c_marketplace_id, $compatibility_payload = null)
{
$request = $this->checkCompatibilityRequest($item_id, $x_ebay_c_marketplace_id, $compatibility_payload);
try {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getItemByLegacyIdWithHttpInfo
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
public function getItemByLegacyIdWithHttpInfo($legacy_item_id, $fieldgroups = null, $legacy_variation_id = null, $legacy_variation_sku = null)
{
$request = $this->getItemByLegacyIdRequest($legacy_item_id, $fieldgroups, $legacy_variation_id, $legacy_variation_sku);
try {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getItemWithHttpInfo
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
public function getItemWithHttpInfo($item_id, $fieldgroups = null)
{
$request = $this->getItemRequest($item_id, $fieldgroups);
try {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Similar blocks of code found in 7 locations. Consider refactoring. Open
public function getItemRequest($item_id, $fieldgroups = null)
{
// Verify the required parameter 'item_id' is set.
if ($item_id === null || (\is_array($item_id) && count($item_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $item_id when calling getItem');
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 567.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 3 locations. Consider refactoring. Open
public function getItemByLegacyIdWithHttpInfo($legacy_item_id, $fieldgroups = null, $legacy_variation_id = null, $legacy_variation_sku = null)
{
$request = $this->getItemByLegacyIdRequest($legacy_item_id, $fieldgroups, $legacy_variation_id, $legacy_variation_sku);
try {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 556.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 8 locations. Consider refactoring. Open
public function checkCompatibilityWithHttpInfo($item_id, $x_ebay_c_marketplace_id, $compatibility_payload = null)
{
$request = $this->checkCompatibilityRequest($item_id, $x_ebay_c_marketplace_id, $compatibility_payload);
try {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 539.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 3 locations. Consider refactoring. Open
public function getItemByLegacyIdAsyncWithHttpInfo($legacy_item_id, $fieldgroups = null, $legacy_variation_id = null, $legacy_variation_sku = null)
{
$returnType = '\TNT\Ebay\Buy\Browse\V1\Model\Item';
$request = $this->getItemByLegacyIdRequest($legacy_item_id, $fieldgroups, $legacy_variation_id, $legacy_variation_sku);
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 260.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 9 locations. Consider refactoring. Open
public function checkCompatibilityAsyncWithHttpInfo($item_id, $x_ebay_c_marketplace_id, $compatibility_payload = null)
{
$returnType = '\TNT\Ebay\Buy\Browse\V1\Model\CompatibilityResponse';
$request = $this->checkCompatibilityRequest($item_id, $x_ebay_c_marketplace_id, $compatibility_payload);
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 243.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76