brandon14/ebay-sdk-php

View on GitHub
src/Buy/Browse/V1/Api/ItemSummaryApi.php

Summary

Maintainability
F
4 days
Test Coverage

Method searchRequest has 148 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function searchRequest($aspect_filter = null, $auto_correct = null, $category_ids = null, $charity_ids = null, $compatibility_filter = null, $epid = null, $fieldgroups = null, $filter = null, $gtin = null, $limit = null, $offset = null, $q = null, $sort = null)
    {
        $resourcePath = '/item_summary/search';
        $formParams = [];
        $queryParams = [];
Severity: Major
Found in src/Buy/Browse/V1/Api/ItemSummaryApi.php - About 5 hrs to fix

    File ItemSummaryApi.php has 303 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    /**
     * This file is part of the trollandtoad/ebay-sdk-php package.
     *
    Severity: Minor
    Found in src/Buy/Browse/V1/Api/ItemSummaryApi.php - About 3 hrs to fix

      Function searchRequest has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

          public function searchRequest($aspect_filter = null, $auto_correct = null, $category_ids = null, $charity_ids = null, $compatibility_filter = null, $epid = null, $fieldgroups = null, $filter = null, $gtin = null, $limit = null, $offset = null, $q = null, $sort = null)
          {
              $resourcePath = '/item_summary/search';
              $formParams = [];
              $queryParams = [];
      Severity: Minor
      Found in src/Buy/Browse/V1/Api/ItemSummaryApi.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method searchWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function searchWithHttpInfo($aspect_filter = null, $auto_correct = null, $category_ids = null, $charity_ids = null, $compatibility_filter = null, $epid = null, $fieldgroups = null, $filter = null, $gtin = null, $limit = null, $offset = null, $q = null, $sort = null)
          {
              $request = $this->searchRequest($aspect_filter, $auto_correct, $category_ids, $charity_ids, $compatibility_filter, $epid, $fieldgroups, $filter, $gtin, $limit, $offset, $q, $sort);
      
              try {
      Severity: Major
      Found in src/Buy/Browse/V1/Api/ItemSummaryApi.php - About 2 hrs to fix

        Method searchWithHttpInfo has 13 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function searchWithHttpInfo($aspect_filter = null, $auto_correct = null, $category_ids = null, $charity_ids = null, $compatibility_filter = null, $epid = null, $fieldgroups = null, $filter = null, $gtin = null, $limit = null, $offset = null, $q = null, $sort = null)
        Severity: Major
        Found in src/Buy/Browse/V1/Api/ItemSummaryApi.php - About 1 hr to fix

          Method searchAsync has 13 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function searchAsync($aspect_filter = null, $auto_correct = null, $category_ids = null, $charity_ids = null, $compatibility_filter = null, $epid = null, $fieldgroups = null, $filter = null, $gtin = null, $limit = null, $offset = null, $q = null, $sort = null)
          Severity: Major
          Found in src/Buy/Browse/V1/Api/ItemSummaryApi.php - About 1 hr to fix

            Method searchRequest has 13 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function searchRequest($aspect_filter = null, $auto_correct = null, $category_ids = null, $charity_ids = null, $compatibility_filter = null, $epid = null, $fieldgroups = null, $filter = null, $gtin = null, $limit = null, $offset = null, $q = null, $sort = null)
            Severity: Major
            Found in src/Buy/Browse/V1/Api/ItemSummaryApi.php - About 1 hr to fix

              Method search has 13 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function search($aspect_filter = null, $auto_correct = null, $category_ids = null, $charity_ids = null, $compatibility_filter = null, $epid = null, $fieldgroups = null, $filter = null, $gtin = null, $limit = null, $offset = null, $q = null, $sort = null)
              Severity: Major
              Found in src/Buy/Browse/V1/Api/ItemSummaryApi.php - About 1 hr to fix

                Method searchAsyncWithHttpInfo has 13 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public function searchAsyncWithHttpInfo($aspect_filter = null, $auto_correct = null, $category_ids = null, $charity_ids = null, $compatibility_filter = null, $epid = null, $fieldgroups = null, $filter = null, $gtin = null, $limit = null, $offset = null, $q = null, $sort = null)
                Severity: Major
                Found in src/Buy/Browse/V1/Api/ItemSummaryApi.php - About 1 hr to fix

                  Function searchWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function searchWithHttpInfo($aspect_filter = null, $auto_correct = null, $category_ids = null, $charity_ids = null, $compatibility_filter = null, $epid = null, $fieldgroups = null, $filter = null, $gtin = null, $limit = null, $offset = null, $q = null, $sort = null)
                      {
                          $request = $this->searchRequest($aspect_filter, $auto_correct, $category_ids, $charity_ids, $compatibility_filter, $epid, $fieldgroups, $filter, $gtin, $limit, $offset, $q, $sort);
                  
                          try {
                  Severity: Minor
                  Found in src/Buy/Browse/V1/Api/ItemSummaryApi.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Identical blocks of code found in 5 locations. Consider refactoring.
                  Open

                      public function searchAsyncWithHttpInfo($aspect_filter = null, $auto_correct = null, $category_ids = null, $charity_ids = null, $compatibility_filter = null, $epid = null, $fieldgroups = null, $filter = null, $gtin = null, $limit = null, $offset = null, $q = null, $sort = null)
                      {
                          $returnType = '\TNT\Ebay\Buy\Browse\V1\Model\SearchPagedCollection';
                          $request = $this->searchRequest($aspect_filter, $auto_correct, $category_ids, $charity_ids, $compatibility_filter, $epid, $fieldgroups, $filter, $gtin, $limit, $offset, $q, $sort);
                  
                  
                  Severity: Major
                  Found in src/Buy/Browse/V1/Api/ItemSummaryApi.php and 4 other locations - About 1 hr to fix
                  src/Buy/Browse/V1/Api/ItemSummaryApi.php on lines 174..179
                  src/Buy/Browse/V1/Api/ItemSummaryApi.php on lines 203..268
                  src/Buy/Browse/V1/Api/ItemSummaryApi.php on lines 291..299
                  src/Buy/Browse/V1/Api/ItemSummaryApi.php on lines 373..551

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 118.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 5 locations. Consider refactoring.
                  Open

                      public function searchAsync($aspect_filter = null, $auto_correct = null, $category_ids = null, $charity_ids = null, $compatibility_filter = null, $epid = null, $fieldgroups = null, $filter = null, $gtin = null, $limit = null, $offset = null, $q = null, $sort = null)
                      {
                          return $this->searchAsyncWithHttpInfo($aspect_filter, $auto_correct, $category_ids, $charity_ids, $compatibility_filter, $epid, $fieldgroups, $filter, $gtin, $limit, $offset, $q, $sort)
                              ->then(
                                  function ($response) {
                  Severity: Major
                  Found in src/Buy/Browse/V1/Api/ItemSummaryApi.php and 4 other locations - About 1 hr to fix
                  src/Buy/Browse/V1/Api/ItemSummaryApi.php on lines 174..179
                  src/Buy/Browse/V1/Api/ItemSummaryApi.php on lines 203..268
                  src/Buy/Browse/V1/Api/ItemSummaryApi.php on lines 322..350
                  src/Buy/Browse/V1/Api/ItemSummaryApi.php on lines 373..551

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 118.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 5 locations. Consider refactoring.
                  Open

                      public function searchRequest($aspect_filter = null, $auto_correct = null, $category_ids = null, $charity_ids = null, $compatibility_filter = null, $epid = null, $fieldgroups = null, $filter = null, $gtin = null, $limit = null, $offset = null, $q = null, $sort = null)
                      {
                          $resourcePath = '/item_summary/search';
                          $formParams = [];
                          $queryParams = [];
                  Severity: Major
                  Found in src/Buy/Browse/V1/Api/ItemSummaryApi.php and 4 other locations - About 1 hr to fix
                  src/Buy/Browse/V1/Api/ItemSummaryApi.php on lines 174..179
                  src/Buy/Browse/V1/Api/ItemSummaryApi.php on lines 203..268
                  src/Buy/Browse/V1/Api/ItemSummaryApi.php on lines 291..299
                  src/Buy/Browse/V1/Api/ItemSummaryApi.php on lines 322..350

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 118.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 5 locations. Consider refactoring.
                  Open

                      public function searchWithHttpInfo($aspect_filter = null, $auto_correct = null, $category_ids = null, $charity_ids = null, $compatibility_filter = null, $epid = null, $fieldgroups = null, $filter = null, $gtin = null, $limit = null, $offset = null, $q = null, $sort = null)
                      {
                          $request = $this->searchRequest($aspect_filter, $auto_correct, $category_ids, $charity_ids, $compatibility_filter, $epid, $fieldgroups, $filter, $gtin, $limit, $offset, $q, $sort);
                  
                          try {
                  Severity: Major
                  Found in src/Buy/Browse/V1/Api/ItemSummaryApi.php and 4 other locations - About 1 hr to fix
                  src/Buy/Browse/V1/Api/ItemSummaryApi.php on lines 174..179
                  src/Buy/Browse/V1/Api/ItemSummaryApi.php on lines 291..299
                  src/Buy/Browse/V1/Api/ItemSummaryApi.php on lines 322..350
                  src/Buy/Browse/V1/Api/ItemSummaryApi.php on lines 373..551

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 118.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 5 locations. Consider refactoring.
                  Open

                      public function search($aspect_filter = null, $auto_correct = null, $category_ids = null, $charity_ids = null, $compatibility_filter = null, $epid = null, $fieldgroups = null, $filter = null, $gtin = null, $limit = null, $offset = null, $q = null, $sort = null)
                      {
                          [$response] = $this->searchWithHttpInfo($aspect_filter, $auto_correct, $category_ids, $charity_ids, $compatibility_filter, $epid, $fieldgroups, $filter, $gtin, $limit, $offset, $q, $sort);
                  
                          return $response;
                  Severity: Major
                  Found in src/Buy/Browse/V1/Api/ItemSummaryApi.php and 4 other locations - About 1 hr to fix
                  src/Buy/Browse/V1/Api/ItemSummaryApi.php on lines 203..268
                  src/Buy/Browse/V1/Api/ItemSummaryApi.php on lines 291..299
                  src/Buy/Browse/V1/Api/ItemSummaryApi.php on lines 322..350
                  src/Buy/Browse/V1/Api/ItemSummaryApi.php on lines 373..551

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 118.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status