Sign upLogin

brandon14/ebay-sdk-php

View on GitHub
Star
src/Buy/Browse/V1/Api/SearchByImageApi.php

Summary

Maintainability
F
1 wk
Test Coverage

Method searchByImageRequest has 119 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function searchByImageRequest($aspect_filter = null, $category_ids = null, $charity_ids = null, $fieldgroups = null, $filter = null, $limit = null, $offset = null, $sort = null, $search_by_image_request = null)
    {
        $resourcePath = '/item_summary/search_by_image';
        $formParams = [];
        $queryParams = [];
Severity: Major
Found in src/Buy/Browse/V1/Api/SearchByImageApi.php - About 4 hrs to fix

    Function searchByImageRequest has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

        public function searchByImageRequest($aspect_filter = null, $category_ids = null, $charity_ids = null, $fieldgroups = null, $filter = null, $limit = null, $offset = null, $sort = null, $search_by_image_request = null)
    {
        $resourcePath = '/item_summary/search_by_image';
        $formParams = [];
        $queryParams = [];
    Severity: Minor
    Found in src/Buy/Browse/V1/Api/SearchByImageApi.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File SearchByImageApi.php has 274 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

/**
 * This file is part of the trollandtoad/ebay-sdk-php package.
 *
    Severity: Minor
    Found in src/Buy/Browse/V1/Api/SearchByImageApi.php - About 2 hrs to fix

      Method searchByImageWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function searchByImageWithHttpInfo($aspect_filter = null, $category_ids = null, $charity_ids = null, $fieldgroups = null, $filter = null, $limit = null, $offset = null, $sort = null, $search_by_image_request = null)
    {
        $request = $this->searchByImageRequest($aspect_filter, $category_ids, $charity_ids, $fieldgroups, $filter, $limit, $offset, $sort, $search_by_image_request);

        try {
      Severity: Major
      Found in src/Buy/Browse/V1/Api/SearchByImageApi.php - About 2 hrs to fix

        Function searchByImageWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            public function searchByImageWithHttpInfo($aspect_filter = null, $category_ids = null, $charity_ids = null, $fieldgroups = null, $filter = null, $limit = null, $offset = null, $sort = null, $search_by_image_request = null)
    {
        $request = $this->searchByImageRequest($aspect_filter, $category_ids, $charity_ids, $fieldgroups, $filter, $limit, $offset, $sort, $search_by_image_request);

        try {
        Severity: Minor
        Found in src/Buy/Browse/V1/Api/SearchByImageApi.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method searchByImage has 9 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function searchByImage($aspect_filter = null, $category_ids = null, $charity_ids = null, $fieldgroups = null, $filter = null, $limit = null, $offset = null, $sort = null, $search_by_image_request = null)
        Severity: Major
        Found in src/Buy/Browse/V1/Api/SearchByImageApi.php - About 1 hr to fix

          Method searchByImageWithHttpInfo has 9 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function searchByImageWithHttpInfo($aspect_filter = null, $category_ids = null, $charity_ids = null, $fieldgroups = null, $filter = null, $limit = null, $offset = null, $sort = null, $search_by_image_request = null)
          Severity: Major
          Found in src/Buy/Browse/V1/Api/SearchByImageApi.php - About 1 hr to fix

            Method searchByImageAsyncWithHttpInfo has 9 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function searchByImageAsyncWithHttpInfo($aspect_filter = null, $category_ids = null, $charity_ids = null, $fieldgroups = null, $filter = null, $limit = null, $offset = null, $sort = null, $search_by_image_request = null)
            Severity: Major
            Found in src/Buy/Browse/V1/Api/SearchByImageApi.php - About 1 hr to fix

              Method searchByImageAsync has 9 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function searchByImageAsync($aspect_filter = null, $category_ids = null, $charity_ids = null, $fieldgroups = null, $filter = null, $limit = null, $offset = null, $sort = null, $search_by_image_request = null)
              Severity: Major
              Found in src/Buy/Browse/V1/Api/SearchByImageApi.php - About 1 hr to fix

                Method searchByImageRequest has 9 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public function searchByImageRequest($aspect_filter = null, $category_ids = null, $charity_ids = null, $fieldgroups = null, $filter = null, $limit = null, $offset = null, $sort = null, $search_by_image_request = null)
                Severity: Major
                Found in src/Buy/Browse/V1/Api/SearchByImageApi.php - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function searchByImageWithHttpInfo($aspect_filter = null, $category_ids = null, $charity_ids = null, $fieldgroups = null, $filter = null, $limit = null, $offset = null, $sort = null, $search_by_image_request = null)
    {
        $request = $this->searchByImageRequest($aspect_filter, $category_ids, $charity_ids, $fieldgroups, $filter, $limit, $offset, $sort, $search_by_image_request);

        try {
                  Severity: Major
                  Found in src/Buy/Browse/V1/Api/SearchByImageApi.php and 1 other location - About 3 days to fix
                  src/Commerce/CatalogBeta/V1/Api/ProductSummaryApi.php on lines 195..260

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 621.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function searchByImageAsyncWithHttpInfo($aspect_filter = null, $category_ids = null, $charity_ids = null, $fieldgroups = null, $filter = null, $limit = null, $offset = null, $sort = null, $search_by_image_request = null)
    {
        $returnType = '\TNT\Ebay\Buy\Browse\V1\Model\SearchPagedCollection';
        $request = $this->searchByImageRequest($aspect_filter, $category_ids, $charity_ids, $fieldgroups, $filter, $limit, $offset, $sort, $search_by_image_request);
                  Severity: Major
                  Found in src/Buy/Browse/V1/Api/SearchByImageApi.php and 1 other location - About 1 day to fix
                  src/Commerce/CatalogBeta/V1/Api/ProductSummaryApi.php on lines 306..334

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 325.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function searchByImageAsync($aspect_filter = null, $category_ids = null, $charity_ids = null, $fieldgroups = null, $filter = null, $limit = null, $offset = null, $sort = null, $search_by_image_request = null)
    {
        return $this->searchByImageAsyncWithHttpInfo($aspect_filter, $category_ids, $charity_ids, $fieldgroups, $filter, $limit, $offset, $sort, $search_by_image_request)
            ->then(
                function ($response) {
                  Severity: Major
                  Found in src/Buy/Browse/V1/Api/SearchByImageApi.php and 1 other location - About 2 hrs to fix
                  src/Commerce/CatalogBeta/V1/Api/ProductSummaryApi.php on lines 279..287

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 139.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function searchByImage($aspect_filter = null, $category_ids = null, $charity_ids = null, $fieldgroups = null, $filter = null, $limit = null, $offset = null, $sort = null, $search_by_image_request = null)
    {
        [$response] = $this->searchByImageWithHttpInfo($aspect_filter, $category_ids, $charity_ids, $fieldgroups, $filter, $limit, $offset, $sort, $search_by_image_request);

        return $response;
                  Severity: Major
                  Found in src/Buy/Browse/V1/Api/SearchByImageApi.php and 1 other location - About 2 hrs to fix
                  src/Commerce/CatalogBeta/V1/Api/ProductSummaryApi.php on lines 170..175

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 129.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status