Sign upLogin

brandon14/ebay-sdk-php

View on GitHub
Star
src/Buy/Deal/V1/Api/DealItemApi.php

Summary

Maintainability
F
1 wk
Test Coverage

Method getDealItemsRequest has 95 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getDealItemsRequest($x_ebay_c_marketplace_id, $category_ids = null, $commissionable = null, $delivery_country = null, $limit = null, $offset = null)
    {
        // Verify the required parameter 'x_ebay_c_marketplace_id' is set.
        if ($x_ebay_c_marketplace_id === null || (\is_array($x_ebay_c_marketplace_id) && count($x_ebay_c_marketplace_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $x_ebay_c_marketplace_id when calling getDealItems');
Severity: Major
Found in src/Buy/Deal/V1/Api/DealItemApi.php - About 3 hrs to fix

    Function getDealItemsRequest has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getDealItemsRequest($x_ebay_c_marketplace_id, $category_ids = null, $commissionable = null, $delivery_country = null, $limit = null, $offset = null)
    {
        // Verify the required parameter 'x_ebay_c_marketplace_id' is set.
        if ($x_ebay_c_marketplace_id === null || (\is_array($x_ebay_c_marketplace_id) && count($x_ebay_c_marketplace_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $x_ebay_c_marketplace_id when calling getDealItems');
    Severity: Minor
    Found in src/Buy/Deal/V1/Api/DealItemApi.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getDealItemsWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getDealItemsWithHttpInfo($x_ebay_c_marketplace_id, $category_ids = null, $commissionable = null, $delivery_country = null, $limit = null, $offset = null)
    {
        $request = $this->getDealItemsRequest($x_ebay_c_marketplace_id, $category_ids, $commissionable, $delivery_country, $limit, $offset);

        try {
    Severity: Major
    Found in src/Buy/Deal/V1/Api/DealItemApi.php - About 2 hrs to fix

      Function getDealItemsWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getDealItemsWithHttpInfo($x_ebay_c_marketplace_id, $category_ids = null, $commissionable = null, $delivery_country = null, $limit = null, $offset = null)
    {
        $request = $this->getDealItemsRequest($x_ebay_c_marketplace_id, $category_ids, $commissionable, $delivery_country, $limit, $offset);

        try {
      Severity: Minor
      Found in src/Buy/Deal/V1/Api/DealItemApi.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getDealItemsWithHttpInfo has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function getDealItemsWithHttpInfo($x_ebay_c_marketplace_id, $category_ids = null, $commissionable = null, $delivery_country = null, $limit = null, $offset = null)
      Severity: Minor
      Found in src/Buy/Deal/V1/Api/DealItemApi.php - About 45 mins to fix

        Method getDealItemsAsync has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function getDealItemsAsync($x_ebay_c_marketplace_id, $category_ids = null, $commissionable = null, $delivery_country = null, $limit = null, $offset = null)
        Severity: Minor
        Found in src/Buy/Deal/V1/Api/DealItemApi.php - About 45 mins to fix

          Method getDealItemsAsyncWithHttpInfo has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function getDealItemsAsyncWithHttpInfo($x_ebay_c_marketplace_id, $category_ids = null, $commissionable = null, $delivery_country = null, $limit = null, $offset = null)
          Severity: Minor
          Found in src/Buy/Deal/V1/Api/DealItemApi.php - About 45 mins to fix

            Method getDealItemsRequest has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function getDealItemsRequest($x_ebay_c_marketplace_id, $category_ids = null, $commissionable = null, $delivery_country = null, $limit = null, $offset = null)
            Severity: Minor
            Found in src/Buy/Deal/V1/Api/DealItemApi.php - About 45 mins to fix

              Method getDealItems has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function getDealItems($x_ebay_c_marketplace_id, $category_ids = null, $commissionable = null, $delivery_country = null, $limit = null, $offset = null)
              Severity: Minor
              Found in src/Buy/Deal/V1/Api/DealItemApi.php - About 45 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function getDealItemsRequest($x_ebay_c_marketplace_id, $category_ids = null, $commissionable = null, $delivery_country = null, $limit = null, $offset = null)
    {
        // Verify the required parameter 'x_ebay_c_marketplace_id' is set.
        if ($x_ebay_c_marketplace_id === null || (\is_array($x_ebay_c_marketplace_id) && count($x_ebay_c_marketplace_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $x_ebay_c_marketplace_id when calling getDealItems');
                Severity: Major
                Found in src/Buy/Deal/V1/Api/DealItemApi.php and 1 other location - About 3 days to fix
                src/Sell/Compliance/V1/Api/ListingViolationApi.php on lines 338..458

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 736.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 5 locations. Consider refactoring.
                Open

                    public function getDealItemsWithHttpInfo($x_ebay_c_marketplace_id, $category_ids = null, $commissionable = null, $delivery_country = null, $limit = null, $offset = null)
    {
        $request = $this->getDealItemsRequest($x_ebay_c_marketplace_id, $category_ids, $commissionable, $delivery_country, $limit, $offset);

        try {
                Severity: Major
                Found in src/Buy/Deal/V1/Api/DealItemApi.php and 4 other locations - About 3 days to fix
                src/Sell/Compliance/V1/Api/ListingViolationApi.php on lines 189..254
                src/Sell/Marketing/V1/Api/AdApi.php on lines 3591..3656
                src/Sell/Marketing/V1/Api/PromotionApi.php on lines 189..254
                src/Sell/Marketing/V1/Api/PromotionReportApi.php on lines 189..254

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 580.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 5 locations. Consider refactoring.
                Open

                    public function getDealItemsAsyncWithHttpInfo($x_ebay_c_marketplace_id, $category_ids = null, $commissionable = null, $delivery_country = null, $limit = null, $offset = null)
    {
        $returnType = '\TNT\Ebay\Buy\Deal\V1\Model\DealItemSearchResponse';
        $request = $this->getDealItemsRequest($x_ebay_c_marketplace_id, $category_ids, $commissionable, $delivery_country, $limit, $offset);
                Severity: Major
                Found in src/Buy/Deal/V1/Api/DealItemApi.php and 4 other locations - About 1 day to fix
                src/Sell/Compliance/V1/Api/ListingViolationApi.php on lines 294..322
                src/Sell/Marketing/V1/Api/AdApi.php on lines 3696..3724
                src/Sell/Marketing/V1/Api/PromotionApi.php on lines 294..322
                src/Sell/Marketing/V1/Api/PromotionReportApi.php on lines 294..322

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 284.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 5 locations. Consider refactoring.
                Open

                    public function getDealItemsAsync($x_ebay_c_marketplace_id, $category_ids = null, $commissionable = null, $delivery_country = null, $limit = null, $offset = null)
    {
        return $this->getDealItemsAsyncWithHttpInfo($x_ebay_c_marketplace_id, $category_ids, $commissionable, $delivery_country, $limit, $offset)
            ->then(
                function ($response) {
                Severity: Major
                Found in src/Buy/Deal/V1/Api/DealItemApi.php and 4 other locations - About 55 mins to fix
                src/Sell/Compliance/V1/Api/ListingViolationApi.php on lines 270..278
                src/Sell/Marketing/V1/Api/AdApi.php on lines 3672..3680
                src/Sell/Marketing/V1/Api/PromotionApi.php on lines 270..278
                src/Sell/Marketing/V1/Api/PromotionReportApi.php on lines 270..278

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 98.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status