Sign upLogin

brandon14/ebay-sdk-php

View on GitHub
Star
src/Buy/Feed/V1/Api/FeedTypeApi.php

Summary

Maintainability
F
1 wk
Test Coverage

File FeedTypeApi.php has 400 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * This file is part of the trollandtoad/ebay-sdk-php package.
 *
Severity: Minor
Found in src/Buy/Feed/V1/Api/FeedTypeApi.php - About 5 hrs to fix

    Method getFeedTypesRequest has 82 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getFeedTypesRequest($continuation_token = null, $feed_scope = null, $limit = null, $marketplace_ids = null)
    {
        $resourcePath = '/feed_type';
        $formParams = [];
        $queryParams = [];
    Severity: Major
    Found in src/Buy/Feed/V1/Api/FeedTypeApi.php - About 3 hrs to fix

      Function getFeedTypeRequest has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getFeedTypeRequest($feed_type_id)
    {
        // Verify the required parameter 'feed_type_id' is set.
        if ($feed_type_id === null || (\is_array($feed_type_id) && count($feed_type_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $feed_type_id when calling getFeedType');
      Severity: Minor
      Found in src/Buy/Feed/V1/Api/FeedTypeApi.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getFeedTypeRequest has 64 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getFeedTypeRequest($feed_type_id)
    {
        // Verify the required parameter 'feed_type_id' is set.
        if ($feed_type_id === null || (\is_array($feed_type_id) && count($feed_type_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $feed_type_id when calling getFeedType');
      Severity: Major
      Found in src/Buy/Feed/V1/Api/FeedTypeApi.php - About 2 hrs to fix

        Method getFeedTypeWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getFeedTypeWithHttpInfo($feed_type_id)
    {
        $request = $this->getFeedTypeRequest($feed_type_id);

        try {
        Severity: Major
        Found in src/Buy/Feed/V1/Api/FeedTypeApi.php - About 2 hrs to fix

          Method getFeedTypesWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getFeedTypesWithHttpInfo($continuation_token = null, $feed_scope = null, $limit = null, $marketplace_ids = null)
    {
        $request = $this->getFeedTypesRequest($continuation_token, $feed_scope, $limit, $marketplace_ids);

        try {
          Severity: Major
          Found in src/Buy/Feed/V1/Api/FeedTypeApi.php - About 2 hrs to fix

            Function getFeedTypesRequest has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getFeedTypesRequest($continuation_token = null, $feed_scope = null, $limit = null, $marketplace_ids = null)
    {
        $resourcePath = '/feed_type';
        $formParams = [];
        $queryParams = [];
            Severity: Minor
            Found in src/Buy/Feed/V1/Api/FeedTypeApi.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getFeedTypeWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getFeedTypeWithHttpInfo($feed_type_id)
    {
        $request = $this->getFeedTypeRequest($feed_type_id);

        try {
            Severity: Minor
            Found in src/Buy/Feed/V1/Api/FeedTypeApi.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getFeedTypesWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getFeedTypesWithHttpInfo($continuation_token = null, $feed_scope = null, $limit = null, $marketplace_ids = null)
    {
        $request = $this->getFeedTypesRequest($continuation_token, $feed_scope, $limit, $marketplace_ids);

        try {
            Severity: Minor
            Found in src/Buy/Feed/V1/Api/FeedTypeApi.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public function getFeedTypesRequest($continuation_token = null, $feed_scope = null, $limit = null, $marketplace_ids = null)
    {
        $resourcePath = '/feed_type';
        $formParams = [];
        $queryParams = [];
            Severity: Major
            Found in src/Buy/Feed/V1/Api/FeedTypeApi.php and 1 other location - About 3 days to fix
            src/Sell/Analytics/V1/Api/TrafficReportApi.php on lines 328..430

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 601.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public function getFeedTypesWithHttpInfo($continuation_token = null, $feed_scope = null, $limit = null, $marketplace_ids = null)
    {
        $request = $this->getFeedTypesRequest($continuation_token, $feed_scope, $limit, $marketplace_ids);

        try {
            Severity: Major
            Found in src/Buy/Feed/V1/Api/FeedTypeApi.php and 1 other location - About 2 days to fix
            src/Sell/Analytics/V1/Api/TrafficReportApi.php on lines 185..250

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 561.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public function getFeedTypesAsyncWithHttpInfo($continuation_token = null, $feed_scope = null, $limit = null, $marketplace_ids = null)
    {
        $returnType = '\TNT\Ebay\Buy\Feed\V1\Model\FeedTypeSearchResponse';
        $request = $this->getFeedTypesRequest($continuation_token, $feed_scope, $limit, $marketplace_ids);
            Severity: Major
            Found in src/Buy/Feed/V1/Api/FeedTypeApi.php and 1 other location - About 1 day to fix
            src/Sell/Analytics/V1/Api/TrafficReportApi.php on lines 286..314

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 265.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status