Sign upLogin

brandon14/ebay-sdk-php

View on GitHub
Star
src/Buy/FeedBeta/V1/Api/ItemSnapshotApi.php

Summary

Maintainability
F
2 wks
Test Coverage

Function getItemSnapshotFeedRequest has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

    public function getItemSnapshotFeedRequest($accept, $x_ebay_c_marketplace_id, $range, $category_id, $snapshot_date)
    {
        // Verify the required parameter 'accept' is set.
        if ($accept === null || (\is_array($accept) && count($accept) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $accept when calling getItemSnapshotFeed');
Severity: Minor
Found in src/Buy/FeedBeta/V1/Api/ItemSnapshotApi.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getItemSnapshotFeedRequest has 92 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getItemSnapshotFeedRequest($accept, $x_ebay_c_marketplace_id, $range, $category_id, $snapshot_date)
    {
        // Verify the required parameter 'accept' is set.
        if ($accept === null || (\is_array($accept) && count($accept) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $accept when calling getItemSnapshotFeed');
Severity: Major
Found in src/Buy/FeedBeta/V1/Api/ItemSnapshotApi.php - About 3 hrs to fix

    Method getItemSnapshotFeedWithHttpInfo has 72 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getItemSnapshotFeedWithHttpInfo($accept, $x_ebay_c_marketplace_id, $range, $category_id, $snapshot_date)
    {
        $request = $this->getItemSnapshotFeedRequest($accept, $x_ebay_c_marketplace_id, $range, $category_id, $snapshot_date);

        try {
    Severity: Major
    Found in src/Buy/FeedBeta/V1/Api/ItemSnapshotApi.php - About 2 hrs to fix

      File ItemSnapshotApi.php has 266 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php

/**
 * This file is part of the trollandtoad/ebay-sdk-php package.
 *
      Severity: Minor
      Found in src/Buy/FeedBeta/V1/Api/ItemSnapshotApi.php - About 2 hrs to fix

        Function getItemSnapshotFeedWithHttpInfo has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getItemSnapshotFeedWithHttpInfo($accept, $x_ebay_c_marketplace_id, $range, $category_id, $snapshot_date)
    {
        $request = $this->getItemSnapshotFeedRequest($accept, $x_ebay_c_marketplace_id, $range, $category_id, $snapshot_date);

        try {
        Severity: Minor
        Found in src/Buy/FeedBeta/V1/Api/ItemSnapshotApi.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getItemSnapshotFeedWithHttpInfo has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function getItemSnapshotFeedWithHttpInfo($accept, $x_ebay_c_marketplace_id, $range, $category_id, $snapshot_date)
        Severity: Minor
        Found in src/Buy/FeedBeta/V1/Api/ItemSnapshotApi.php - About 35 mins to fix

          Method getItemSnapshotFeed has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function getItemSnapshotFeed($accept, $x_ebay_c_marketplace_id, $range, $category_id, $snapshot_date)
          Severity: Minor
          Found in src/Buy/FeedBeta/V1/Api/ItemSnapshotApi.php - About 35 mins to fix

            Method getItemSnapshotFeedAsync has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function getItemSnapshotFeedAsync($accept, $x_ebay_c_marketplace_id, $range, $category_id, $snapshot_date)
            Severity: Minor
            Found in src/Buy/FeedBeta/V1/Api/ItemSnapshotApi.php - About 35 mins to fix

              Method getItemSnapshotFeedAsyncWithHttpInfo has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function getItemSnapshotFeedAsyncWithHttpInfo($accept, $x_ebay_c_marketplace_id, $range, $category_id, $snapshot_date)
              Severity: Minor
              Found in src/Buy/FeedBeta/V1/Api/ItemSnapshotApi.php - About 35 mins to fix

                Method getItemSnapshotFeedRequest has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public function getItemSnapshotFeedRequest($accept, $x_ebay_c_marketplace_id, $range, $category_id, $snapshot_date)
                Severity: Minor
                Found in src/Buy/FeedBeta/V1/Api/ItemSnapshotApi.php - About 35 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  <?php

/**
 * This file is part of the trollandtoad/ebay-sdk-php package.
 *
                  Severity: Major
                  Found in src/Buy/FeedBeta/V1/Api/ItemSnapshotApi.php and 1 other location - About 1 wk to fix
                  src/Buy/FeedBeta/V1/Api/ItemPriorityApi.php on lines 1..496

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 2120.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status