Sign upLogin

brandon14/ebay-sdk-php

View on GitHub
Star
src/Buy/Order/V2/Api/GuestPurchaseOrderApi.php

Summary

Maintainability
F
4 days
Test Coverage

Function getGuestPurchaseOrderRequest has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    public function getGuestPurchaseOrderRequest($purchase_order_id)
    {
        // Verify the required parameter 'purchase_order_id' is set.
        if ($purchase_order_id === null || (\is_array($purchase_order_id) && count($purchase_order_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $purchase_order_id when calling getGuestPurchaseOrder');
Severity: Minor
Found in src/Buy/Order/V2/Api/GuestPurchaseOrderApi.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getGuestPurchaseOrderRequest has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getGuestPurchaseOrderRequest($purchase_order_id)
    {
        // Verify the required parameter 'purchase_order_id' is set.
        if ($purchase_order_id === null || (\is_array($purchase_order_id) && count($purchase_order_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $purchase_order_id when calling getGuestPurchaseOrder');
Severity: Major
Found in src/Buy/Order/V2/Api/GuestPurchaseOrderApi.php - About 2 hrs to fix

    Method getGuestPurchaseOrderWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getGuestPurchaseOrderWithHttpInfo($purchase_order_id)
    {
        $request = $this->getGuestPurchaseOrderRequest($purchase_order_id);

        try {
    Severity: Major
    Found in src/Buy/Order/V2/Api/GuestPurchaseOrderApi.php - About 2 hrs to fix

      Function getGuestPurchaseOrderWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getGuestPurchaseOrderWithHttpInfo($purchase_order_id)
    {
        $request = $this->getGuestPurchaseOrderRequest($purchase_order_id);

        try {
      Severity: Minor
      Found in src/Buy/Order/V2/Api/GuestPurchaseOrderApi.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          public function getGuestPurchaseOrderRequest($purchase_order_id)
    {
        // Verify the required parameter 'purchase_order_id' is set.
        if ($purchase_order_id === null || (\is_array($purchase_order_id) && count($purchase_order_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $purchase_order_id when calling getGuestPurchaseOrder');
      Severity: Major
      Found in src/Buy/Order/V2/Api/GuestPurchaseOrderApi.php and 3 other locations - About 2 days to fix
      src/Sell/Fulfillment/V1/Api/PaymentDisputeApi.php on lines 1414..1504
      src/Sell/Fulfillment/V1/Api/PaymentDisputeApi.php on lines 1690..1780
      src/Sell/Fulfillment/V1/Api/PaymentDisputeApi.php on lines 2555..2645

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 554.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status