Sign upLogin

brandon14/ebay-sdk-php

View on GitHub
Star
src/Commerce/Charity/V1/Api/CharityOrgApi.php

Summary

Maintainability
F
1 wk
Test Coverage

File CharityOrgApi.php has 581 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * This file is part of the trollandtoad/ebay-sdk-php package.
 *
Severity: Major
Found in src/Commerce/Charity/V1/Api/CharityOrgApi.php - About 1 day to fix

    Method getCharityOrgsRequest has 88 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getCharityOrgsRequest($x_ebay_c_marketplace_id, $limit = null, $offset = null, $q = null, $registration_ids = null)
    {
        // Verify the required parameter 'x_ebay_c_marketplace_id' is set.
        if ($x_ebay_c_marketplace_id === null || (\is_array($x_ebay_c_marketplace_id) && count($x_ebay_c_marketplace_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $x_ebay_c_marketplace_id when calling getCharityOrgs');
    Severity: Major
    Found in src/Commerce/Charity/V1/Api/CharityOrgApi.php - About 3 hrs to fix

      Function getCharityOrgRequest has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getCharityOrgRequest($charity_org_id, $x_ebay_c_marketplace_id)
    {
        // Verify the required parameter 'charity_org_id' is set.
        if ($charity_org_id === null || (\is_array($charity_org_id) && count($charity_org_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $charity_org_id when calling getCharityOrg');
      Severity: Minor
      Found in src/Commerce/Charity/V1/Api/CharityOrgApi.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getCharityOrgByLegacyIdRequest has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getCharityOrgByLegacyIdRequest($x_ebay_c_marketplace_id, $legacy_charity_org_id)
    {
        // Verify the required parameter 'x_ebay_c_marketplace_id' is set.
        if ($x_ebay_c_marketplace_id === null || (\is_array($x_ebay_c_marketplace_id) && count($x_ebay_c_marketplace_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $x_ebay_c_marketplace_id when calling getCharityOrgByLegacyId');
      Severity: Minor
      Found in src/Commerce/Charity/V1/Api/CharityOrgApi.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getCharityOrgRequest has 70 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getCharityOrgRequest($charity_org_id, $x_ebay_c_marketplace_id)
    {
        // Verify the required parameter 'charity_org_id' is set.
        if ($charity_org_id === null || (\is_array($charity_org_id) && count($charity_org_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $charity_org_id when calling getCharityOrg');
      Severity: Major
      Found in src/Commerce/Charity/V1/Api/CharityOrgApi.php - About 2 hrs to fix

        Method getCharityOrgByLegacyIdRequest has 70 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getCharityOrgByLegacyIdRequest($x_ebay_c_marketplace_id, $legacy_charity_org_id)
    {
        // Verify the required parameter 'x_ebay_c_marketplace_id' is set.
        if ($x_ebay_c_marketplace_id === null || (\is_array($x_ebay_c_marketplace_id) && count($x_ebay_c_marketplace_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $x_ebay_c_marketplace_id when calling getCharityOrgByLegacyId');
        Severity: Major
        Found in src/Commerce/Charity/V1/Api/CharityOrgApi.php - About 2 hrs to fix

          Function getCharityOrgsRequest has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getCharityOrgsRequest($x_ebay_c_marketplace_id, $limit = null, $offset = null, $q = null, $registration_ids = null)
    {
        // Verify the required parameter 'x_ebay_c_marketplace_id' is set.
        if ($x_ebay_c_marketplace_id === null || (\is_array($x_ebay_c_marketplace_id) && count($x_ebay_c_marketplace_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $x_ebay_c_marketplace_id when calling getCharityOrgs');
          Severity: Minor
          Found in src/Commerce/Charity/V1/Api/CharityOrgApi.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method getCharityOrgsWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getCharityOrgsWithHttpInfo($x_ebay_c_marketplace_id, $limit = null, $offset = null, $q = null, $registration_ids = null)
    {
        $request = $this->getCharityOrgsRequest($x_ebay_c_marketplace_id, $limit, $offset, $q, $registration_ids);

        try {
          Severity: Major
          Found in src/Commerce/Charity/V1/Api/CharityOrgApi.php - About 2 hrs to fix

            Method getCharityOrgByLegacyIdWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function getCharityOrgByLegacyIdWithHttpInfo($x_ebay_c_marketplace_id, $legacy_charity_org_id)
    {
        $request = $this->getCharityOrgByLegacyIdRequest($x_ebay_c_marketplace_id, $legacy_charity_org_id);

        try {
            Severity: Major
            Found in src/Commerce/Charity/V1/Api/CharityOrgApi.php - About 2 hrs to fix

              Method getCharityOrgWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function getCharityOrgWithHttpInfo($charity_org_id, $x_ebay_c_marketplace_id)
    {
        $request = $this->getCharityOrgRequest($charity_org_id, $x_ebay_c_marketplace_id);

        try {
              Severity: Major
              Found in src/Commerce/Charity/V1/Api/CharityOrgApi.php - About 2 hrs to fix

                Function getCharityOrgsWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function getCharityOrgsWithHttpInfo($x_ebay_c_marketplace_id, $limit = null, $offset = null, $q = null, $registration_ids = null)
    {
        $request = $this->getCharityOrgsRequest($x_ebay_c_marketplace_id, $limit, $offset, $q, $registration_ids);

        try {
                Severity: Minor
                Found in src/Commerce/Charity/V1/Api/CharityOrgApi.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function getCharityOrgByLegacyIdWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function getCharityOrgByLegacyIdWithHttpInfo($x_ebay_c_marketplace_id, $legacy_charity_org_id)
    {
        $request = $this->getCharityOrgByLegacyIdRequest($x_ebay_c_marketplace_id, $legacy_charity_org_id);

        try {
                Severity: Minor
                Found in src/Commerce/Charity/V1/Api/CharityOrgApi.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function getCharityOrgWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function getCharityOrgWithHttpInfo($charity_org_id, $x_ebay_c_marketplace_id)
    {
        $request = $this->getCharityOrgRequest($charity_org_id, $x_ebay_c_marketplace_id);

        try {
                Severity: Minor
                Found in src/Commerce/Charity/V1/Api/CharityOrgApi.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method getCharityOrgsAsync has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public function getCharityOrgsAsync($x_ebay_c_marketplace_id, $limit = null, $offset = null, $q = null, $registration_ids = null)
                Severity: Minor
                Found in src/Commerce/Charity/V1/Api/CharityOrgApi.php - About 35 mins to fix

                  Method getCharityOrgs has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      public function getCharityOrgs($x_ebay_c_marketplace_id, $limit = null, $offset = null, $q = null, $registration_ids = null)
                  Severity: Minor
                  Found in src/Commerce/Charity/V1/Api/CharityOrgApi.php - About 35 mins to fix

                    Method getCharityOrgsRequest has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public function getCharityOrgsRequest($x_ebay_c_marketplace_id, $limit = null, $offset = null, $q = null, $registration_ids = null)
                    Severity: Minor
                    Found in src/Commerce/Charity/V1/Api/CharityOrgApi.php - About 35 mins to fix

                      Method getCharityOrgsAsyncWithHttpInfo has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          public function getCharityOrgsAsyncWithHttpInfo($x_ebay_c_marketplace_id, $limit = null, $offset = null, $q = null, $registration_ids = null)
                      Severity: Minor
                      Found in src/Commerce/Charity/V1/Api/CharityOrgApi.php - About 35 mins to fix

                        Method getCharityOrgsWithHttpInfo has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            public function getCharityOrgsWithHttpInfo($x_ebay_c_marketplace_id, $limit = null, $offset = null, $q = null, $registration_ids = null)
                        Severity: Minor
                        Found in src/Commerce/Charity/V1/Api/CharityOrgApi.php - About 35 mins to fix

                          Similar blocks of code found in 3 locations. Consider refactoring.
                          Open

                              public function getCharityOrgsWithHttpInfo($x_ebay_c_marketplace_id, $limit = null, $offset = null, $q = null, $registration_ids = null)
    {
        $request = $this->getCharityOrgsRequest($x_ebay_c_marketplace_id, $limit, $offset, $q, $registration_ids);

        try {
                          Severity: Major
                          Found in src/Commerce/Charity/V1/Api/CharityOrgApi.php and 2 other locations - About 2 days to fix
                          src/Sell/Marketing/V1/Api/KeywordApi.php on lines 1249..1314
                          src/Sell/Recommendation/V1/Api/ListingRecommendationApi.php on lines 187..252

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 568.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 5 locations. Consider refactoring.
                          Open

                              public function getCharityOrgRequest($charity_org_id, $x_ebay_c_marketplace_id)
    {
        // Verify the required parameter 'charity_org_id' is set.
        if ($charity_org_id === null || (\is_array($charity_org_id) && count($charity_org_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $charity_org_id when calling getCharityOrg');
                          Severity: Major
                          Found in src/Commerce/Charity/V1/Api/CharityOrgApi.php and 4 other locations - About 2 days to fix
                          src/Buy/Deal/V1/Api/EventApi.php on lines 318..410
                          src/Buy/Feed/V1/Api/FileApi.php on lines 607..699
                          src/Buy/OfferBeta/V1/Api/BiddingApi.php on lines 318..410
                          src/Buy/Order/V2/Api/GuestCheckoutSessionApi.php on lines 589..681

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 562.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 3 locations. Consider refactoring.
                          Open

                              public function getCharityOrgsAsyncWithHttpInfo($x_ebay_c_marketplace_id, $limit = null, $offset = null, $q = null, $registration_ids = null)
    {
        $returnType = '\TNT\Ebay\Commerce\Charity\V1\Model\CharitySearchResponse';
        $request = $this->getCharityOrgsRequest($x_ebay_c_marketplace_id, $limit, $offset, $q, $registration_ids);
                          Severity: Major
                          Found in src/Commerce/Charity/V1/Api/CharityOrgApi.php and 2 other locations - About 1 day to fix
                          src/Sell/Marketing/V1/Api/KeywordApi.php on lines 1352..1380
                          src/Sell/Recommendation/V1/Api/ListingRecommendationApi.php on lines 290..318

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 272.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status