File VideoApi.php
has 477 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* This file is part of the trollandtoad/ebay-sdk-php package.
*
Function uploadVideoRequest
has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring. Open
public function uploadVideoRequest($content_type, $video_id, $content_length = null, $content_range = null, $body = null)
{
// Verify the required parameter 'content_type' is set.
if ($content_type === null || (\is_array($content_type) && count($content_type) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $content_type when calling uploadVideo');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method uploadVideoRequest
has 82 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function uploadVideoRequest($content_type, $video_id, $content_length = null, $content_range = null, $body = null)
{
// Verify the required parameter 'content_type' is set.
if ($content_type === null || (\is_array($content_type) && count($content_type) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $content_type when calling uploadVideo');
Function createVideoRequest
has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring. Open
public function createVideoRequest($body = null)
{
$resourcePath = '/video';
$formParams = [];
$queryParams = [];
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getVideoRequest
has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring. Open
public function getVideoRequest($video_id)
{
// Verify the required parameter 'video_id' is set.
if ($video_id === null || (\is_array($video_id) && count($video_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $video_id when calling getVideo');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getVideoRequest
has 64 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getVideoRequest($video_id)
{
// Verify the required parameter 'video_id' is set.
if ($video_id === null || (\is_array($video_id) && count($video_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $video_id when calling getVideo');
Method createVideoRequest
has 60 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function createVideoRequest($body = null)
{
$resourcePath = '/video';
$formParams = [];
$queryParams = [];
Method getVideoWithHttpInfo
has 53 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getVideoWithHttpInfo($video_id)
{
$request = $this->getVideoRequest($video_id);
try {
Function getVideoWithHttpInfo
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
public function getVideoWithHttpInfo($video_id)
{
$request = $this->getVideoRequest($video_id);
try {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method uploadVideoAsync
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public function uploadVideoAsync($content_type, $video_id, $content_length = null, $content_range = null, $body = null)
Method uploadVideo
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public function uploadVideo($content_type, $video_id, $content_length = null, $content_range = null, $body = null)
Method uploadVideoRequest
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public function uploadVideoRequest($content_type, $video_id, $content_length = null, $content_range = null, $body = null)
Method uploadVideoAsyncWithHttpInfo
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public function uploadVideoAsyncWithHttpInfo($content_type, $video_id, $content_length = null, $content_range = null, $body = null)
Method uploadVideoWithHttpInfo
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public function uploadVideoWithHttpInfo($content_type, $video_id, $content_length = null, $content_range = null, $body = null)
Function createVideoWithHttpInfo
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function createVideoWithHttpInfo($body = null)
{
$request = $this->createVideoRequest($body);
try {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function uploadVideoWithHttpInfo
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function uploadVideoWithHttpInfo($content_type, $video_id, $content_length = null, $content_range = null, $body = null)
{
$request = $this->uploadVideoRequest($content_type, $video_id, $content_length, $content_range, $body);
try {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Similar blocks of code found in 2 locations. Consider refactoring. Open
public function createVideoWithHttpInfo($body = null)
{
$request = $this->createVideoRequest($body);
try {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 353.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
public function createVideoAsyncWithHttpInfo($body = null)
{
$returnType = '';
$request = $this->createVideoRequest($body);
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 180.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76