Sign upLogin

brandon14/ebay-sdk-php

View on GitHub
Star
src/Commerce/Notification/V1/Api/ConfigApi.php

Summary

Maintainability
F
4 days
Test Coverage

File ConfigApi.php has 333 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * This file is part of the trollandtoad/ebay-sdk-php package.
 *
Severity: Minor
Found in src/Commerce/Notification/V1/Api/ConfigApi.php - About 4 hrs to fix

    Function updateConfigRequest has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

        public function updateConfigRequest($config = null)
    {
        $resourcePath = '/config';
        $formParams = [];
        $queryParams = [];
    Severity: Minor
    Found in src/Commerce/Notification/V1/Api/ConfigApi.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method updateConfigRequest has 63 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function updateConfigRequest($config = null)
    {
        $resourcePath = '/config';
        $formParams = [];
        $queryParams = [];
    Severity: Major
    Found in src/Commerce/Notification/V1/Api/ConfigApi.php - About 2 hrs to fix

      Method getConfigRequest has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getConfigRequest()
    {
        $resourcePath = '/config';
        $formParams = [];
        $queryParams = [];
      Severity: Major
      Found in src/Commerce/Notification/V1/Api/ConfigApi.php - About 2 hrs to fix

        Function getConfigRequest has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getConfigRequest()
    {
        $resourcePath = '/config';
        $formParams = [];
        $queryParams = [];
        Severity: Minor
        Found in src/Commerce/Notification/V1/Api/ConfigApi.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getConfigWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getConfigWithHttpInfo()
    {
        $request = $this->getConfigRequest();

        try {
        Severity: Major
        Found in src/Commerce/Notification/V1/Api/ConfigApi.php - About 2 hrs to fix

          Function getConfigWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getConfigWithHttpInfo()
    {
        $request = $this->getConfigRequest();

        try {
          Severity: Minor
          Found in src/Commerce/Notification/V1/Api/ConfigApi.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function updateConfigWithHttpInfo has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function updateConfigWithHttpInfo($config = null)
    {
        $request = $this->updateConfigRequest($config);

        try {
          Severity: Minor
          Found in src/Commerce/Notification/V1/Api/ConfigApi.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function updateConfigWithHttpInfo($config = null)
    {
        $request = $this->updateConfigRequest($config);

        try {
          Severity: Major
          Found in src/Commerce/Notification/V1/Api/ConfigApi.php and 1 other location - About 1 day to fix
          src/Commerce/MediaBeta/V1/Api/VideoApi.php on lines 177..207

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 353.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function updateConfigAsyncWithHttpInfo($config = null)
    {
        $returnType = '';
        $request = $this->updateConfigRequest($config);
          Severity: Major
          Found in src/Commerce/Notification/V1/Api/ConfigApi.php and 1 other location - About 4 hrs to fix
          src/Commerce/MediaBeta/V1/Api/VideoApi.php on lines 237..255

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 180.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status