Sign upLogin

brandon14/ebay-sdk-php

View on GitHub
Star
src/Commerce/Notification/V1/Api/DestinationApi.php

Summary

Maintainability
F
1 wk
Test Coverage

File DestinationApi.php has 810 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * This file is part of the trollandtoad/ebay-sdk-php package.
 *
Severity: Major
Found in src/Commerce/Notification/V1/Api/DestinationApi.php - About 1 day to fix

    DestinationApi has 30 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class DestinationApi
{
    /**
     * @var ClientInterface
     */
    Severity: Minor
    Found in src/Commerce/Notification/V1/Api/DestinationApi.php - About 3 hrs to fix

      Function updateDestinationRequest has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
      Open

          public function updateDestinationRequest($destination_id, $destination_request = null)
    {
        // Verify the required parameter 'destination_id' is set.
        if ($destination_id === null || (\is_array($destination_id) && count($destination_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $destination_id when calling updateDestination');
      Severity: Minor
      Found in src/Commerce/Notification/V1/Api/DestinationApi.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method updateDestinationRequest has 73 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function updateDestinationRequest($destination_id, $destination_request = null)
    {
        // Verify the required parameter 'destination_id' is set.
        if ($destination_id === null || (\is_array($destination_id) && count($destination_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $destination_id when calling updateDestination');
      Severity: Major
      Found in src/Commerce/Notification/V1/Api/DestinationApi.php - About 2 hrs to fix

        Function getDestinationRequest has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getDestinationRequest($destination_id)
    {
        // Verify the required parameter 'destination_id' is set.
        if ($destination_id === null || (\is_array($destination_id) && count($destination_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $destination_id when calling getDestination');
        Severity: Minor
        Found in src/Commerce/Notification/V1/Api/DestinationApi.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function createDestinationRequest has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

            public function createDestinationRequest($destination_request = null)
    {
        $resourcePath = '/destination';
        $formParams = [];
        $queryParams = [];
        Severity: Minor
        Found in src/Commerce/Notification/V1/Api/DestinationApi.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function deleteDestinationRequest has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

            public function deleteDestinationRequest($destination_id)
    {
        // Verify the required parameter 'destination_id' is set.
        if ($destination_id === null || (\is_array($destination_id) && count($destination_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $destination_id when calling deleteDestination');
        Severity: Minor
        Found in src/Commerce/Notification/V1/Api/DestinationApi.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getDestinationsRequest has 71 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getDestinationsRequest($limit = null, $continuation_token = null)
    {
        $resourcePath = '/destination';
        $formParams = [];
        $queryParams = [];
        Severity: Major
        Found in src/Commerce/Notification/V1/Api/DestinationApi.php - About 2 hrs to fix

          Method getDestinationRequest has 67 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getDestinationRequest($destination_id)
    {
        // Verify the required parameter 'destination_id' is set.
        if ($destination_id === null || (\is_array($destination_id) && count($destination_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $destination_id when calling getDestination');
          Severity: Major
          Found in src/Commerce/Notification/V1/Api/DestinationApi.php - About 2 hrs to fix

            Method deleteDestinationRequest has 67 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function deleteDestinationRequest($destination_id)
    {
        // Verify the required parameter 'destination_id' is set.
        if ($destination_id === null || (\is_array($destination_id) && count($destination_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $destination_id when calling deleteDestination');
            Severity: Major
            Found in src/Commerce/Notification/V1/Api/DestinationApi.php - About 2 hrs to fix

              Method createDestinationRequest has 63 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function createDestinationRequest($destination_request = null)
    {
        $resourcePath = '/destination';
        $formParams = [];
        $queryParams = [];
              Severity: Major
              Found in src/Commerce/Notification/V1/Api/DestinationApi.php - About 2 hrs to fix

                Function getDestinationsRequest has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function getDestinationsRequest($limit = null, $continuation_token = null)
    {
        $resourcePath = '/destination';
        $formParams = [];
        $queryParams = [];
                Severity: Minor
                Found in src/Commerce/Notification/V1/Api/DestinationApi.php - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method createDestinationWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function createDestinationWithHttpInfo($destination_request = null)
    {
        $request = $this->createDestinationRequest($destination_request);

        try {
                Severity: Major
                Found in src/Commerce/Notification/V1/Api/DestinationApi.php - About 2 hrs to fix

                  Method getDestinationsWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function getDestinationsWithHttpInfo($limit = null, $continuation_token = null)
    {
        $request = $this->getDestinationsRequest($limit, $continuation_token);

        try {
                  Severity: Major
                  Found in src/Commerce/Notification/V1/Api/DestinationApi.php - About 2 hrs to fix

                    Method getDestinationWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function getDestinationWithHttpInfo($destination_id)
    {
        $request = $this->getDestinationRequest($destination_id);

        try {
                    Severity: Major
                    Found in src/Commerce/Notification/V1/Api/DestinationApi.php - About 2 hrs to fix

                      Function getDestinationsWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function getDestinationsWithHttpInfo($limit = null, $continuation_token = null)
    {
        $request = $this->getDestinationsRequest($limit, $continuation_token);

        try {
                      Severity: Minor
                      Found in src/Commerce/Notification/V1/Api/DestinationApi.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function getDestinationWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function getDestinationWithHttpInfo($destination_id)
    {
        $request = $this->getDestinationRequest($destination_id);

        try {
                      Severity: Minor
                      Found in src/Commerce/Notification/V1/Api/DestinationApi.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function createDestinationWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function createDestinationWithHttpInfo($destination_request = null)
    {
        $request = $this->createDestinationRequest($destination_request);

        try {
                      Severity: Minor
                      Found in src/Commerce/Notification/V1/Api/DestinationApi.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function deleteDestinationWithHttpInfo has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function deleteDestinationWithHttpInfo($destination_id)
    {
        $request = $this->deleteDestinationRequest($destination_id);

        try {
                      Severity: Minor
                      Found in src/Commerce/Notification/V1/Api/DestinationApi.php - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function updateDestinationWithHttpInfo has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function updateDestinationWithHttpInfo($destination_id, $destination_request = null)
    {
        $request = $this->updateDestinationRequest($destination_id, $destination_request);

        try {
                      Severity: Minor
                      Found in src/Commerce/Notification/V1/Api/DestinationApi.php - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          public function updateDestinationRequest($destination_id, $destination_request = null)
    {
        // Verify the required parameter 'destination_id' is set.
        if ($destination_id === null || (\is_array($destination_id) && count($destination_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $destination_id when calling updateDestination');
                      Severity: Major
                      Found in src/Commerce/Notification/V1/Api/DestinationApi.php and 1 other location - About 2 days to fix
                      src/Commerce/Notification/V1/Api/SubscriptionApi.php on lines 1833..1926

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 570.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status