Sign upLogin

brandon14/ebay-sdk-php

View on GitHub
Star
src/Commerce/Notification/V1/Api/SubscriptionApi.php

Summary

Maintainability
F
2 wks
Test Coverage

File SubscriptionApi.php has 1185 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * This file is part of the trollandtoad/ebay-sdk-php package.
 *
Severity: Major
Found in src/Commerce/Notification/V1/Api/SubscriptionApi.php - About 3 days to fix

    SubscriptionApi has 45 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class SubscriptionApi
{
    /**
     * @var ClientInterface
     */
    Severity: Minor
    Found in src/Commerce/Notification/V1/Api/SubscriptionApi.php - About 6 hrs to fix

      Function updateSubscriptionRequest has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
      Open

          public function updateSubscriptionRequest($subscription_id, $update_subscription_request = null)
    {
        // Verify the required parameter 'subscription_id' is set.
        if ($subscription_id === null || (\is_array($subscription_id) && count($subscription_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $subscription_id when calling updateSubscription');
      Severity: Minor
      Found in src/Commerce/Notification/V1/Api/SubscriptionApi.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method updateSubscriptionRequest has 73 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function updateSubscriptionRequest($subscription_id, $update_subscription_request = null)
    {
        // Verify the required parameter 'subscription_id' is set.
        if ($subscription_id === null || (\is_array($subscription_id) && count($subscription_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $subscription_id when calling updateSubscription');
      Severity: Major
      Found in src/Commerce/Notification/V1/Api/SubscriptionApi.php - About 2 hrs to fix

        Function disableSubscriptionRequest has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

            public function disableSubscriptionRequest($subscription_id)
    {
        // Verify the required parameter 'subscription_id' is set.
        if ($subscription_id === null || (\is_array($subscription_id) && count($subscription_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $subscription_id when calling disableSubscription');
        Severity: Minor
        Found in src/Commerce/Notification/V1/Api/SubscriptionApi.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function testRequest has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

            public function testRequest($subscription_id)
    {
        // Verify the required parameter 'subscription_id' is set.
        if ($subscription_id === null || (\is_array($subscription_id) && count($subscription_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $subscription_id when calling test');
        Severity: Minor
        Found in src/Commerce/Notification/V1/Api/SubscriptionApi.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getSubscriptionRequest has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getSubscriptionRequest($subscription_id)
    {
        // Verify the required parameter 'subscription_id' is set.
        if ($subscription_id === null || (\is_array($subscription_id) && count($subscription_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $subscription_id when calling getSubscription');
        Severity: Minor
        Found in src/Commerce/Notification/V1/Api/SubscriptionApi.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function deleteSubscriptionRequest has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

            public function deleteSubscriptionRequest($subscription_id)
    {
        // Verify the required parameter 'subscription_id' is set.
        if ($subscription_id === null || (\is_array($subscription_id) && count($subscription_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $subscription_id when calling deleteSubscription');
        Severity: Minor
        Found in src/Commerce/Notification/V1/Api/SubscriptionApi.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function enableSubscriptionRequest has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

            public function enableSubscriptionRequest($subscription_id)
    {
        // Verify the required parameter 'subscription_id' is set.
        if ($subscription_id === null || (\is_array($subscription_id) && count($subscription_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $subscription_id when calling enableSubscription');
        Severity: Minor
        Found in src/Commerce/Notification/V1/Api/SubscriptionApi.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function createSubscriptionRequest has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

            public function createSubscriptionRequest($create_subscription_request = null)
    {
        $resourcePath = '/subscription';
        $formParams = [];
        $queryParams = [];
        Severity: Minor
        Found in src/Commerce/Notification/V1/Api/SubscriptionApi.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getSubscriptionsRequest has 71 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getSubscriptionsRequest($limit = null, $continuation_token = null)
    {
        $resourcePath = '/subscription';
        $formParams = [];
        $queryParams = [];
        Severity: Major
        Found in src/Commerce/Notification/V1/Api/SubscriptionApi.php - About 2 hrs to fix

          Method disableSubscriptionRequest has 67 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function disableSubscriptionRequest($subscription_id)
    {
        // Verify the required parameter 'subscription_id' is set.
        if ($subscription_id === null || (\is_array($subscription_id) && count($subscription_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $subscription_id when calling disableSubscription');
          Severity: Major
          Found in src/Commerce/Notification/V1/Api/SubscriptionApi.php - About 2 hrs to fix

            Method getSubscriptionRequest has 67 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function getSubscriptionRequest($subscription_id)
    {
        // Verify the required parameter 'subscription_id' is set.
        if ($subscription_id === null || (\is_array($subscription_id) && count($subscription_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $subscription_id when calling getSubscription');
            Severity: Major
            Found in src/Commerce/Notification/V1/Api/SubscriptionApi.php - About 2 hrs to fix

              Method testRequest has 67 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function testRequest($subscription_id)
    {
        // Verify the required parameter 'subscription_id' is set.
        if ($subscription_id === null || (\is_array($subscription_id) && count($subscription_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $subscription_id when calling test');
              Severity: Major
              Found in src/Commerce/Notification/V1/Api/SubscriptionApi.php - About 2 hrs to fix

                Method enableSubscriptionRequest has 67 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function enableSubscriptionRequest($subscription_id)
    {
        // Verify the required parameter 'subscription_id' is set.
        if ($subscription_id === null || (\is_array($subscription_id) && count($subscription_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $subscription_id when calling enableSubscription');
                Severity: Major
                Found in src/Commerce/Notification/V1/Api/SubscriptionApi.php - About 2 hrs to fix

                  Method deleteSubscriptionRequest has 67 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function deleteSubscriptionRequest($subscription_id)
    {
        // Verify the required parameter 'subscription_id' is set.
        if ($subscription_id === null || (\is_array($subscription_id) && count($subscription_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $subscription_id when calling deleteSubscription');
                  Severity: Major
                  Found in src/Commerce/Notification/V1/Api/SubscriptionApi.php - About 2 hrs to fix

                    Method createSubscriptionRequest has 63 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function createSubscriptionRequest($create_subscription_request = null)
    {
        $resourcePath = '/subscription';
        $formParams = [];
        $queryParams = [];
                    Severity: Major
                    Found in src/Commerce/Notification/V1/Api/SubscriptionApi.php - About 2 hrs to fix

                      Function getSubscriptionsRequest has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function getSubscriptionsRequest($limit = null, $continuation_token = null)
    {
        $resourcePath = '/subscription';
        $formParams = [];
        $queryParams = [];
                      Severity: Minor
                      Found in src/Commerce/Notification/V1/Api/SubscriptionApi.php - About 2 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method createSubscriptionWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function createSubscriptionWithHttpInfo($create_subscription_request = null)
    {
        $request = $this->createSubscriptionRequest($create_subscription_request);

        try {
                      Severity: Major
                      Found in src/Commerce/Notification/V1/Api/SubscriptionApi.php - About 2 hrs to fix

                        Method getSubscriptionsWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function getSubscriptionsWithHttpInfo($limit = null, $continuation_token = null)
    {
        $request = $this->getSubscriptionsRequest($limit, $continuation_token);

        try {
                        Severity: Major
                        Found in src/Commerce/Notification/V1/Api/SubscriptionApi.php - About 2 hrs to fix

                          Method getSubscriptionWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function getSubscriptionWithHttpInfo($subscription_id)
    {
        $request = $this->getSubscriptionRequest($subscription_id);

        try {
                          Severity: Major
                          Found in src/Commerce/Notification/V1/Api/SubscriptionApi.php - About 2 hrs to fix

                            Function getSubscriptionWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function getSubscriptionWithHttpInfo($subscription_id)
    {
        $request = $this->getSubscriptionRequest($subscription_id);

        try {
                            Severity: Minor
                            Found in src/Commerce/Notification/V1/Api/SubscriptionApi.php - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function createSubscriptionWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function createSubscriptionWithHttpInfo($create_subscription_request = null)
    {
        $request = $this->createSubscriptionRequest($create_subscription_request);

        try {
                            Severity: Minor
                            Found in src/Commerce/Notification/V1/Api/SubscriptionApi.php - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function getSubscriptionsWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function getSubscriptionsWithHttpInfo($limit = null, $continuation_token = null)
    {
        $request = $this->getSubscriptionsRequest($limit, $continuation_token);

        try {
                            Severity: Minor
                            Found in src/Commerce/Notification/V1/Api/SubscriptionApi.php - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function disableSubscriptionWithHttpInfo has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function disableSubscriptionWithHttpInfo($subscription_id)
    {
        $request = $this->disableSubscriptionRequest($subscription_id);

        try {
                            Severity: Minor
                            Found in src/Commerce/Notification/V1/Api/SubscriptionApi.php - About 35 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function updateSubscriptionWithHttpInfo has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function updateSubscriptionWithHttpInfo($subscription_id, $update_subscription_request = null)
    {
        $request = $this->updateSubscriptionRequest($subscription_id, $update_subscription_request);

        try {
                            Severity: Minor
                            Found in src/Commerce/Notification/V1/Api/SubscriptionApi.php - About 35 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function enableSubscriptionWithHttpInfo has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function enableSubscriptionWithHttpInfo($subscription_id)
    {
        $request = $this->enableSubscriptionRequest($subscription_id);

        try {
                            Severity: Minor
                            Found in src/Commerce/Notification/V1/Api/SubscriptionApi.php - About 35 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function testWithHttpInfo has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function testWithHttpInfo($subscription_id)
    {
        $request = $this->testRequest($subscription_id);

        try {
                            Severity: Minor
                            Found in src/Commerce/Notification/V1/Api/SubscriptionApi.php - About 35 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function deleteSubscriptionWithHttpInfo has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function deleteSubscriptionWithHttpInfo($subscription_id)
    {
        $request = $this->deleteSubscriptionRequest($subscription_id);

        try {
                            Severity: Minor
                            Found in src/Commerce/Notification/V1/Api/SubscriptionApi.php - About 35 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                public function updateSubscriptionRequest($subscription_id, $update_subscription_request = null)
    {
        // Verify the required parameter 'subscription_id' is set.
        if ($subscription_id === null || (\is_array($subscription_id) && count($subscription_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $subscription_id when calling updateSubscription');
                            Severity: Major
                            Found in src/Commerce/Notification/V1/Api/SubscriptionApi.php and 1 other location - About 2 days to fix
                            src/Commerce/Notification/V1/Api/DestinationApi.php on lines 1224..1317

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 570.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status