File CategoryTreeApi.php
has 1430 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* This file is part of the trollandtoad/ebay-sdk-php package.
*
CategoryTreeApi
has 45 functions (exceeds 20 allowed). Consider refactoring. Open
class CategoryTreeApi
{
/**
* @var ClientInterface
*/
Function getCompatibilityPropertyValuesRequest
has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring. Open
public function getCompatibilityPropertyValuesRequest($category_tree_id, $compatibility_property, $category_id, $filter = null)
{
// Verify the required parameter 'category_tree_id' is set.
if ($category_tree_id === null || (\is_array($category_tree_id) && count($category_tree_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $category_tree_id when calling getCompatibilityPropertyValues');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getCompatibilityPropertyValuesRequest
has 91 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getCompatibilityPropertyValuesRequest($category_tree_id, $compatibility_property, $category_id, $filter = null)
{
// Verify the required parameter 'category_tree_id' is set.
if ($category_tree_id === null || (\is_array($category_tree_id) && count($category_tree_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $category_tree_id when calling getCompatibilityPropertyValues');
Function getCompatibilityPropertiesRequest
has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring. Open
public function getCompatibilityPropertiesRequest($category_tree_id, $category_id)
{
// Verify the required parameter 'category_tree_id' is set.
if ($category_tree_id === null || (\is_array($category_tree_id) && count($category_tree_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $category_tree_id when calling getCompatibilityProperties');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getCategorySuggestionsRequest
has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring. Open
public function getCategorySuggestionsRequest($category_tree_id, $q)
{
// Verify the required parameter 'category_tree_id' is set.
if ($category_tree_id === null || (\is_array($category_tree_id) && count($category_tree_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $category_tree_id when calling getCategorySuggestions');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getItemAspectsForCategoryRequest
has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring. Open
public function getItemAspectsForCategoryRequest($category_id, $category_tree_id)
{
// Verify the required parameter 'category_id' is set.
if ($category_id === null || (\is_array($category_id) && count($category_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $category_id when calling getItemAspectsForCategory');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getCategorySubtreeRequest
has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring. Open
public function getCategorySubtreeRequest($category_id, $category_tree_id)
{
// Verify the required parameter 'category_id' is set.
if ($category_id === null || (\is_array($category_id) && count($category_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $category_id when calling getCategorySubtree');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getCategorySubtreeRequest
has 74 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getCategorySubtreeRequest($category_id, $category_tree_id)
{
// Verify the required parameter 'category_id' is set.
if ($category_id === null || (\is_array($category_id) && count($category_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $category_id when calling getCategorySubtree');
Method getCategorySuggestionsRequest
has 74 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getCategorySuggestionsRequest($category_tree_id, $q)
{
// Verify the required parameter 'category_tree_id' is set.
if ($category_tree_id === null || (\is_array($category_tree_id) && count($category_tree_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $category_tree_id when calling getCategorySuggestions');
Method getCompatibilityPropertiesRequest
has 74 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getCompatibilityPropertiesRequest($category_tree_id, $category_id)
{
// Verify the required parameter 'category_tree_id' is set.
if ($category_tree_id === null || (\is_array($category_tree_id) && count($category_tree_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $category_tree_id when calling getCompatibilityProperties');
Method getItemAspectsForCategoryRequest
has 74 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getItemAspectsForCategoryRequest($category_id, $category_tree_id)
{
// Verify the required parameter 'category_id' is set.
if ($category_id === null || (\is_array($category_id) && count($category_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $category_id when calling getItemAspectsForCategory');
Function getDefaultCategoryTreeIdRequest
has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring. Open
public function getDefaultCategoryTreeIdRequest($marketplace_id, $accept_language = null)
{
// Verify the required parameter 'marketplace_id' is set.
if ($marketplace_id === null || (\is_array($marketplace_id) && count($marketplace_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $marketplace_id when calling getDefaultCategoryTreeId');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getCategoryTreeRequest
has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring. Open
public function getCategoryTreeRequest($category_tree_id)
{
// Verify the required parameter 'category_tree_id' is set.
if ($category_tree_id === null || (\is_array($category_tree_id) && count($category_tree_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $category_tree_id when calling getCategoryTree');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function fetchItemAspectsRequest
has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring. Open
public function fetchItemAspectsRequest($category_tree_id)
{
// Verify the required parameter 'category_tree_id' is set.
if ($category_tree_id === null || (\is_array($category_tree_id) && count($category_tree_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $category_tree_id when calling fetchItemAspects');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getDefaultCategoryTreeIdRequest
has 67 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getDefaultCategoryTreeIdRequest($marketplace_id, $accept_language = null)
{
// Verify the required parameter 'marketplace_id' is set.
if ($marketplace_id === null || (\is_array($marketplace_id) && count($marketplace_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $marketplace_id when calling getDefaultCategoryTreeId');
Method getCategoryTreeRequest
has 64 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getCategoryTreeRequest($category_tree_id)
{
// Verify the required parameter 'category_tree_id' is set.
if ($category_tree_id === null || (\is_array($category_tree_id) && count($category_tree_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $category_tree_id when calling getCategoryTree');
Method fetchItemAspectsRequest
has 64 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function fetchItemAspectsRequest($category_tree_id)
{
// Verify the required parameter 'category_tree_id' is set.
if ($category_tree_id === null || (\is_array($category_tree_id) && count($category_tree_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $category_tree_id when calling fetchItemAspects');
Method getDefaultCategoryTreeIdWithHttpInfo
has 53 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getDefaultCategoryTreeIdWithHttpInfo($marketplace_id, $accept_language = null)
{
$request = $this->getDefaultCategoryTreeIdRequest($marketplace_id, $accept_language);
try {
Method fetchItemAspectsWithHttpInfo
has 53 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function fetchItemAspectsWithHttpInfo($category_tree_id)
{
$request = $this->fetchItemAspectsRequest($category_tree_id);
try {
Method getCategorySuggestionsWithHttpInfo
has 53 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getCategorySuggestionsWithHttpInfo($category_tree_id, $q)
{
$request = $this->getCategorySuggestionsRequest($category_tree_id, $q);
try {
Method getCategorySubtreeWithHttpInfo
has 53 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getCategorySubtreeWithHttpInfo($category_id, $category_tree_id)
{
$request = $this->getCategorySubtreeRequest($category_id, $category_tree_id);
try {
Method getCompatibilityPropertyValuesWithHttpInfo
has 53 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getCompatibilityPropertyValuesWithHttpInfo($category_tree_id, $compatibility_property, $category_id, $filter = null)
{
$request = $this->getCompatibilityPropertyValuesRequest($category_tree_id, $compatibility_property, $category_id, $filter);
try {
Method getCategoryTreeWithHttpInfo
has 53 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getCategoryTreeWithHttpInfo($category_tree_id)
{
$request = $this->getCategoryTreeRequest($category_tree_id);
try {
Method getItemAspectsForCategoryWithHttpInfo
has 53 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getItemAspectsForCategoryWithHttpInfo($category_id, $category_tree_id)
{
$request = $this->getItemAspectsForCategoryRequest($category_id, $category_tree_id);
try {
Method getCompatibilityPropertiesWithHttpInfo
has 53 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getCompatibilityPropertiesWithHttpInfo($category_tree_id, $category_id)
{
$request = $this->getCompatibilityPropertiesRequest($category_tree_id, $category_id);
try {
Function getDefaultCategoryTreeIdWithHttpInfo
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
public function getDefaultCategoryTreeIdWithHttpInfo($marketplace_id, $accept_language = null)
{
$request = $this->getDefaultCategoryTreeIdRequest($marketplace_id, $accept_language);
try {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getItemAspectsForCategoryWithHttpInfo
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
public function getItemAspectsForCategoryWithHttpInfo($category_id, $category_tree_id)
{
$request = $this->getItemAspectsForCategoryRequest($category_id, $category_tree_id);
try {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getCompatibilityPropertyValuesWithHttpInfo
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
public function getCompatibilityPropertyValuesWithHttpInfo($category_tree_id, $compatibility_property, $category_id, $filter = null)
{
$request = $this->getCompatibilityPropertyValuesRequest($category_tree_id, $compatibility_property, $category_id, $filter);
try {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function fetchItemAspectsWithHttpInfo
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
public function fetchItemAspectsWithHttpInfo($category_tree_id)
{
$request = $this->fetchItemAspectsRequest($category_tree_id);
try {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getCategorySubtreeWithHttpInfo
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
public function getCategorySubtreeWithHttpInfo($category_id, $category_tree_id)
{
$request = $this->getCategorySubtreeRequest($category_id, $category_tree_id);
try {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getCompatibilityPropertiesWithHttpInfo
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
public function getCompatibilityPropertiesWithHttpInfo($category_tree_id, $category_id)
{
$request = $this->getCompatibilityPropertiesRequest($category_tree_id, $category_id);
try {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getCategoryTreeWithHttpInfo
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
public function getCategoryTreeWithHttpInfo($category_tree_id)
{
$request = $this->getCategoryTreeRequest($category_tree_id);
try {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getCategorySuggestionsWithHttpInfo
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
public function getCategorySuggestionsWithHttpInfo($category_tree_id, $q)
{
$request = $this->getCategorySuggestionsRequest($category_tree_id, $q);
try {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Similar blocks of code found in 4 locations. Consider refactoring. Open
public function getCategorySubtreeRequest($category_id, $category_tree_id)
{
// Verify the required parameter 'category_id' is set.
if ($category_id === null || (\is_array($category_id) && count($category_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $category_id when calling getCategorySubtree');
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 576.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 4 locations. Consider refactoring. Open
public function getCategorySuggestionsRequest($category_tree_id, $q)
{
// Verify the required parameter 'category_tree_id' is set.
if ($category_tree_id === null || (\is_array($category_tree_id) && count($category_tree_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $category_tree_id when calling getCategorySuggestions');
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 576.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 4 locations. Consider refactoring. Open
public function getCompatibilityPropertiesRequest($category_tree_id, $category_id)
{
// Verify the required parameter 'category_tree_id' is set.
if ($category_tree_id === null || (\is_array($category_tree_id) && count($category_tree_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $category_tree_id when calling getCompatibilityProperties');
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 576.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 4 locations. Consider refactoring. Open
public function getItemAspectsForCategoryRequest($category_id, $category_tree_id)
{
// Verify the required parameter 'category_id' is set.
if ($category_id === null || (\is_array($category_id) && count($category_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $category_id when calling getItemAspectsForCategory');
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 576.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76