Sign upLogin

brandon14/ebay-sdk-php

View on GitHub
Star
src/Developer/KeyManagement/V1/Api/SigningKeyApi.php

Summary

Maintainability
F
1 wk
Test Coverage

File SigningKeyApi.php has 531 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * This file is part of the trollandtoad/ebay-sdk-php package.
 *
Severity: Major
Found in src/Developer/KeyManagement/V1/Api/SigningKeyApi.php - About 1 day to fix

    Function getSigningKeyRequest has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getSigningKeyRequest($signing_key_id)
    {
        // Verify the required parameter 'signing_key_id' is set.
        if ($signing_key_id === null || (\is_array($signing_key_id) && count($signing_key_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $signing_key_id when calling getSigningKey');
    Severity: Minor
    Found in src/Developer/KeyManagement/V1/Api/SigningKeyApi.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function createSigningKeyRequest has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

        public function createSigningKeyRequest($create_signing_key_request = null)
    {
        $resourcePath = '/signing_key';
        $formParams = [];
        $queryParams = [];
    Severity: Minor
    Found in src/Developer/KeyManagement/V1/Api/SigningKeyApi.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getSigningKeyRequest has 64 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getSigningKeyRequest($signing_key_id)
    {
        // Verify the required parameter 'signing_key_id' is set.
        if ($signing_key_id === null || (\is_array($signing_key_id) && count($signing_key_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $signing_key_id when calling getSigningKey');
    Severity: Major
    Found in src/Developer/KeyManagement/V1/Api/SigningKeyApi.php - About 2 hrs to fix

      Method createSigningKeyRequest has 60 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function createSigningKeyRequest($create_signing_key_request = null)
    {
        $resourcePath = '/signing_key';
        $formParams = [];
        $queryParams = [];
      Severity: Major
      Found in src/Developer/KeyManagement/V1/Api/SigningKeyApi.php - About 2 hrs to fix

        Method getSigningKeysRequest has 54 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getSigningKeysRequest()
    {
        $resourcePath = '/signing_key';
        $formParams = [];
        $queryParams = [];
        Severity: Major
        Found in src/Developer/KeyManagement/V1/Api/SigningKeyApi.php - About 2 hrs to fix

          Method createSigningKeyWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function createSigningKeyWithHttpInfo($create_signing_key_request = null)
    {
        $request = $this->createSigningKeyRequest($create_signing_key_request);

        try {
          Severity: Major
          Found in src/Developer/KeyManagement/V1/Api/SigningKeyApi.php - About 2 hrs to fix

            Method getSigningKeysWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function getSigningKeysWithHttpInfo()
    {
        $request = $this->getSigningKeysRequest();

        try {
            Severity: Major
            Found in src/Developer/KeyManagement/V1/Api/SigningKeyApi.php - About 2 hrs to fix

              Method getSigningKeyWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function getSigningKeyWithHttpInfo($signing_key_id)
    {
        $request = $this->getSigningKeyRequest($signing_key_id);

        try {
              Severity: Major
              Found in src/Developer/KeyManagement/V1/Api/SigningKeyApi.php - About 2 hrs to fix

                Function getSigningKeysRequest has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function getSigningKeysRequest()
    {
        $resourcePath = '/signing_key';
        $formParams = [];
        $queryParams = [];
                Severity: Minor
                Found in src/Developer/KeyManagement/V1/Api/SigningKeyApi.php - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function getSigningKeysWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function getSigningKeysWithHttpInfo()
    {
        $request = $this->getSigningKeysRequest();

        try {
                Severity: Minor
                Found in src/Developer/KeyManagement/V1/Api/SigningKeyApi.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function createSigningKeyWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function createSigningKeyWithHttpInfo($create_signing_key_request = null)
    {
        $request = $this->createSigningKeyRequest($create_signing_key_request);

        try {
                Severity: Minor
                Found in src/Developer/KeyManagement/V1/Api/SigningKeyApi.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function getSigningKeyWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function getSigningKeyWithHttpInfo($signing_key_id)
    {
        $request = $this->getSigningKeyRequest($signing_key_id);

        try {
                Severity: Minor
                Found in src/Developer/KeyManagement/V1/Api/SigningKeyApi.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function createSigningKeyRequest($create_signing_key_request = null)
    {
        $resourcePath = '/signing_key';
        $formParams = [];
        $queryParams = [];
                Severity: Major
                Found in src/Developer/KeyManagement/V1/Api/SigningKeyApi.php and 1 other location - About 2 days to fix
                src/Sell/Inventory/V1/Api/OfferApi.php on lines 1255..1330

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 451.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    public function getSigningKeysRequest()
    {
        $resourcePath = '/signing_key';
        $formParams = [];
        $queryParams = [];
                Severity: Major
                Found in src/Developer/KeyManagement/V1/Api/SigningKeyApi.php and 2 other locations - About 1 day to fix
                src/Buy/Feed/V1/Api/AccessApi.php on lines 303..372
                src/Sell/Analytics/V1/Api/SellerStandardsProfileApi.php on lines 303..372

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 389.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status