Sign upLogin

brandon14/ebay-sdk-php

View on GitHub
Star
src/Sell/Account/V1/Api/FulfillmentPolicyApi.php

Summary

Maintainability
F
2 mos
Test Coverage

File FulfillmentPolicyApi.php has 1029 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * This file is part of the trollandtoad/ebay-sdk-php package.
 *
Severity: Major
Found in src/Sell/Account/V1/Api/FulfillmentPolicyApi.php - About 2 days to fix

    FulfillmentPolicyApi has 35 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class FulfillmentPolicyApi
{
    /**
     * @var ClientInterface
     */
    Severity: Minor
    Found in src/Sell/Account/V1/Api/FulfillmentPolicyApi.php - About 4 hrs to fix

      Function updateFulfillmentPolicyRequest has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
      Open

          public function updateFulfillmentPolicyRequest($fulfillment_policy_id, $fulfillment_policy_request)
    {
        // Verify the required parameter 'fulfillment_policy_id' is set.
        if ($fulfillment_policy_id === null || (\is_array($fulfillment_policy_id) && count($fulfillment_policy_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $fulfillment_policy_id when calling updateFulfillmentPolicy');
      Severity: Minor
      Found in src/Sell/Account/V1/Api/FulfillmentPolicyApi.php - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function createFulfillmentPolicyRequest has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
      Open

          public function createFulfillmentPolicyRequest($fulfillment_policy_request)
    {
        // Verify the required parameter 'fulfillment_policy_request' is set.
        if ($fulfillment_policy_request === null || (\is_array($fulfillment_policy_request) && count($fulfillment_policy_request) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $fulfillment_policy_request when calling createFulfillmentPolicy');
      Severity: Minor
      Found in src/Sell/Account/V1/Api/FulfillmentPolicyApi.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getFulfillmentPolicyByNameRequest has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getFulfillmentPolicyByNameRequest($marketplace_id, $name)
    {
        // Verify the required parameter 'marketplace_id' is set.
        if ($marketplace_id === null || (\is_array($marketplace_id) && count($marketplace_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $marketplace_id when calling getFulfillmentPolicyByName');
      Severity: Minor
      Found in src/Sell/Account/V1/Api/FulfillmentPolicyApi.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getFulfillmentPolicyByNameRequest has 77 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getFulfillmentPolicyByNameRequest($marketplace_id, $name)
    {
        // Verify the required parameter 'marketplace_id' is set.
        if ($marketplace_id === null || (\is_array($marketplace_id) && count($marketplace_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $marketplace_id when calling getFulfillmentPolicyByName');
      Severity: Major
      Found in src/Sell/Account/V1/Api/FulfillmentPolicyApi.php - About 3 hrs to fix

        Method updateFulfillmentPolicyRequest has 76 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function updateFulfillmentPolicyRequest($fulfillment_policy_id, $fulfillment_policy_request)
    {
        // Verify the required parameter 'fulfillment_policy_id' is set.
        if ($fulfillment_policy_id === null || (\is_array($fulfillment_policy_id) && count($fulfillment_policy_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $fulfillment_policy_id when calling updateFulfillmentPolicy');
        Severity: Major
        Found in src/Sell/Account/V1/Api/FulfillmentPolicyApi.php - About 3 hrs to fix

          Function getFulfillmentPolicyRequest has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getFulfillmentPolicyRequest($fulfillment_policy_id)
    {
        // Verify the required parameter 'fulfillment_policy_id' is set.
        if ($fulfillment_policy_id === null || (\is_array($fulfillment_policy_id) && count($fulfillment_policy_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $fulfillment_policy_id when calling getFulfillmentPolicy');
          Severity: Minor
          Found in src/Sell/Account/V1/Api/FulfillmentPolicyApi.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function deleteFulfillmentPolicyRequest has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
          Open

              public function deleteFulfillmentPolicyRequest($fulfillment_policy_id)
    {
        // Verify the required parameter 'fulfillment_policy_id' is set.
        if ($fulfillment_policy_id === null || (\is_array($fulfillment_policy_id) && count($fulfillment_policy_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $fulfillment_policy_id when calling deleteFulfillmentPolicy');
          Severity: Minor
          Found in src/Sell/Account/V1/Api/FulfillmentPolicyApi.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getFulfillmentPoliciesRequest has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getFulfillmentPoliciesRequest($marketplace_id)
    {
        // Verify the required parameter 'marketplace_id' is set.
        if ($marketplace_id === null || (\is_array($marketplace_id) && count($marketplace_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $marketplace_id when calling getFulfillmentPolicies');
          Severity: Minor
          Found in src/Sell/Account/V1/Api/FulfillmentPolicyApi.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method deleteFulfillmentPolicyRequest has 67 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function deleteFulfillmentPolicyRequest($fulfillment_policy_id)
    {
        // Verify the required parameter 'fulfillment_policy_id' is set.
        if ($fulfillment_policy_id === null || (\is_array($fulfillment_policy_id) && count($fulfillment_policy_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $fulfillment_policy_id when calling deleteFulfillmentPolicy');
          Severity: Major
          Found in src/Sell/Account/V1/Api/FulfillmentPolicyApi.php - About 2 hrs to fix

            Method getFulfillmentPolicyRequest has 67 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function getFulfillmentPolicyRequest($fulfillment_policy_id)
    {
        // Verify the required parameter 'fulfillment_policy_id' is set.
        if ($fulfillment_policy_id === null || (\is_array($fulfillment_policy_id) && count($fulfillment_policy_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $fulfillment_policy_id when calling getFulfillmentPolicy');
            Severity: Major
            Found in src/Sell/Account/V1/Api/FulfillmentPolicyApi.php - About 2 hrs to fix

              Method getFulfillmentPoliciesRequest has 67 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function getFulfillmentPoliciesRequest($marketplace_id)
    {
        // Verify the required parameter 'marketplace_id' is set.
        if ($marketplace_id === null || (\is_array($marketplace_id) && count($marketplace_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $marketplace_id when calling getFulfillmentPolicies');
              Severity: Major
              Found in src/Sell/Account/V1/Api/FulfillmentPolicyApi.php - About 2 hrs to fix

                Method createFulfillmentPolicyRequest has 66 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function createFulfillmentPolicyRequest($fulfillment_policy_request)
    {
        // Verify the required parameter 'fulfillment_policy_request' is set.
        if ($fulfillment_policy_request === null || (\is_array($fulfillment_policy_request) && count($fulfillment_policy_request) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $fulfillment_policy_request when calling createFulfillmentPolicy');
                Severity: Major
                Found in src/Sell/Account/V1/Api/FulfillmentPolicyApi.php - About 2 hrs to fix

                  Method createFulfillmentPolicyWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function createFulfillmentPolicyWithHttpInfo($fulfillment_policy_request)
    {
        $request = $this->createFulfillmentPolicyRequest($fulfillment_policy_request);

        try {
                  Severity: Major
                  Found in src/Sell/Account/V1/Api/FulfillmentPolicyApi.php - About 2 hrs to fix

                    Method getFulfillmentPoliciesWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function getFulfillmentPoliciesWithHttpInfo($marketplace_id)
    {
        $request = $this->getFulfillmentPoliciesRequest($marketplace_id);

        try {
                    Severity: Major
                    Found in src/Sell/Account/V1/Api/FulfillmentPolicyApi.php - About 2 hrs to fix

                      Method updateFulfillmentPolicyWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function updateFulfillmentPolicyWithHttpInfo($fulfillment_policy_id, $fulfillment_policy_request)
    {
        $request = $this->updateFulfillmentPolicyRequest($fulfillment_policy_id, $fulfillment_policy_request);

        try {
                      Severity: Major
                      Found in src/Sell/Account/V1/Api/FulfillmentPolicyApi.php - About 2 hrs to fix

                        Method getFulfillmentPolicyByNameWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function getFulfillmentPolicyByNameWithHttpInfo($marketplace_id, $name)
    {
        $request = $this->getFulfillmentPolicyByNameRequest($marketplace_id, $name);

        try {
                        Severity: Major
                        Found in src/Sell/Account/V1/Api/FulfillmentPolicyApi.php - About 2 hrs to fix

                          Method getFulfillmentPolicyWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function getFulfillmentPolicyWithHttpInfo($fulfillment_policy_id)
    {
        $request = $this->getFulfillmentPolicyRequest($fulfillment_policy_id);

        try {
                          Severity: Major
                          Found in src/Sell/Account/V1/Api/FulfillmentPolicyApi.php - About 2 hrs to fix

                            Function getFulfillmentPoliciesWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function getFulfillmentPoliciesWithHttpInfo($marketplace_id)
    {
        $request = $this->getFulfillmentPoliciesRequest($marketplace_id);

        try {
                            Severity: Minor
                            Found in src/Sell/Account/V1/Api/FulfillmentPolicyApi.php - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function createFulfillmentPolicyWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function createFulfillmentPolicyWithHttpInfo($fulfillment_policy_request)
    {
        $request = $this->createFulfillmentPolicyRequest($fulfillment_policy_request);

        try {
                            Severity: Minor
                            Found in src/Sell/Account/V1/Api/FulfillmentPolicyApi.php - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function updateFulfillmentPolicyWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function updateFulfillmentPolicyWithHttpInfo($fulfillment_policy_id, $fulfillment_policy_request)
    {
        $request = $this->updateFulfillmentPolicyRequest($fulfillment_policy_id, $fulfillment_policy_request);

        try {
                            Severity: Minor
                            Found in src/Sell/Account/V1/Api/FulfillmentPolicyApi.php - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function getFulfillmentPolicyWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function getFulfillmentPolicyWithHttpInfo($fulfillment_policy_id)
    {
        $request = $this->getFulfillmentPolicyRequest($fulfillment_policy_id);

        try {
                            Severity: Minor
                            Found in src/Sell/Account/V1/Api/FulfillmentPolicyApi.php - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function getFulfillmentPolicyByNameWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function getFulfillmentPolicyByNameWithHttpInfo($marketplace_id, $name)
    {
        $request = $this->getFulfillmentPolicyByNameRequest($marketplace_id, $name);

        try {
                            Severity: Minor
                            Found in src/Sell/Account/V1/Api/FulfillmentPolicyApi.php - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function deleteFulfillmentPolicyWithHttpInfo has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function deleteFulfillmentPolicyWithHttpInfo($fulfillment_policy_id)
    {
        $request = $this->deleteFulfillmentPolicyRequest($fulfillment_policy_id);

        try {
                            Severity: Minor
                            Found in src/Sell/Account/V1/Api/FulfillmentPolicyApi.php - About 35 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                            <?php

/**
 * This file is part of the trollandtoad/ebay-sdk-php package.
 *
                            Severity: Major
                            Found in src/Sell/Account/V1/Api/FulfillmentPolicyApi.php and 2 other locations - About 1 mo to fix
                            src/Sell/Account/V1/Api/PaymentPolicyApi.php on lines 1..1655
                            src/Sell/Account/V1/Api/ReturnPolicyApi.php on lines 1..1655

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 8246.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status