Sign upLogin

brandon14/ebay-sdk-php

View on GitHub
Star
src/Sell/Account/V1/Api/PaymentPolicyApi.php

Summary

Maintainability
F
2 mos
Test Coverage

File PaymentPolicyApi.php has 1029 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * This file is part of the trollandtoad/ebay-sdk-php package.
 *
Severity: Major
Found in src/Sell/Account/V1/Api/PaymentPolicyApi.php - About 2 days to fix

    PaymentPolicyApi has 35 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class PaymentPolicyApi
{
    /**
     * @var ClientInterface
     */
    Severity: Minor
    Found in src/Sell/Account/V1/Api/PaymentPolicyApi.php - About 4 hrs to fix

      Function updatePaymentPolicyRequest has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
      Open

          public function updatePaymentPolicyRequest($payment_policy_id, $payment_policy_request)
    {
        // Verify the required parameter 'payment_policy_id' is set.
        if ($payment_policy_id === null || (\is_array($payment_policy_id) && count($payment_policy_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $payment_policy_id when calling updatePaymentPolicy');
      Severity: Minor
      Found in src/Sell/Account/V1/Api/PaymentPolicyApi.php - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function createPaymentPolicyRequest has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
      Open

          public function createPaymentPolicyRequest($payment_policy_request)
    {
        // Verify the required parameter 'payment_policy_request' is set.
        if ($payment_policy_request === null || (\is_array($payment_policy_request) && count($payment_policy_request) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $payment_policy_request when calling createPaymentPolicy');
      Severity: Minor
      Found in src/Sell/Account/V1/Api/PaymentPolicyApi.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getPaymentPolicyByNameRequest has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getPaymentPolicyByNameRequest($marketplace_id, $name)
    {
        // Verify the required parameter 'marketplace_id' is set.
        if ($marketplace_id === null || (\is_array($marketplace_id) && count($marketplace_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $marketplace_id when calling getPaymentPolicyByName');
      Severity: Minor
      Found in src/Sell/Account/V1/Api/PaymentPolicyApi.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getPaymentPolicyByNameRequest has 77 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getPaymentPolicyByNameRequest($marketplace_id, $name)
    {
        // Verify the required parameter 'marketplace_id' is set.
        if ($marketplace_id === null || (\is_array($marketplace_id) && count($marketplace_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $marketplace_id when calling getPaymentPolicyByName');
      Severity: Major
      Found in src/Sell/Account/V1/Api/PaymentPolicyApi.php - About 3 hrs to fix

        Method updatePaymentPolicyRequest has 76 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function updatePaymentPolicyRequest($payment_policy_id, $payment_policy_request)
    {
        // Verify the required parameter 'payment_policy_id' is set.
        if ($payment_policy_id === null || (\is_array($payment_policy_id) && count($payment_policy_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $payment_policy_id when calling updatePaymentPolicy');
        Severity: Major
        Found in src/Sell/Account/V1/Api/PaymentPolicyApi.php - About 3 hrs to fix

          Function deletePaymentPolicyRequest has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
          Open

              public function deletePaymentPolicyRequest($payment_policy_id)
    {
        // Verify the required parameter 'payment_policy_id' is set.
        if ($payment_policy_id === null || (\is_array($payment_policy_id) && count($payment_policy_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $payment_policy_id when calling deletePaymentPolicy');
          Severity: Minor
          Found in src/Sell/Account/V1/Api/PaymentPolicyApi.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getPaymentPolicyRequest has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getPaymentPolicyRequest($payment_policy_id)
    {
        // Verify the required parameter 'payment_policy_id' is set.
        if ($payment_policy_id === null || (\is_array($payment_policy_id) && count($payment_policy_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $payment_policy_id when calling getPaymentPolicy');
          Severity: Minor
          Found in src/Sell/Account/V1/Api/PaymentPolicyApi.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getPaymentPoliciesRequest has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getPaymentPoliciesRequest($marketplace_id)
    {
        // Verify the required parameter 'marketplace_id' is set.
        if ($marketplace_id === null || (\is_array($marketplace_id) && count($marketplace_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $marketplace_id when calling getPaymentPolicies');
          Severity: Minor
          Found in src/Sell/Account/V1/Api/PaymentPolicyApi.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method deletePaymentPolicyRequest has 67 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function deletePaymentPolicyRequest($payment_policy_id)
    {
        // Verify the required parameter 'payment_policy_id' is set.
        if ($payment_policy_id === null || (\is_array($payment_policy_id) && count($payment_policy_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $payment_policy_id when calling deletePaymentPolicy');
          Severity: Major
          Found in src/Sell/Account/V1/Api/PaymentPolicyApi.php - About 2 hrs to fix

            Method getPaymentPoliciesRequest has 67 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function getPaymentPoliciesRequest($marketplace_id)
    {
        // Verify the required parameter 'marketplace_id' is set.
        if ($marketplace_id === null || (\is_array($marketplace_id) && count($marketplace_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $marketplace_id when calling getPaymentPolicies');
            Severity: Major
            Found in src/Sell/Account/V1/Api/PaymentPolicyApi.php - About 2 hrs to fix

              Method getPaymentPolicyRequest has 67 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function getPaymentPolicyRequest($payment_policy_id)
    {
        // Verify the required parameter 'payment_policy_id' is set.
        if ($payment_policy_id === null || (\is_array($payment_policy_id) && count($payment_policy_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $payment_policy_id when calling getPaymentPolicy');
              Severity: Major
              Found in src/Sell/Account/V1/Api/PaymentPolicyApi.php - About 2 hrs to fix

                Method createPaymentPolicyRequest has 66 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function createPaymentPolicyRequest($payment_policy_request)
    {
        // Verify the required parameter 'payment_policy_request' is set.
        if ($payment_policy_request === null || (\is_array($payment_policy_request) && count($payment_policy_request) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $payment_policy_request when calling createPaymentPolicy');
                Severity: Major
                Found in src/Sell/Account/V1/Api/PaymentPolicyApi.php - About 2 hrs to fix

                  Method updatePaymentPolicyWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function updatePaymentPolicyWithHttpInfo($payment_policy_id, $payment_policy_request)
    {
        $request = $this->updatePaymentPolicyRequest($payment_policy_id, $payment_policy_request);

        try {
                  Severity: Major
                  Found in src/Sell/Account/V1/Api/PaymentPolicyApi.php - About 2 hrs to fix

                    Method getPaymentPolicyByNameWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function getPaymentPolicyByNameWithHttpInfo($marketplace_id, $name)
    {
        $request = $this->getPaymentPolicyByNameRequest($marketplace_id, $name);

        try {
                    Severity: Major
                    Found in src/Sell/Account/V1/Api/PaymentPolicyApi.php - About 2 hrs to fix

                      Method getPaymentPoliciesWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function getPaymentPoliciesWithHttpInfo($marketplace_id)
    {
        $request = $this->getPaymentPoliciesRequest($marketplace_id);

        try {
                      Severity: Major
                      Found in src/Sell/Account/V1/Api/PaymentPolicyApi.php - About 2 hrs to fix

                        Method createPaymentPolicyWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function createPaymentPolicyWithHttpInfo($payment_policy_request)
    {
        $request = $this->createPaymentPolicyRequest($payment_policy_request);

        try {
                        Severity: Major
                        Found in src/Sell/Account/V1/Api/PaymentPolicyApi.php - About 2 hrs to fix

                          Method getPaymentPolicyWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function getPaymentPolicyWithHttpInfo($payment_policy_id)
    {
        $request = $this->getPaymentPolicyRequest($payment_policy_id);

        try {
                          Severity: Major
                          Found in src/Sell/Account/V1/Api/PaymentPolicyApi.php - About 2 hrs to fix

                            Function getPaymentPoliciesWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function getPaymentPoliciesWithHttpInfo($marketplace_id)
    {
        $request = $this->getPaymentPoliciesRequest($marketplace_id);

        try {
                            Severity: Minor
                            Found in src/Sell/Account/V1/Api/PaymentPolicyApi.php - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function getPaymentPolicyWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function getPaymentPolicyWithHttpInfo($payment_policy_id)
    {
        $request = $this->getPaymentPolicyRequest($payment_policy_id);

        try {
                            Severity: Minor
                            Found in src/Sell/Account/V1/Api/PaymentPolicyApi.php - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function createPaymentPolicyWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function createPaymentPolicyWithHttpInfo($payment_policy_request)
    {
        $request = $this->createPaymentPolicyRequest($payment_policy_request);

        try {
                            Severity: Minor
                            Found in src/Sell/Account/V1/Api/PaymentPolicyApi.php - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function getPaymentPolicyByNameWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function getPaymentPolicyByNameWithHttpInfo($marketplace_id, $name)
    {
        $request = $this->getPaymentPolicyByNameRequest($marketplace_id, $name);

        try {
                            Severity: Minor
                            Found in src/Sell/Account/V1/Api/PaymentPolicyApi.php - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function updatePaymentPolicyWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function updatePaymentPolicyWithHttpInfo($payment_policy_id, $payment_policy_request)
    {
        $request = $this->updatePaymentPolicyRequest($payment_policy_id, $payment_policy_request);

        try {
                            Severity: Minor
                            Found in src/Sell/Account/V1/Api/PaymentPolicyApi.php - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function deletePaymentPolicyWithHttpInfo has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function deletePaymentPolicyWithHttpInfo($payment_policy_id)
    {
        $request = $this->deletePaymentPolicyRequest($payment_policy_id);

        try {
                            Severity: Minor
                            Found in src/Sell/Account/V1/Api/PaymentPolicyApi.php - About 35 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                            <?php

/**
 * This file is part of the trollandtoad/ebay-sdk-php package.
 *
                            Severity: Major
                            Found in src/Sell/Account/V1/Api/PaymentPolicyApi.php and 2 other locations - About 1 mo to fix
                            src/Sell/Account/V1/Api/FulfillmentPolicyApi.php on lines 1..1655
                            src/Sell/Account/V1/Api/ReturnPolicyApi.php on lines 1..1655

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 8246.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status