Sign upLogin

brandon14/ebay-sdk-php

View on GitHub
Star
src/Sell/Account/V1/Api/ReturnPolicyApi.php

Summary

Maintainability
F
2 mos
Test Coverage

File ReturnPolicyApi.php has 1029 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * This file is part of the trollandtoad/ebay-sdk-php package.
 *
Severity: Major
Found in src/Sell/Account/V1/Api/ReturnPolicyApi.php - About 2 days to fix

    ReturnPolicyApi has 35 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class ReturnPolicyApi
{
    /**
     * @var ClientInterface
     */
    Severity: Minor
    Found in src/Sell/Account/V1/Api/ReturnPolicyApi.php - About 4 hrs to fix

      Function updateReturnPolicyRequest has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
      Open

          public function updateReturnPolicyRequest($return_policy_id, $return_policy_request)
    {
        // Verify the required parameter 'return_policy_id' is set.
        if ($return_policy_id === null || (\is_array($return_policy_id) && count($return_policy_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $return_policy_id when calling updateReturnPolicy');
      Severity: Minor
      Found in src/Sell/Account/V1/Api/ReturnPolicyApi.php - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function createReturnPolicyRequest has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
      Open

          public function createReturnPolicyRequest($return_policy_request)
    {
        // Verify the required parameter 'return_policy_request' is set.
        if ($return_policy_request === null || (\is_array($return_policy_request) && count($return_policy_request) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $return_policy_request when calling createReturnPolicy');
      Severity: Minor
      Found in src/Sell/Account/V1/Api/ReturnPolicyApi.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getReturnPolicyByNameRequest has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getReturnPolicyByNameRequest($marketplace_id, $name)
    {
        // Verify the required parameter 'marketplace_id' is set.
        if ($marketplace_id === null || (\is_array($marketplace_id) && count($marketplace_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $marketplace_id when calling getReturnPolicyByName');
      Severity: Minor
      Found in src/Sell/Account/V1/Api/ReturnPolicyApi.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getReturnPolicyByNameRequest has 77 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getReturnPolicyByNameRequest($marketplace_id, $name)
    {
        // Verify the required parameter 'marketplace_id' is set.
        if ($marketplace_id === null || (\is_array($marketplace_id) && count($marketplace_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $marketplace_id when calling getReturnPolicyByName');
      Severity: Major
      Found in src/Sell/Account/V1/Api/ReturnPolicyApi.php - About 3 hrs to fix

        Method updateReturnPolicyRequest has 76 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function updateReturnPolicyRequest($return_policy_id, $return_policy_request)
    {
        // Verify the required parameter 'return_policy_id' is set.
        if ($return_policy_id === null || (\is_array($return_policy_id) && count($return_policy_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $return_policy_id when calling updateReturnPolicy');
        Severity: Major
        Found in src/Sell/Account/V1/Api/ReturnPolicyApi.php - About 3 hrs to fix

          Function getReturnPolicyRequest has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getReturnPolicyRequest($return_policy_id)
    {
        // Verify the required parameter 'return_policy_id' is set.
        if ($return_policy_id === null || (\is_array($return_policy_id) && count($return_policy_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $return_policy_id when calling getReturnPolicy');
          Severity: Minor
          Found in src/Sell/Account/V1/Api/ReturnPolicyApi.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function deleteReturnPolicyRequest has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
          Open

              public function deleteReturnPolicyRequest($return_policy_id)
    {
        // Verify the required parameter 'return_policy_id' is set.
        if ($return_policy_id === null || (\is_array($return_policy_id) && count($return_policy_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $return_policy_id when calling deleteReturnPolicy');
          Severity: Minor
          Found in src/Sell/Account/V1/Api/ReturnPolicyApi.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getReturnPoliciesRequest has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getReturnPoliciesRequest($marketplace_id)
    {
        // Verify the required parameter 'marketplace_id' is set.
        if ($marketplace_id === null || (\is_array($marketplace_id) && count($marketplace_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $marketplace_id when calling getReturnPolicies');
          Severity: Minor
          Found in src/Sell/Account/V1/Api/ReturnPolicyApi.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method deleteReturnPolicyRequest has 67 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function deleteReturnPolicyRequest($return_policy_id)
    {
        // Verify the required parameter 'return_policy_id' is set.
        if ($return_policy_id === null || (\is_array($return_policy_id) && count($return_policy_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $return_policy_id when calling deleteReturnPolicy');
          Severity: Major
          Found in src/Sell/Account/V1/Api/ReturnPolicyApi.php - About 2 hrs to fix

            Method getReturnPolicyRequest has 67 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function getReturnPolicyRequest($return_policy_id)
    {
        // Verify the required parameter 'return_policy_id' is set.
        if ($return_policy_id === null || (\is_array($return_policy_id) && count($return_policy_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $return_policy_id when calling getReturnPolicy');
            Severity: Major
            Found in src/Sell/Account/V1/Api/ReturnPolicyApi.php - About 2 hrs to fix

              Method getReturnPoliciesRequest has 67 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function getReturnPoliciesRequest($marketplace_id)
    {
        // Verify the required parameter 'marketplace_id' is set.
        if ($marketplace_id === null || (\is_array($marketplace_id) && count($marketplace_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $marketplace_id when calling getReturnPolicies');
              Severity: Major
              Found in src/Sell/Account/V1/Api/ReturnPolicyApi.php - About 2 hrs to fix

                Method createReturnPolicyRequest has 66 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function createReturnPolicyRequest($return_policy_request)
    {
        // Verify the required parameter 'return_policy_request' is set.
        if ($return_policy_request === null || (\is_array($return_policy_request) && count($return_policy_request) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $return_policy_request when calling createReturnPolicy');
                Severity: Major
                Found in src/Sell/Account/V1/Api/ReturnPolicyApi.php - About 2 hrs to fix

                  Method getReturnPoliciesWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function getReturnPoliciesWithHttpInfo($marketplace_id)
    {
        $request = $this->getReturnPoliciesRequest($marketplace_id);

        try {
                  Severity: Major
                  Found in src/Sell/Account/V1/Api/ReturnPolicyApi.php - About 2 hrs to fix

                    Method getReturnPolicyByNameWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function getReturnPolicyByNameWithHttpInfo($marketplace_id, $name)
    {
        $request = $this->getReturnPolicyByNameRequest($marketplace_id, $name);

        try {
                    Severity: Major
                    Found in src/Sell/Account/V1/Api/ReturnPolicyApi.php - About 2 hrs to fix

                      Method updateReturnPolicyWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function updateReturnPolicyWithHttpInfo($return_policy_id, $return_policy_request)
    {
        $request = $this->updateReturnPolicyRequest($return_policy_id, $return_policy_request);

        try {
                      Severity: Major
                      Found in src/Sell/Account/V1/Api/ReturnPolicyApi.php - About 2 hrs to fix

                        Method getReturnPolicyWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function getReturnPolicyWithHttpInfo($return_policy_id)
    {
        $request = $this->getReturnPolicyRequest($return_policy_id);

        try {
                        Severity: Major
                        Found in src/Sell/Account/V1/Api/ReturnPolicyApi.php - About 2 hrs to fix

                          Method createReturnPolicyWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function createReturnPolicyWithHttpInfo($return_policy_request)
    {
        $request = $this->createReturnPolicyRequest($return_policy_request);

        try {
                          Severity: Major
                          Found in src/Sell/Account/V1/Api/ReturnPolicyApi.php - About 2 hrs to fix

                            Function getReturnPolicyWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function getReturnPolicyWithHttpInfo($return_policy_id)
    {
        $request = $this->getReturnPolicyRequest($return_policy_id);

        try {
                            Severity: Minor
                            Found in src/Sell/Account/V1/Api/ReturnPolicyApi.php - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function createReturnPolicyWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function createReturnPolicyWithHttpInfo($return_policy_request)
    {
        $request = $this->createReturnPolicyRequest($return_policy_request);

        try {
                            Severity: Minor
                            Found in src/Sell/Account/V1/Api/ReturnPolicyApi.php - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function getReturnPolicyByNameWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function getReturnPolicyByNameWithHttpInfo($marketplace_id, $name)
    {
        $request = $this->getReturnPolicyByNameRequest($marketplace_id, $name);

        try {
                            Severity: Minor
                            Found in src/Sell/Account/V1/Api/ReturnPolicyApi.php - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function getReturnPoliciesWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function getReturnPoliciesWithHttpInfo($marketplace_id)
    {
        $request = $this->getReturnPoliciesRequest($marketplace_id);

        try {
                            Severity: Minor
                            Found in src/Sell/Account/V1/Api/ReturnPolicyApi.php - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function updateReturnPolicyWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function updateReturnPolicyWithHttpInfo($return_policy_id, $return_policy_request)
    {
        $request = $this->updateReturnPolicyRequest($return_policy_id, $return_policy_request);

        try {
                            Severity: Minor
                            Found in src/Sell/Account/V1/Api/ReturnPolicyApi.php - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function deleteReturnPolicyWithHttpInfo has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function deleteReturnPolicyWithHttpInfo($return_policy_id)
    {
        $request = $this->deleteReturnPolicyRequest($return_policy_id);

        try {
                            Severity: Minor
                            Found in src/Sell/Account/V1/Api/ReturnPolicyApi.php - About 35 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                            <?php

/**
 * This file is part of the trollandtoad/ebay-sdk-php package.
 *
                            Severity: Major
                            Found in src/Sell/Account/V1/Api/ReturnPolicyApi.php and 2 other locations - About 1 mo to fix
                            src/Sell/Account/V1/Api/FulfillmentPolicyApi.php on lines 1..1655
                            src/Sell/Account/V1/Api/PaymentPolicyApi.php on lines 1..1655

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 8246.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status