Sign upLogin

brandon14/ebay-sdk-php

View on GitHub
Star
src/Sell/Account/V1/Api/SalesTaxApi.php

Summary

Maintainability
F
2 wks
Test Coverage

File SalesTaxApi.php has 677 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * This file is part of the trollandtoad/ebay-sdk-php package.
 *
Severity: Major
Found in src/Sell/Account/V1/Api/SalesTaxApi.php - About 1 day to fix

    Function createOrReplaceSalesTaxRequest has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
    Open

        public function createOrReplaceSalesTaxRequest($country_code, $jurisdiction_id, $sales_tax_base)
    {
        // Verify the required parameter 'country_code' is set.
        if ($country_code === null || (\is_array($country_code) && count($country_code) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $country_code when calling createOrReplaceSalesTax');
    Severity: Minor
    Found in src/Sell/Account/V1/Api/SalesTaxApi.php - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function deleteSalesTaxRequest has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

        public function deleteSalesTaxRequest($country_code, $jurisdiction_id)
    {
        // Verify the required parameter 'country_code' is set.
        if ($country_code === null || (\is_array($country_code) && count($country_code) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $country_code when calling deleteSalesTax');
    Severity: Minor
    Found in src/Sell/Account/V1/Api/SalesTaxApi.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getSalesTaxRequest has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getSalesTaxRequest($country_code, $jurisdiction_id)
    {
        // Verify the required parameter 'country_code' is set.
        if ($country_code === null || (\is_array($country_code) && count($country_code) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $country_code when calling getSalesTax');
    Severity: Minor
    Found in src/Sell/Account/V1/Api/SalesTaxApi.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method createOrReplaceSalesTaxRequest has 86 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function createOrReplaceSalesTaxRequest($country_code, $jurisdiction_id, $sales_tax_base)
    {
        // Verify the required parameter 'country_code' is set.
        if ($country_code === null || (\is_array($country_code) && count($country_code) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $country_code when calling createOrReplaceSalesTax');
    Severity: Major
    Found in src/Sell/Account/V1/Api/SalesTaxApi.php - About 3 hrs to fix

      Method getSalesTaxRequest has 77 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getSalesTaxRequest($country_code, $jurisdiction_id)
    {
        // Verify the required parameter 'country_code' is set.
        if ($country_code === null || (\is_array($country_code) && count($country_code) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $country_code when calling getSalesTax');
      Severity: Major
      Found in src/Sell/Account/V1/Api/SalesTaxApi.php - About 3 hrs to fix

        Method deleteSalesTaxRequest has 77 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function deleteSalesTaxRequest($country_code, $jurisdiction_id)
    {
        // Verify the required parameter 'country_code' is set.
        if ($country_code === null || (\is_array($country_code) && count($country_code) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $country_code when calling deleteSalesTax');
        Severity: Major
        Found in src/Sell/Account/V1/Api/SalesTaxApi.php - About 3 hrs to fix

          SalesTaxApi has 25 functions (exceeds 20 allowed). Consider refactoring.
          Open

          class SalesTaxApi
{
    /**
     * @var ClientInterface
     */
          Severity: Minor
          Found in src/Sell/Account/V1/Api/SalesTaxApi.php - About 2 hrs to fix

            Function getSalesTaxesRequest has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getSalesTaxesRequest($country_code)
    {
        // Verify the required parameter 'country_code' is set.
        if ($country_code === null || (\is_array($country_code) && count($country_code) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $country_code when calling getSalesTaxes');
            Severity: Minor
            Found in src/Sell/Account/V1/Api/SalesTaxApi.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method getSalesTaxesRequest has 67 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function getSalesTaxesRequest($country_code)
    {
        // Verify the required parameter 'country_code' is set.
        if ($country_code === null || (\is_array($country_code) && count($country_code) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $country_code when calling getSalesTaxes');
            Severity: Major
            Found in src/Sell/Account/V1/Api/SalesTaxApi.php - About 2 hrs to fix

              Method getSalesTaxWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function getSalesTaxWithHttpInfo($country_code, $jurisdiction_id)
    {
        $request = $this->getSalesTaxRequest($country_code, $jurisdiction_id);

        try {
              Severity: Major
              Found in src/Sell/Account/V1/Api/SalesTaxApi.php - About 2 hrs to fix

                Method getSalesTaxesWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function getSalesTaxesWithHttpInfo($country_code)
    {
        $request = $this->getSalesTaxesRequest($country_code);

        try {
                Severity: Major
                Found in src/Sell/Account/V1/Api/SalesTaxApi.php - About 2 hrs to fix

                  Function getSalesTaxWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function getSalesTaxWithHttpInfo($country_code, $jurisdiction_id)
    {
        $request = $this->getSalesTaxRequest($country_code, $jurisdiction_id);

        try {
                  Severity: Minor
                  Found in src/Sell/Account/V1/Api/SalesTaxApi.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function getSalesTaxesWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function getSalesTaxesWithHttpInfo($country_code)
    {
        $request = $this->getSalesTaxesRequest($country_code);

        try {
                  Severity: Minor
                  Found in src/Sell/Account/V1/Api/SalesTaxApi.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function deleteSalesTaxWithHttpInfo has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function deleteSalesTaxWithHttpInfo($country_code, $jurisdiction_id)
    {
        $request = $this->deleteSalesTaxRequest($country_code, $jurisdiction_id);

        try {
                  Severity: Minor
                  Found in src/Sell/Account/V1/Api/SalesTaxApi.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function createOrReplaceSalesTaxWithHttpInfo has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function createOrReplaceSalesTaxWithHttpInfo($country_code, $jurisdiction_id, $sales_tax_base)
    {
        $request = $this->createOrReplaceSalesTaxRequest($country_code, $jurisdiction_id, $sales_tax_base);

        try {
                  Severity: Minor
                  Found in src/Sell/Account/V1/Api/SalesTaxApi.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                      public function createOrReplaceSalesTaxRequest($country_code, $jurisdiction_id, $sales_tax_base)
    {
        // Verify the required parameter 'country_code' is set.
        if ($country_code === null || (\is_array($country_code) && count($country_code) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $country_code when calling createOrReplaceSalesTax');
                  Severity: Major
                  Found in src/Sell/Account/V1/Api/SalesTaxApi.php and 3 other locations - About 3 days to fix
                  src/Sell/Marketing/V1/Api/AdApi.php on lines 4279..4388
                  src/Sell/Marketing/V1/Api/AdGroupApi.php on lines 1658..1767
                  src/Sell/Marketing/V1/Api/KeywordApi.php on lines 1641..1750

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 704.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function deleteSalesTaxRequest($country_code, $jurisdiction_id)
    {
        // Verify the required parameter 'country_code' is set.
        if ($country_code === null || (\is_array($country_code) && count($country_code) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $country_code when calling deleteSalesTax');
                  Severity: Major
                  Found in src/Sell/Account/V1/Api/SalesTaxApi.php and 1 other location - About 3 days to fix
                  src/Sell/Marketing/V1/Api/AdApi.php on lines 2921..3020

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 599.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 5 locations. Consider refactoring.
                  Open

                      public function createOrReplaceSalesTaxWithHttpInfo($country_code, $jurisdiction_id, $sales_tax_base)
    {
        $request = $this->createOrReplaceSalesTaxRequest($country_code, $jurisdiction_id, $sales_tax_base);

        try {
                  Severity: Major
                  Found in src/Sell/Account/V1/Api/SalesTaxApi.php and 4 other locations - About 1 day to fix
                  src/Sell/Account/V1/Api/CustomPolicyApi.php on lines 966..996
                  src/Sell/Marketing/V1/Api/AdApi.php on lines 4184..4214
                  src/Sell/Marketing/V1/Api/AdGroupApi.php on lines 1563..1593
                  src/Sell/Marketing/V1/Api/KeywordApi.php on lines 1546..1576

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 362.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 12 locations. Consider refactoring.
                  Open

                      public function deleteSalesTaxWithHttpInfo($country_code, $jurisdiction_id)
    {
        $request = $this->deleteSalesTaxRequest($country_code, $jurisdiction_id);

        try {
                  Severity: Major
                  Found in src/Sell/Account/V1/Api/SalesTaxApi.php and 11 other locations - About 1 day to fix
                  src/Sell/Account/V1/Api/LocationApi.php on lines 185..215
                  src/Sell/Account/V1/Api/LocationApi.php on lines 1746..1776
                  src/Sell/Feed/V1/Api/CustomerServiceMetricTaskApi.php on lines 179..209
                  src/Sell/Feed/V1/Api/ScheduleApi.php on lines 1903..1933
                  src/Sell/Inventory/V1/Api/LocationApi.php on lines 179..209
                  src/Sell/Inventory/V1/Api/LocationApi.php on lines 1584..1614
                  src/Sell/Marketing/V1/Api/AdApi.php on lines 2829..2859
                  src/Sell/Marketing/V1/Api/CampaignApi.php on lines 2887..2917
                  src/Sell/Marketing/V1/Api/CampaignApi.php on lines 3105..3135
                  src/Sell/Marketing/V1/Api/CampaignApi.php on lines 3323..3353
                  src/Sell/Marketing/V1/Api/NegativeKeywordApi.php on lines 1467..1497

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 355.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 5 locations. Consider refactoring.
                  Open

                      public function createOrReplaceSalesTaxAsyncWithHttpInfo($country_code, $jurisdiction_id, $sales_tax_base)
    {
        $returnType = '';
        $request = $this->createOrReplaceSalesTaxRequest($country_code, $jurisdiction_id, $sales_tax_base);
                  Severity: Major
                  Found in src/Sell/Account/V1/Api/SalesTaxApi.php and 4 other locations - About 5 hrs to fix
                  src/Sell/Account/V1/Api/CustomPolicyApi.php on lines 1030..1048
                  src/Sell/Marketing/V1/Api/AdApi.php on lines 4248..4266
                  src/Sell/Marketing/V1/Api/AdGroupApi.php on lines 1627..1645
                  src/Sell/Marketing/V1/Api/KeywordApi.php on lines 1610..1628

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 189.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 12 locations. Consider refactoring.
                  Open

                      public function deleteSalesTaxAsyncWithHttpInfo($country_code, $jurisdiction_id)
    {
        $returnType = '';
        $request = $this->deleteSalesTaxRequest($country_code, $jurisdiction_id);
                  Severity: Major
                  Found in src/Sell/Account/V1/Api/SalesTaxApi.php and 11 other locations - About 4 hrs to fix
                  src/Sell/Account/V1/Api/LocationApi.php on lines 253..271
                  src/Sell/Account/V1/Api/LocationApi.php on lines 1814..1832
                  src/Sell/Feed/V1/Api/CustomerServiceMetricTaskApi.php on lines 241..259
                  src/Sell/Feed/V1/Api/ScheduleApi.php on lines 1965..1983
                  src/Sell/Inventory/V1/Api/LocationApi.php on lines 241..259
                  src/Sell/Inventory/V1/Api/LocationApi.php on lines 1646..1664
                  src/Sell/Marketing/V1/Api/AdApi.php on lines 2891..2909
                  src/Sell/Marketing/V1/Api/CampaignApi.php on lines 2949..2967
                  src/Sell/Marketing/V1/Api/CampaignApi.php on lines 3167..3185
                  src/Sell/Marketing/V1/Api/CampaignApi.php on lines 3385..3403
                  src/Sell/Marketing/V1/Api/NegativeKeywordApi.php on lines 1529..1547

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 182.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status