Sign upLogin

brandon14/ebay-sdk-php

View on GitHub
Star
src/Sell/Analytics/V1/Api/CustomerServiceMetricApi.php

Summary

Maintainability
F
4 days
Test Coverage

Function getCustomerServiceMetricRequest has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

    public function getCustomerServiceMetricRequest($customer_service_metric_type, $evaluation_marketplace_id, $evaluation_type)
    {
        // Verify the required parameter 'customer_service_metric_type' is set.
        if ($customer_service_metric_type === null || (\is_array($customer_service_metric_type) && count($customer_service_metric_type) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $customer_service_metric_type when calling getCustomerServiceMetric');
Severity: Minor
Found in src/Sell/Analytics/V1/Api/CustomerServiceMetricApi.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getCustomerServiceMetricRequest has 84 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getCustomerServiceMetricRequest($customer_service_metric_type, $evaluation_marketplace_id, $evaluation_type)
    {
        // Verify the required parameter 'customer_service_metric_type' is set.
        if ($customer_service_metric_type === null || (\is_array($customer_service_metric_type) && count($customer_service_metric_type) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $customer_service_metric_type when calling getCustomerServiceMetric');
Severity: Major
Found in src/Sell/Analytics/V1/Api/CustomerServiceMetricApi.php - About 3 hrs to fix

    Method getCustomerServiceMetricWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getCustomerServiceMetricWithHttpInfo($customer_service_metric_type, $evaluation_marketplace_id, $evaluation_type)
    {
        $request = $this->getCustomerServiceMetricRequest($customer_service_metric_type, $evaluation_marketplace_id, $evaluation_type);

        try {
    Severity: Major
    Found in src/Sell/Analytics/V1/Api/CustomerServiceMetricApi.php - About 2 hrs to fix

      Function getCustomerServiceMetricWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getCustomerServiceMetricWithHttpInfo($customer_service_metric_type, $evaluation_marketplace_id, $evaluation_type)
    {
        $request = $this->getCustomerServiceMetricRequest($customer_service_metric_type, $evaluation_marketplace_id, $evaluation_type);

        try {
      Severity: Minor
      Found in src/Sell/Analytics/V1/Api/CustomerServiceMetricApi.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

          public function getCustomerServiceMetricWithHttpInfo($customer_service_metric_type, $evaluation_marketplace_id, $evaluation_type)
    {
        $request = $this->getCustomerServiceMetricRequest($customer_service_metric_type, $evaluation_marketplace_id, $evaluation_type);

        try {
      Severity: Major
      Found in src/Sell/Analytics/V1/Api/CustomerServiceMetricApi.php and 4 other locations - About 2 days to fix
      src/Sell/Fulfillment/V1/Api/PaymentDisputeApi.php on lines 960..1025
      src/Sell/Inventory/V1/Api/OfferApi.php on lines 2391..2456
      src/Sell/Marketing/V1/Api/AdApi.php on lines 3901..3966
      src/Sell/Marketing/V1/Api/AdGroupApi.php on lines 1005..1070

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 534.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status