Sign upLogin

brandon14/ebay-sdk-php

View on GitHub
Star
src/Sell/Analytics/V1/Api/SellerStandardsProfileApi.php

Summary

Maintainability
F
1 wk
Test Coverage

File SellerStandardsProfileApi.php has 382 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * This file is part of the trollandtoad/ebay-sdk-php package.
 *
Severity: Minor
Found in src/Sell/Analytics/V1/Api/SellerStandardsProfileApi.php - About 5 hrs to fix

    Function getSellerStandardsProfileRequest has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getSellerStandardsProfileRequest($cycle, $program)
    {
        // Verify the required parameter 'cycle' is set.
        if ($cycle === null || (\is_array($cycle) && count($cycle) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $cycle when calling getSellerStandardsProfile');
    Severity: Minor
    Found in src/Sell/Analytics/V1/Api/SellerStandardsProfileApi.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getSellerStandardsProfileRequest has 74 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getSellerStandardsProfileRequest($cycle, $program)
    {
        // Verify the required parameter 'cycle' is set.
        if ($cycle === null || (\is_array($cycle) && count($cycle) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $cycle when calling getSellerStandardsProfile');
    Severity: Major
    Found in src/Sell/Analytics/V1/Api/SellerStandardsProfileApi.php - About 2 hrs to fix

      Method findSellerStandardsProfilesRequest has 54 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function findSellerStandardsProfilesRequest()
    {
        $resourcePath = '/seller_standards_profile';
        $formParams = [];
        $queryParams = [];
      Severity: Major
      Found in src/Sell/Analytics/V1/Api/SellerStandardsProfileApi.php - About 2 hrs to fix

        Method findSellerStandardsProfilesWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function findSellerStandardsProfilesWithHttpInfo()
    {
        $request = $this->findSellerStandardsProfilesRequest();

        try {
        Severity: Major
        Found in src/Sell/Analytics/V1/Api/SellerStandardsProfileApi.php - About 2 hrs to fix

          Method getSellerStandardsProfileWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getSellerStandardsProfileWithHttpInfo($cycle, $program)
    {
        $request = $this->getSellerStandardsProfileRequest($cycle, $program);

        try {
          Severity: Major
          Found in src/Sell/Analytics/V1/Api/SellerStandardsProfileApi.php - About 2 hrs to fix

            Function findSellerStandardsProfilesRequest has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
            Open

                public function findSellerStandardsProfilesRequest()
    {
        $resourcePath = '/seller_standards_profile';
        $formParams = [];
        $queryParams = [];
            Severity: Minor
            Found in src/Sell/Analytics/V1/Api/SellerStandardsProfileApi.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getSellerStandardsProfileWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getSellerStandardsProfileWithHttpInfo($cycle, $program)
    {
        $request = $this->getSellerStandardsProfileRequest($cycle, $program);

        try {
            Severity: Minor
            Found in src/Sell/Analytics/V1/Api/SellerStandardsProfileApi.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function findSellerStandardsProfilesWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

                public function findSellerStandardsProfilesWithHttpInfo()
    {
        $request = $this->findSellerStandardsProfilesRequest();

        try {
            Severity: Minor
            Found in src/Sell/Analytics/V1/Api/SellerStandardsProfileApi.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public function getSellerStandardsProfileRequest($cycle, $program)
    {
        // Verify the required parameter 'cycle' is set.
        if ($cycle === null || (\is_array($cycle) && count($cycle) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $cycle when calling getSellerStandardsProfile');
            Severity: Major
            Found in src/Sell/Analytics/V1/Api/SellerStandardsProfileApi.php and 1 other location - About 2 days to fix
            src/Sell/Fulfillment/V1/Api/ShippingFulfillmentApi.php on lines 579..674

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 571.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                public function findSellerStandardsProfilesRequest()
    {
        $resourcePath = '/seller_standards_profile';
        $formParams = [];
        $queryParams = [];
            Severity: Major
            Found in src/Sell/Analytics/V1/Api/SellerStandardsProfileApi.php and 2 other locations - About 1 day to fix
            src/Buy/Feed/V1/Api/AccessApi.php on lines 303..372
            src/Developer/KeyManagement/V1/Api/SigningKeyApi.php on lines 787..856

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 389.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status