Sign upLogin

brandon14/ebay-sdk-php

View on GitHub
Star
src/Sell/Compliance/V1/Api/ListingViolationApi.php

Summary

Maintainability
F
1 wk
Test Coverage

File ListingViolationApi.php has 371 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * This file is part of the trollandtoad/ebay-sdk-php package.
 *
Severity: Minor
Found in src/Sell/Compliance/V1/Api/ListingViolationApi.php - About 4 hrs to fix

    Method getListingViolationsRequest has 95 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getListingViolationsRequest($x_ebay_c_marketplace_id, $compliance_type = null, $offset = null, $listing_id = null, $limit = null, $filter = null)
    {
        // Verify the required parameter 'x_ebay_c_marketplace_id' is set.
        if ($x_ebay_c_marketplace_id === null || (\is_array($x_ebay_c_marketplace_id) && count($x_ebay_c_marketplace_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $x_ebay_c_marketplace_id when calling getListingViolations');
    Severity: Major
    Found in src/Sell/Compliance/V1/Api/ListingViolationApi.php - About 3 hrs to fix

      Function suppressViolationRequest has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

          public function suppressViolationRequest($suppress_violation_request)
    {
        // Verify the required parameter 'suppress_violation_request' is set.
        if ($suppress_violation_request === null || (\is_array($suppress_violation_request) && count($suppress_violation_request) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $suppress_violation_request when calling suppressViolation');
      Severity: Minor
      Found in src/Sell/Compliance/V1/Api/ListingViolationApi.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getListingViolationsRequest has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getListingViolationsRequest($x_ebay_c_marketplace_id, $compliance_type = null, $offset = null, $listing_id = null, $limit = null, $filter = null)
    {
        // Verify the required parameter 'x_ebay_c_marketplace_id' is set.
        if ($x_ebay_c_marketplace_id === null || (\is_array($x_ebay_c_marketplace_id) && count($x_ebay_c_marketplace_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $x_ebay_c_marketplace_id when calling getListingViolations');
      Severity: Minor
      Found in src/Sell/Compliance/V1/Api/ListingViolationApi.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method suppressViolationRequest has 63 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function suppressViolationRequest($suppress_violation_request)
    {
        // Verify the required parameter 'suppress_violation_request' is set.
        if ($suppress_violation_request === null || (\is_array($suppress_violation_request) && count($suppress_violation_request) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $suppress_violation_request when calling suppressViolation');
      Severity: Major
      Found in src/Sell/Compliance/V1/Api/ListingViolationApi.php - About 2 hrs to fix

        Method getListingViolationsWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getListingViolationsWithHttpInfo($x_ebay_c_marketplace_id, $compliance_type = null, $offset = null, $listing_id = null, $limit = null, $filter = null)
    {
        $request = $this->getListingViolationsRequest($x_ebay_c_marketplace_id, $compliance_type, $offset, $listing_id, $limit, $filter);

        try {
        Severity: Major
        Found in src/Sell/Compliance/V1/Api/ListingViolationApi.php - About 2 hrs to fix

          Function getListingViolationsWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getListingViolationsWithHttpInfo($x_ebay_c_marketplace_id, $compliance_type = null, $offset = null, $listing_id = null, $limit = null, $filter = null)
    {
        $request = $this->getListingViolationsRequest($x_ebay_c_marketplace_id, $compliance_type, $offset, $listing_id, $limit, $filter);

        try {
          Severity: Minor
          Found in src/Sell/Compliance/V1/Api/ListingViolationApi.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method getListingViolations has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function getListingViolations($x_ebay_c_marketplace_id, $compliance_type = null, $offset = null, $listing_id = null, $limit = null, $filter = null)
          Severity: Minor
          Found in src/Sell/Compliance/V1/Api/ListingViolationApi.php - About 45 mins to fix

            Method getListingViolationsRequest has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function getListingViolationsRequest($x_ebay_c_marketplace_id, $compliance_type = null, $offset = null, $listing_id = null, $limit = null, $filter = null)
            Severity: Minor
            Found in src/Sell/Compliance/V1/Api/ListingViolationApi.php - About 45 mins to fix

              Method getListingViolationsWithHttpInfo has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function getListingViolationsWithHttpInfo($x_ebay_c_marketplace_id, $compliance_type = null, $offset = null, $listing_id = null, $limit = null, $filter = null)
              Severity: Minor
              Found in src/Sell/Compliance/V1/Api/ListingViolationApi.php - About 45 mins to fix

                Method getListingViolationsAsyncWithHttpInfo has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public function getListingViolationsAsyncWithHttpInfo($x_ebay_c_marketplace_id, $compliance_type = null, $offset = null, $listing_id = null, $limit = null, $filter = null)
                Severity: Minor
                Found in src/Sell/Compliance/V1/Api/ListingViolationApi.php - About 45 mins to fix

                  Method getListingViolationsAsync has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      public function getListingViolationsAsync($x_ebay_c_marketplace_id, $compliance_type = null, $offset = null, $listing_id = null, $limit = null, $filter = null)
                  Severity: Minor
                  Found in src/Sell/Compliance/V1/Api/ListingViolationApi.php - About 45 mins to fix

                    Function suppressViolationWithHttpInfo has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function suppressViolationWithHttpInfo($suppress_violation_request)
    {
        $request = $this->suppressViolationRequest($suppress_violation_request);

        try {
                    Severity: Minor
                    Found in src/Sell/Compliance/V1/Api/ListingViolationApi.php - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        public function getListingViolationsRequest($x_ebay_c_marketplace_id, $compliance_type = null, $offset = null, $listing_id = null, $limit = null, $filter = null)
    {
        // Verify the required parameter 'x_ebay_c_marketplace_id' is set.
        if ($x_ebay_c_marketplace_id === null || (\is_array($x_ebay_c_marketplace_id) && count($x_ebay_c_marketplace_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $x_ebay_c_marketplace_id when calling getListingViolations');
                    Severity: Major
                    Found in src/Sell/Compliance/V1/Api/ListingViolationApi.php and 1 other location - About 3 days to fix
                    src/Buy/Deal/V1/Api/DealItemApi.php on lines 338..458

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 736.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 5 locations. Consider refactoring.
                    Open

                        public function getListingViolationsWithHttpInfo($x_ebay_c_marketplace_id, $compliance_type = null, $offset = null, $listing_id = null, $limit = null, $filter = null)
    {
        $request = $this->getListingViolationsRequest($x_ebay_c_marketplace_id, $compliance_type, $offset, $listing_id, $limit, $filter);

        try {
                    Severity: Major
                    Found in src/Sell/Compliance/V1/Api/ListingViolationApi.php and 4 other locations - About 3 days to fix
                    src/Buy/Deal/V1/Api/DealItemApi.php on lines 189..254
                    src/Sell/Marketing/V1/Api/AdApi.php on lines 3591..3656
                    src/Sell/Marketing/V1/Api/PromotionApi.php on lines 189..254
                    src/Sell/Marketing/V1/Api/PromotionReportApi.php on lines 189..254

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 580.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        public function suppressViolationRequest($suppress_violation_request)
    {
        // Verify the required parameter 'suppress_violation_request' is set.
        if ($suppress_violation_request === null || (\is_array($suppress_violation_request) && count($suppress_violation_request) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $suppress_violation_request when calling suppressViolation');
                    Severity: Major
                    Found in src/Sell/Compliance/V1/Api/ListingViolationApi.php and 1 other location - About 2 days to fix
                    src/Sell/Inventory/V1/Api/OfferApi.php on lines 2995..3075

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 488.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 5 locations. Consider refactoring.
                    Open

                        public function getListingViolationsAsyncWithHttpInfo($x_ebay_c_marketplace_id, $compliance_type = null, $offset = null, $listing_id = null, $limit = null, $filter = null)
    {
        $returnType = '\TNT\Ebay\Sell\Compliance\V1\Model\PagedComplianceViolationCollection';
        $request = $this->getListingViolationsRequest($x_ebay_c_marketplace_id, $compliance_type, $offset, $listing_id, $limit, $filter);
                    Severity: Major
                    Found in src/Sell/Compliance/V1/Api/ListingViolationApi.php and 4 other locations - About 1 day to fix
                    src/Buy/Deal/V1/Api/DealItemApi.php on lines 294..322
                    src/Sell/Marketing/V1/Api/AdApi.php on lines 3696..3724
                    src/Sell/Marketing/V1/Api/PromotionApi.php on lines 294..322
                    src/Sell/Marketing/V1/Api/PromotionReportApi.php on lines 294..322

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 284.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 5 locations. Consider refactoring.
                    Open

                        public function getListingViolationsAsync($x_ebay_c_marketplace_id, $compliance_type = null, $offset = null, $listing_id = null, $limit = null, $filter = null)
    {
        return $this->getListingViolationsAsyncWithHttpInfo($x_ebay_c_marketplace_id, $compliance_type, $offset, $listing_id, $limit, $filter)
            ->then(
                function ($response) {
                    Severity: Major
                    Found in src/Sell/Compliance/V1/Api/ListingViolationApi.php and 4 other locations - About 55 mins to fix
                    src/Buy/Deal/V1/Api/DealItemApi.php on lines 270..278
                    src/Sell/Marketing/V1/Api/AdApi.php on lines 3672..3680
                    src/Sell/Marketing/V1/Api/PromotionApi.php on lines 270..278
                    src/Sell/Marketing/V1/Api/PromotionReportApi.php on lines 270..278

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 98.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status