File OrderTaskApi.php
has 538 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* This file is part of the trollandtoad/ebay-sdk-php package.
*
Method getOrderTasksRequest
has 96 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getOrderTasksRequest($date_range = null, $feed_type = null, $limit = null, $look_back_days = null, $offset = null, $schedule_id = null)
{
$resourcePath = '/order_task';
$formParams = [];
$queryParams = [];
Function createOrderTaskRequest
has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring. Open
public function createOrderTaskRequest($create_order_task_request, $x_ebay_c_marketplace_id = null)
{
// Verify the required parameter 'create_order_task_request' is set.
if ($create_order_task_request === null || (\is_array($create_order_task_request) && count($create_order_task_request) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $create_order_task_request when calling createOrderTask');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getOrderTaskRequest
has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring. Open
public function getOrderTaskRequest($task_id)
{
// Verify the required parameter 'task_id' is set.
if ($task_id === null || (\is_array($task_id) && count($task_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $task_id when calling getOrderTask');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method createOrderTaskRequest
has 66 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function createOrderTaskRequest($create_order_task_request, $x_ebay_c_marketplace_id = null)
{
// Verify the required parameter 'create_order_task_request' is set.
if ($create_order_task_request === null || (\is_array($create_order_task_request) && count($create_order_task_request) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $create_order_task_request when calling createOrderTask');
Method getOrderTaskRequest
has 64 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getOrderTaskRequest($task_id)
{
// Verify the required parameter 'task_id' is set.
if ($task_id === null || (\is_array($task_id) && count($task_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $task_id when calling getOrderTask');
Method getOrderTasksWithHttpInfo
has 53 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getOrderTasksWithHttpInfo($date_range = null, $feed_type = null, $limit = null, $look_back_days = null, $offset = null, $schedule_id = null)
{
$request = $this->getOrderTasksRequest($date_range, $feed_type, $limit, $look_back_days, $offset, $schedule_id);
try {
Method getOrderTaskWithHttpInfo
has 53 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getOrderTaskWithHttpInfo($task_id)
{
$request = $this->getOrderTaskRequest($task_id);
try {
Function getOrderTasksRequest
has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
public function getOrderTasksRequest($date_range = null, $feed_type = null, $limit = null, $look_back_days = null, $offset = null, $schedule_id = null)
{
$resourcePath = '/order_task';
$formParams = [];
$queryParams = [];
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getOrderTaskWithHttpInfo
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
public function getOrderTaskWithHttpInfo($task_id)
{
$request = $this->getOrderTaskRequest($task_id);
try {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getOrderTasksWithHttpInfo
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
public function getOrderTasksWithHttpInfo($date_range = null, $feed_type = null, $limit = null, $look_back_days = null, $offset = null, $schedule_id = null)
{
$request = $this->getOrderTasksRequest($date_range, $feed_type, $limit, $look_back_days, $offset, $schedule_id);
try {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getOrderTasksRequest
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
public function getOrderTasksRequest($date_range = null, $feed_type = null, $limit = null, $look_back_days = null, $offset = null, $schedule_id = null)
Method getOrderTasksAsyncWithHttpInfo
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
public function getOrderTasksAsyncWithHttpInfo($date_range = null, $feed_type = null, $limit = null, $look_back_days = null, $offset = null, $schedule_id = null)
Method getOrderTasksWithHttpInfo
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
public function getOrderTasksWithHttpInfo($date_range = null, $feed_type = null, $limit = null, $look_back_days = null, $offset = null, $schedule_id = null)
Method getOrderTasksAsync
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
public function getOrderTasksAsync($date_range = null, $feed_type = null, $limit = null, $look_back_days = null, $offset = null, $schedule_id = null)
Method getOrderTasks
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
public function getOrderTasks($date_range = null, $feed_type = null, $limit = null, $look_back_days = null, $offset = null, $schedule_id = null)
Function createOrderTaskWithHttpInfo
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function createOrderTaskWithHttpInfo($create_order_task_request, $x_ebay_c_marketplace_id = null)
{
$request = $this->createOrderTaskRequest($create_order_task_request, $x_ebay_c_marketplace_id);
try {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Similar blocks of code found in 2 locations. Consider refactoring. Open
<?php
/**
* This file is part of the trollandtoad/ebay-sdk-php package.
*
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 4479.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76