Sign upLogin

brandon14/ebay-sdk-php

View on GitHub
Star
src/Sell/Finances/V1/Api/TransactionApi.php

Summary

Maintainability
F
1 wk
Test Coverage

File TransactionApi.php has 403 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * This file is part of the trollandtoad/ebay-sdk-php package.
 *
Severity: Minor
Found in src/Sell/Finances/V1/Api/TransactionApi.php - About 5 hrs to fix

    Method getTransactionsRequest has 85 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getTransactionsRequest($x_ebay_c_marketplace_id = null, $filter = null, $limit = null, $offset = null, $sort = null)
    {
        $resourcePath = '/transaction';
        $formParams = [];
        $queryParams = [];
    Severity: Major
    Found in src/Sell/Finances/V1/Api/TransactionApi.php - About 3 hrs to fix

      Method getTransactionSummaryRequest has 64 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getTransactionSummaryRequest($x_ebay_c_marketplace_id = null, $filter = null)
    {
        $resourcePath = '/transaction_summary';
        $formParams = [];
        $queryParams = [];
      Severity: Major
      Found in src/Sell/Finances/V1/Api/TransactionApi.php - About 2 hrs to fix

        Function getTransactionSummaryRequest has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getTransactionSummaryRequest($x_ebay_c_marketplace_id = null, $filter = null)
    {
        $resourcePath = '/transaction_summary';
        $formParams = [];
        $queryParams = [];
        Severity: Minor
        Found in src/Sell/Finances/V1/Api/TransactionApi.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getTransactionsRequest has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getTransactionsRequest($x_ebay_c_marketplace_id = null, $filter = null, $limit = null, $offset = null, $sort = null)
    {
        $resourcePath = '/transaction';
        $formParams = [];
        $queryParams = [];
        Severity: Minor
        Found in src/Sell/Finances/V1/Api/TransactionApi.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getTransactionsWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getTransactionsWithHttpInfo($x_ebay_c_marketplace_id = null, $filter = null, $limit = null, $offset = null, $sort = null)
    {
        $request = $this->getTransactionsRequest($x_ebay_c_marketplace_id, $filter, $limit, $offset, $sort);

        try {
        Severity: Major
        Found in src/Sell/Finances/V1/Api/TransactionApi.php - About 2 hrs to fix

          Method getTransactionSummaryWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getTransactionSummaryWithHttpInfo($x_ebay_c_marketplace_id = null, $filter = null)
    {
        $request = $this->getTransactionSummaryRequest($x_ebay_c_marketplace_id, $filter);

        try {
          Severity: Major
          Found in src/Sell/Finances/V1/Api/TransactionApi.php - About 2 hrs to fix

            Function getTransactionSummaryWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getTransactionSummaryWithHttpInfo($x_ebay_c_marketplace_id = null, $filter = null)
    {
        $request = $this->getTransactionSummaryRequest($x_ebay_c_marketplace_id, $filter);

        try {
            Severity: Minor
            Found in src/Sell/Finances/V1/Api/TransactionApi.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getTransactionsWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getTransactionsWithHttpInfo($x_ebay_c_marketplace_id = null, $filter = null, $limit = null, $offset = null, $sort = null)
    {
        $request = $this->getTransactionsRequest($x_ebay_c_marketplace_id, $filter, $limit, $offset, $sort);

        try {
            Severity: Minor
            Found in src/Sell/Finances/V1/Api/TransactionApi.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method getTransactions has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function getTransactions($x_ebay_c_marketplace_id = null, $filter = null, $limit = null, $offset = null, $sort = null)
            Severity: Minor
            Found in src/Sell/Finances/V1/Api/TransactionApi.php - About 35 mins to fix

              Method getTransactionsWithHttpInfo has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function getTransactionsWithHttpInfo($x_ebay_c_marketplace_id = null, $filter = null, $limit = null, $offset = null, $sort = null)
              Severity: Minor
              Found in src/Sell/Finances/V1/Api/TransactionApi.php - About 35 mins to fix

                Method getTransactionsRequest has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public function getTransactionsRequest($x_ebay_c_marketplace_id = null, $filter = null, $limit = null, $offset = null, $sort = null)
                Severity: Minor
                Found in src/Sell/Finances/V1/Api/TransactionApi.php - About 35 mins to fix

                  Method getTransactionsAsync has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      public function getTransactionsAsync($x_ebay_c_marketplace_id = null, $filter = null, $limit = null, $offset = null, $sort = null)
                  Severity: Minor
                  Found in src/Sell/Finances/V1/Api/TransactionApi.php - About 35 mins to fix

                    Method getTransactionsAsyncWithHttpInfo has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public function getTransactionsAsyncWithHttpInfo($x_ebay_c_marketplace_id = null, $filter = null, $limit = null, $offset = null, $sort = null)
                    Severity: Minor
                    Found in src/Sell/Finances/V1/Api/TransactionApi.php - About 35 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          public function getTransactionsRequest($x_ebay_c_marketplace_id = null, $filter = null, $limit = null, $offset = null, $sort = null)
    {
        $resourcePath = '/transaction';
        $formParams = [];
        $queryParams = [];
                      Severity: Major
                      Found in src/Sell/Finances/V1/Api/TransactionApi.php and 1 other location - About 3 days to fix
                      src/Sell/Finances/V1/Api/PayoutApi.php on lines 840..947

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 640.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 6 locations. Consider refactoring.
                      Open

                          public function getTransactionsWithHttpInfo($x_ebay_c_marketplace_id = null, $filter = null, $limit = null, $offset = null, $sort = null)
    {
        $request = $this->getTransactionsRequest($x_ebay_c_marketplace_id, $filter, $limit, $offset, $sort);

        try {
                      Severity: Major
                      Found in src/Sell/Finances/V1/Api/TransactionApi.php and 5 other locations - About 2 days to fix
                      src/Sell/Feed/V1/Api/CustomerServiceMetricTaskApi.php on lines 643..708
                      src/Sell/Finances/V1/Api/PayoutApi.php on lines 694..759
                      src/Sell/Fulfillment/V1/Api/OrderApi.php on lines 447..512
                      src/Sell/Inventory/V1/Api/OfferApi.php on lines 1613..1678
                      src/Sell/Marketing/V1/Api/NegativeKeywordApi.php on lines 1178..1243

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 573.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                          public function getTransactionSummaryRequest($x_ebay_c_marketplace_id = null, $filter = null)
    {
        $resourcePath = '/transaction_summary';
        $formParams = [];
        $queryParams = [];
                      Severity: Major
                      Found in src/Sell/Finances/V1/Api/TransactionApi.php and 2 other locations - About 2 days to fix
                      src/Sell/Compliance/V1/Api/ListingViolationSummaryApi.php on lines 318..401
                      src/Sell/Finances/V1/Api/PayoutApi.php on lines 574..657

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 481.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 6 locations. Consider refactoring.
                      Open

                          public function getTransactionsAsyncWithHttpInfo($x_ebay_c_marketplace_id = null, $filter = null, $limit = null, $offset = null, $sort = null)
    {
        $returnType = '\TNT\Ebay\Sell\Finances\V1\Model\Transactions';
        $request = $this->getTransactionsRequest($x_ebay_c_marketplace_id, $filter, $limit, $offset, $sort);
                      Severity: Major
                      Found in src/Sell/Finances/V1/Api/TransactionApi.php and 5 other locations - About 1 day to fix
                      src/Sell/Feed/V1/Api/CustomerServiceMetricTaskApi.php on lines 746..774
                      src/Sell/Finances/V1/Api/PayoutApi.php on lines 797..825
                      src/Sell/Fulfillment/V1/Api/OrderApi.php on lines 550..578
                      src/Sell/Inventory/V1/Api/OfferApi.php on lines 1716..1744
                      src/Sell/Marketing/V1/Api/NegativeKeywordApi.php on lines 1281..1309

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 277.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 6 locations. Consider refactoring.
                      Open

                          public function getTransactionsAsync($x_ebay_c_marketplace_id = null, $filter = null, $limit = null, $offset = null, $sort = null)
    {
        return $this->getTransactionsAsyncWithHttpInfo($x_ebay_c_marketplace_id, $filter, $limit, $offset, $sort)
            ->then(
                function ($response) {
                      Severity: Major
                      Found in src/Sell/Finances/V1/Api/TransactionApi.php and 5 other locations - About 30 mins to fix
                      src/Sell/Feed/V1/Api/CustomerServiceMetricTaskApi.php on lines 723..731
                      src/Sell/Finances/V1/Api/PayoutApi.php on lines 774..782
                      src/Sell/Fulfillment/V1/Api/OrderApi.php on lines 527..535
                      src/Sell/Inventory/V1/Api/OfferApi.php on lines 1693..1701
                      src/Sell/Marketing/V1/Api/NegativeKeywordApi.php on lines 1258..1266

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 91.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status