Sign upLogin

brandon14/ebay-sdk-php

View on GitHub
Star
src/Sell/Fulfillment/V1/Api/OrderApi.php

Summary

Maintainability
F
1 wk
Test Coverage

File OrderApi.php has 583 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * This file is part of the trollandtoad/ebay-sdk-php package.
 *
Severity: Major
Found in src/Sell/Fulfillment/V1/Api/OrderApi.php - About 1 day to fix

    Method getOrdersRequest has 89 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getOrdersRequest($field_groups = null, $filter = null, $limit = null, $offset = null, $order_ids = null)
    {
        $resourcePath = '/order';
        $formParams = [];
        $queryParams = [];
    Severity: Major
    Found in src/Sell/Fulfillment/V1/Api/OrderApi.php - About 3 hrs to fix

      Function issueRefundRequest has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
      Open

          public function issueRefundRequest($order_id, $issue_refund_request = null)
    {
        // Verify the required parameter 'order_id' is set.
        if ($order_id === null || (\is_array($order_id) && count($order_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $order_id when calling issueRefund');
      Severity: Minor
      Found in src/Sell/Fulfillment/V1/Api/OrderApi.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getOrderRequest has 71 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getOrderRequest($order_id, $field_groups = null)
    {
        // Verify the required parameter 'order_id' is set.
        if ($order_id === null || (\is_array($order_id) && count($order_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $order_id when calling getOrder');
      Severity: Major
      Found in src/Sell/Fulfillment/V1/Api/OrderApi.php - About 2 hrs to fix

        Method issueRefundRequest has 70 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function issueRefundRequest($order_id, $issue_refund_request = null)
    {
        // Verify the required parameter 'order_id' is set.
        if ($order_id === null || (\is_array($order_id) && count($order_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $order_id when calling issueRefund');
        Severity: Major
        Found in src/Sell/Fulfillment/V1/Api/OrderApi.php - About 2 hrs to fix

          Function getOrderRequest has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getOrderRequest($order_id, $field_groups = null)
    {
        // Verify the required parameter 'order_id' is set.
        if ($order_id === null || (\is_array($order_id) && count($order_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $order_id when calling getOrder');
          Severity: Minor
          Found in src/Sell/Fulfillment/V1/Api/OrderApi.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method getOrdersWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getOrdersWithHttpInfo($field_groups = null, $filter = null, $limit = null, $offset = null, $order_ids = null)
    {
        $request = $this->getOrdersRequest($field_groups, $filter, $limit, $offset, $order_ids);

        try {
          Severity: Major
          Found in src/Sell/Fulfillment/V1/Api/OrderApi.php - About 2 hrs to fix

            Method issueRefundWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function issueRefundWithHttpInfo($order_id, $issue_refund_request = null)
    {
        $request = $this->issueRefundRequest($order_id, $issue_refund_request);

        try {
            Severity: Major
            Found in src/Sell/Fulfillment/V1/Api/OrderApi.php - About 2 hrs to fix

              Method getOrderWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function getOrderWithHttpInfo($order_id, $field_groups = null)
    {
        $request = $this->getOrderRequest($order_id, $field_groups);

        try {
              Severity: Major
              Found in src/Sell/Fulfillment/V1/Api/OrderApi.php - About 2 hrs to fix

                Function getOrdersRequest has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function getOrdersRequest($field_groups = null, $filter = null, $limit = null, $offset = null, $order_ids = null)
    {
        $resourcePath = '/order';
        $formParams = [];
        $queryParams = [];
                Severity: Minor
                Found in src/Sell/Fulfillment/V1/Api/OrderApi.php - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function issueRefundWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function issueRefundWithHttpInfo($order_id, $issue_refund_request = null)
    {
        $request = $this->issueRefundRequest($order_id, $issue_refund_request);

        try {
                Severity: Minor
                Found in src/Sell/Fulfillment/V1/Api/OrderApi.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function getOrderWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function getOrderWithHttpInfo($order_id, $field_groups = null)
    {
        $request = $this->getOrderRequest($order_id, $field_groups);

        try {
                Severity: Minor
                Found in src/Sell/Fulfillment/V1/Api/OrderApi.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function getOrdersWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function getOrdersWithHttpInfo($field_groups = null, $filter = null, $limit = null, $offset = null, $order_ids = null)
    {
        $request = $this->getOrdersRequest($field_groups, $filter, $limit, $offset, $order_ids);

        try {
                Severity: Minor
                Found in src/Sell/Fulfillment/V1/Api/OrderApi.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method getOrdersWithHttpInfo has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public function getOrdersWithHttpInfo($field_groups = null, $filter = null, $limit = null, $offset = null, $order_ids = null)
                Severity: Minor
                Found in src/Sell/Fulfillment/V1/Api/OrderApi.php - About 35 mins to fix

                  Method getOrdersAsync has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      public function getOrdersAsync($field_groups = null, $filter = null, $limit = null, $offset = null, $order_ids = null)
                  Severity: Minor
                  Found in src/Sell/Fulfillment/V1/Api/OrderApi.php - About 35 mins to fix

                    Method getOrdersAsyncWithHttpInfo has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public function getOrdersAsyncWithHttpInfo($field_groups = null, $filter = null, $limit = null, $offset = null, $order_ids = null)
                    Severity: Minor
                    Found in src/Sell/Fulfillment/V1/Api/OrderApi.php - About 35 mins to fix

                      Method getOrdersRequest has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          public function getOrdersRequest($field_groups = null, $filter = null, $limit = null, $offset = null, $order_ids = null)
                      Severity: Minor
                      Found in src/Sell/Fulfillment/V1/Api/OrderApi.php - About 35 mins to fix

                        Method getOrders has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            public function getOrders($field_groups = null, $filter = null, $limit = null, $offset = null, $order_ids = null)
                        Severity: Minor
                        Found in src/Sell/Fulfillment/V1/Api/OrderApi.php - About 35 mins to fix

                          Similar blocks of code found in 3 locations. Consider refactoring.
                          Open

                              public function getOrdersRequest($field_groups = null, $filter = null, $limit = null, $offset = null, $order_ids = null)
    {
        $resourcePath = '/order';
        $formParams = [];
        $queryParams = [];
                          Severity: Major
                          Found in src/Sell/Fulfillment/V1/Api/OrderApi.php and 2 other locations - About 3 days to fix
                          src/Sell/Feed/V1/Api/CustomerServiceMetricTaskApi.php on lines 789..899
                          src/Sell/Inventory/V1/Api/OfferApi.php on lines 1759..1869

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 654.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 6 locations. Consider refactoring.
                          Open

                              public function getOrdersWithHttpInfo($field_groups = null, $filter = null, $limit = null, $offset = null, $order_ids = null)
    {
        $request = $this->getOrdersRequest($field_groups, $filter, $limit, $offset, $order_ids);

        try {
                          Severity: Major
                          Found in src/Sell/Fulfillment/V1/Api/OrderApi.php and 5 other locations - About 2 days to fix
                          src/Sell/Feed/V1/Api/CustomerServiceMetricTaskApi.php on lines 643..708
                          src/Sell/Finances/V1/Api/PayoutApi.php on lines 694..759
                          src/Sell/Finances/V1/Api/TransactionApi.php on lines 438..503
                          src/Sell/Inventory/V1/Api/OfferApi.php on lines 1613..1678
                          src/Sell/Marketing/V1/Api/NegativeKeywordApi.php on lines 1178..1243

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 573.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 6 locations. Consider refactoring.
                          Open

                              public function getOrdersAsyncWithHttpInfo($field_groups = null, $filter = null, $limit = null, $offset = null, $order_ids = null)
    {
        $returnType = '\TNT\Ebay\Sell\Fulfillment\V1\Model\OrderSearchPagedCollection';
        $request = $this->getOrdersRequest($field_groups, $filter, $limit, $offset, $order_ids);
                          Severity: Major
                          Found in src/Sell/Fulfillment/V1/Api/OrderApi.php and 5 other locations - About 1 day to fix
                          src/Sell/Feed/V1/Api/CustomerServiceMetricTaskApi.php on lines 746..774
                          src/Sell/Finances/V1/Api/PayoutApi.php on lines 797..825
                          src/Sell/Finances/V1/Api/TransactionApi.php on lines 541..569
                          src/Sell/Inventory/V1/Api/OfferApi.php on lines 1716..1744
                          src/Sell/Marketing/V1/Api/NegativeKeywordApi.php on lines 1281..1309

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 277.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 6 locations. Consider refactoring.
                          Open

                              public function getOrdersAsync($field_groups = null, $filter = null, $limit = null, $offset = null, $order_ids = null)
    {
        return $this->getOrdersAsyncWithHttpInfo($field_groups, $filter, $limit, $offset, $order_ids)
            ->then(
                function ($response) {
                          Severity: Major
                          Found in src/Sell/Fulfillment/V1/Api/OrderApi.php and 5 other locations - About 30 mins to fix
                          src/Sell/Feed/V1/Api/CustomerServiceMetricTaskApi.php on lines 723..731
                          src/Sell/Finances/V1/Api/PayoutApi.php on lines 774..782
                          src/Sell/Finances/V1/Api/TransactionApi.php on lines 518..526
                          src/Sell/Inventory/V1/Api/OfferApi.php on lines 1693..1701
                          src/Sell/Marketing/V1/Api/NegativeKeywordApi.php on lines 1258..1266

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 91.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status