Sign upLogin

brandon14/ebay-sdk-php

View on GitHub
Star
src/Sell/Fulfillment/V1/Api/ShippingFulfillmentApi.php

Summary

Maintainability
F
1 wk
Test Coverage

File ShippingFulfillmentApi.php has 564 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * This file is part of the trollandtoad/ebay-sdk-php package.
 *
Severity: Major
Found in src/Sell/Fulfillment/V1/Api/ShippingFulfillmentApi.php - About 1 day to fix

    Function createShippingFulfillmentRequest has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

        public function createShippingFulfillmentRequest($order_id, $shipping_fulfillment_details)
    {
        // Verify the required parameter 'order_id' is set.
        if ($order_id === null || (\is_array($order_id) && count($order_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $order_id when calling createShippingFulfillment');
    Severity: Minor
    Found in src/Sell/Fulfillment/V1/Api/ShippingFulfillmentApi.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getShippingFulfillmentRequest has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getShippingFulfillmentRequest($fulfillment_id, $order_id)
    {
        // Verify the required parameter 'fulfillment_id' is set.
        if ($fulfillment_id === null || (\is_array($fulfillment_id) && count($fulfillment_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $fulfillment_id when calling getShippingFulfillment');
    Severity: Minor
    Found in src/Sell/Fulfillment/V1/Api/ShippingFulfillmentApi.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getShippingFulfillmentRequest has 74 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getShippingFulfillmentRequest($fulfillment_id, $order_id)
    {
        // Verify the required parameter 'fulfillment_id' is set.
        if ($fulfillment_id === null || (\is_array($fulfillment_id) && count($fulfillment_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $fulfillment_id when calling getShippingFulfillment');
    Severity: Major
    Found in src/Sell/Fulfillment/V1/Api/ShippingFulfillmentApi.php - About 2 hrs to fix

      Method createShippingFulfillmentRequest has 73 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function createShippingFulfillmentRequest($order_id, $shipping_fulfillment_details)
    {
        // Verify the required parameter 'order_id' is set.
        if ($order_id === null || (\is_array($order_id) && count($order_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $order_id when calling createShippingFulfillment');
      Severity: Major
      Found in src/Sell/Fulfillment/V1/Api/ShippingFulfillmentApi.php - About 2 hrs to fix

        Function getShippingFulfillmentsRequest has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getShippingFulfillmentsRequest($order_id)
    {
        // Verify the required parameter 'order_id' is set.
        if ($order_id === null || (\is_array($order_id) && count($order_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $order_id when calling getShippingFulfillments');
        Severity: Minor
        Found in src/Sell/Fulfillment/V1/Api/ShippingFulfillmentApi.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getShippingFulfillmentsRequest has 64 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getShippingFulfillmentsRequest($order_id)
    {
        // Verify the required parameter 'order_id' is set.
        if ($order_id === null || (\is_array($order_id) && count($order_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $order_id when calling getShippingFulfillments');
        Severity: Major
        Found in src/Sell/Fulfillment/V1/Api/ShippingFulfillmentApi.php - About 2 hrs to fix

          Method getShippingFulfillmentWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getShippingFulfillmentWithHttpInfo($fulfillment_id, $order_id)
    {
        $request = $this->getShippingFulfillmentRequest($fulfillment_id, $order_id);

        try {
          Severity: Major
          Found in src/Sell/Fulfillment/V1/Api/ShippingFulfillmentApi.php - About 2 hrs to fix

            Method getShippingFulfillmentsWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function getShippingFulfillmentsWithHttpInfo($order_id)
    {
        $request = $this->getShippingFulfillmentsRequest($order_id);

        try {
            Severity: Major
            Found in src/Sell/Fulfillment/V1/Api/ShippingFulfillmentApi.php - About 2 hrs to fix

              Method createShippingFulfillmentWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function createShippingFulfillmentWithHttpInfo($order_id, $shipping_fulfillment_details)
    {
        $request = $this->createShippingFulfillmentRequest($order_id, $shipping_fulfillment_details);

        try {
              Severity: Major
              Found in src/Sell/Fulfillment/V1/Api/ShippingFulfillmentApi.php - About 2 hrs to fix

                Function getShippingFulfillmentWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function getShippingFulfillmentWithHttpInfo($fulfillment_id, $order_id)
    {
        $request = $this->getShippingFulfillmentRequest($fulfillment_id, $order_id);

        try {
                Severity: Minor
                Found in src/Sell/Fulfillment/V1/Api/ShippingFulfillmentApi.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function createShippingFulfillmentWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function createShippingFulfillmentWithHttpInfo($order_id, $shipping_fulfillment_details)
    {
        $request = $this->createShippingFulfillmentRequest($order_id, $shipping_fulfillment_details);

        try {
                Severity: Minor
                Found in src/Sell/Fulfillment/V1/Api/ShippingFulfillmentApi.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function getShippingFulfillmentsWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function getShippingFulfillmentsWithHttpInfo($order_id)
    {
        $request = $this->getShippingFulfillmentsRequest($order_id);

        try {
                Severity: Minor
                Found in src/Sell/Fulfillment/V1/Api/ShippingFulfillmentApi.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function getShippingFulfillmentRequest($fulfillment_id, $order_id)
    {
        // Verify the required parameter 'fulfillment_id' is set.
        if ($fulfillment_id === null || (\is_array($fulfillment_id) && count($fulfillment_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $fulfillment_id when calling getShippingFulfillment');
                Severity: Major
                Found in src/Sell/Fulfillment/V1/Api/ShippingFulfillmentApi.php and 1 other location - About 2 days to fix
                src/Sell/Analytics/V1/Api/SellerStandardsProfileApi.php on lines 540..635

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 571.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status