brandon14/ebay-sdk-php

View on GitHub
src/Sell/Inventory/V1/Api/InventoryItemGroupApi.php

Summary

Maintainability
F
1 mo
Test Coverage

File InventoryItemGroupApi.php has 538 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * This file is part of the trollandtoad/ebay-sdk-php package.
 *
Severity: Major
Found in src/Sell/Inventory/V1/Api/InventoryItemGroupApi.php - About 1 day to fix

    Function createOrReplaceInventoryItemGroupRequest has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
    Open

        public function createOrReplaceInventoryItemGroupRequest($content_language, $inventory_item_group_key, $inventory_item_group)
        {
            // Verify the required parameter 'content_language' is set.
            if ($content_language === null || (\is_array($content_language) && count($content_language) === 0)) {
                throw new \InvalidArgumentException('Missing the required parameter $content_language when calling createOrReplaceInventoryItemGroup');
    Severity: Minor
    Found in src/Sell/Inventory/V1/Api/InventoryItemGroupApi.php - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method createOrReplaceInventoryItemGroupRequest has 79 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function createOrReplaceInventoryItemGroupRequest($content_language, $inventory_item_group_key, $inventory_item_group)
        {
            // Verify the required parameter 'content_language' is set.
            if ($content_language === null || (\is_array($content_language) && count($content_language) === 0)) {
                throw new \InvalidArgumentException('Missing the required parameter $content_language when calling createOrReplaceInventoryItemGroup');
    Severity: Major
    Found in src/Sell/Inventory/V1/Api/InventoryItemGroupApi.php - About 3 hrs to fix

      Method createOrReplaceInventoryItemGroupWithHttpInfo has 72 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function createOrReplaceInventoryItemGroupWithHttpInfo($content_language, $inventory_item_group_key, $inventory_item_group)
          {
              $request = $this->createOrReplaceInventoryItemGroupRequest($content_language, $inventory_item_group_key, $inventory_item_group);
      
              try {
      Severity: Major
      Found in src/Sell/Inventory/V1/Api/InventoryItemGroupApi.php - About 2 hrs to fix

        Function getInventoryItemGroupRequest has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getInventoryItemGroupRequest($inventory_item_group_key)
            {
                // Verify the required parameter 'inventory_item_group_key' is set.
                if ($inventory_item_group_key === null || (\is_array($inventory_item_group_key) && count($inventory_item_group_key) === 0)) {
                    throw new \InvalidArgumentException('Missing the required parameter $inventory_item_group_key when calling getInventoryItemGroup');
        Severity: Minor
        Found in src/Sell/Inventory/V1/Api/InventoryItemGroupApi.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function deleteInventoryItemGroupRequest has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
        Open

            public function deleteInventoryItemGroupRequest($inventory_item_group_key)
            {
                // Verify the required parameter 'inventory_item_group_key' is set.
                if ($inventory_item_group_key === null || (\is_array($inventory_item_group_key) && count($inventory_item_group_key) === 0)) {
                    throw new \InvalidArgumentException('Missing the required parameter $inventory_item_group_key when calling deleteInventoryItemGroup');
        Severity: Minor
        Found in src/Sell/Inventory/V1/Api/InventoryItemGroupApi.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getInventoryItemGroupRequest has 64 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getInventoryItemGroupRequest($inventory_item_group_key)
            {
                // Verify the required parameter 'inventory_item_group_key' is set.
                if ($inventory_item_group_key === null || (\is_array($inventory_item_group_key) && count($inventory_item_group_key) === 0)) {
                    throw new \InvalidArgumentException('Missing the required parameter $inventory_item_group_key when calling getInventoryItemGroup');
        Severity: Major
        Found in src/Sell/Inventory/V1/Api/InventoryItemGroupApi.php - About 2 hrs to fix

          Method deleteInventoryItemGroupRequest has 64 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function deleteInventoryItemGroupRequest($inventory_item_group_key)
              {
                  // Verify the required parameter 'inventory_item_group_key' is set.
                  if ($inventory_item_group_key === null || (\is_array($inventory_item_group_key) && count($inventory_item_group_key) === 0)) {
                      throw new \InvalidArgumentException('Missing the required parameter $inventory_item_group_key when calling deleteInventoryItemGroup');
          Severity: Major
          Found in src/Sell/Inventory/V1/Api/InventoryItemGroupApi.php - About 2 hrs to fix

            Method getInventoryItemGroupWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function getInventoryItemGroupWithHttpInfo($inventory_item_group_key)
                {
                    $request = $this->getInventoryItemGroupRequest($inventory_item_group_key);
            
                    try {
            Severity: Major
            Found in src/Sell/Inventory/V1/Api/InventoryItemGroupApi.php - About 2 hrs to fix

              Function createOrReplaceInventoryItemGroupWithHttpInfo has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function createOrReplaceInventoryItemGroupWithHttpInfo($content_language, $inventory_item_group_key, $inventory_item_group)
                  {
                      $request = $this->createOrReplaceInventoryItemGroupRequest($content_language, $inventory_item_group_key, $inventory_item_group);
              
                      try {
              Severity: Minor
              Found in src/Sell/Inventory/V1/Api/InventoryItemGroupApi.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getInventoryItemGroupWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getInventoryItemGroupWithHttpInfo($inventory_item_group_key)
                  {
                      $request = $this->getInventoryItemGroupRequest($inventory_item_group_key);
              
                      try {
              Severity: Minor
              Found in src/Sell/Inventory/V1/Api/InventoryItemGroupApi.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function deleteInventoryItemGroupWithHttpInfo has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function deleteInventoryItemGroupWithHttpInfo($inventory_item_group_key)
                  {
                      $request = $this->deleteInventoryItemGroupRequest($inventory_item_group_key);
              
                      try {
              Severity: Minor
              Found in src/Sell/Inventory/V1/Api/InventoryItemGroupApi.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              <?php
              
              /**
               * This file is part of the trollandtoad/ebay-sdk-php package.
               *
              Severity: Major
              Found in src/Sell/Inventory/V1/Api/InventoryItemGroupApi.php and 1 other location - About 3 wks to fix
              src/Sell/Inventory/V1/Api/ProductCompatibilityApi.php on lines 1..913

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 4246.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status